Revert "Use ShellKind::try_quote whenever we need to quote shell args" (#41022)

Reverts zed-industries/zed#40912

Closes https://github.com/zed-industries/zed/issues/41010
This commit is contained in:
Jakub Konka
2025-10-23 16:06:47 +00:00
committed by GitHub
parent 738e248109
commit 023ac1b649
22 changed files with 232 additions and 317 deletions
+3 -11
View File
@@ -32,7 +32,7 @@ use ui::{
SharedString, Styled, StyledExt, ToggleButton, ToggleState, Toggleable, Tooltip, Window, div,
h_flex, relative, rems, v_flex,
};
use util::{ResultExt, rel_path::RelPath, shell::ShellKind};
use util::{ResultExt, rel_path::RelPath};
use workspace::{ModalView, Workspace, notifications::DetachAndPromptErr, pane};
use crate::{attach_modal::AttachModal, debugger_panel::DebugPanel};
@@ -839,11 +839,7 @@ impl ConfigureMode {
};
}
let command = self.program.read(cx).text(cx);
let mut args = ShellKind::Posix
.split(&command)
.into_iter()
.flatten()
.peekable();
let mut args = shlex::split(&command).into_iter().flatten().peekable();
let mut env = FxHashMap::default();
while args.peek().is_some_and(|arg| arg.contains('=')) {
let arg = args.next().unwrap();
@@ -1269,11 +1265,7 @@ impl PickerDelegate for DebugDelegate {
})
.unwrap_or_default();
let mut args = ShellKind::Posix
.split(&text)
.into_iter()
.flatten()
.peekable();
let mut args = shlex::split(&text).into_iter().flatten().peekable();
let mut env = HashMap::default();
while args.peek().is_some_and(|arg| arg.contains('=')) {
let arg = args.next().unwrap();