Fake tests rewritten to assert real behavior: - audio_smoke: conversion tests now actually Convert() samples and verify output; waveform length/summary assertions tightened to exact values - plugin_format_conversion: RowBytes/U8ToU16/LoadImageFile now call real production code (VideoParams::GetBytesPerPixel, sws scaler, OIIO decode of tests/img.png with known pixel values) - core_color: HSV round trip now verifies fromHsv(toHsv(c)) == c instead of comparing toHsv against its own accessors - core_bezier/node_inputimmediate: expected values replaced with independently derived constants instead of re-running the code under test - common_commandlineparser/common_debug/common_jobtime: capture stdout/stderr/qDebug and assert actual output content - proxy_manager: ProxyFinished test now drives a real proxy job instead of emitting the signal itself; proxy_dialog/panel/proxy/preferences/timeruler tests assert real widget state - viewer_smoke/preview_autocacher/render_misc: zero-assertion tests given observable-state assertions or removed where nothing is observable Duplicates removed: - plugin_smoke_test.cpp: 18 tests duplicated from plugin_paraminstance / plugin_support_* / plugin_renderer_readback (751 -> 180 lines) - module_smoke HumanStrings tests covered precisely by ui_humanstrings_test - render_misc duplicate kDefaultInterpolation constant check Removed by policy (skip allowed, never disabled): - all DISABLED_ prefixes: re-enabled as real offscreen tests or deleted - ffmpeg_decoder_hw: hardcoded personal path replaced with OAK_TEST_HW_DECODE_FILE env var, GTEST_SKIP when unset Also: - config_test: restore Config defaults after run (cross-test pollution) - render_worker_footage: drop /tmp debug-output scaffolding - previewaudiodevice construction test asserts the real bugfix
80 lines
1.8 KiB
C++
80 lines
1.8 KiB
C++
#include <gtest/gtest.h>
|
|
|
|
#include <QSignalSpy>
|
|
|
|
#include "node/generator/solid/solid.h"
|
|
#include "node/project.h"
|
|
#include "widget/nodeview/nodeview.h"
|
|
|
|
using namespace olive;
|
|
|
|
class NodeViewTest : public ::testing::Test {
|
|
protected:
|
|
void SetUp() override
|
|
{
|
|
ColorManager::SetUpDefaultConfig();
|
|
|
|
project_ = std::make_unique<Project>();
|
|
project_->Initialize();
|
|
}
|
|
|
|
std::unique_ptr<Project> project_;
|
|
};
|
|
|
|
TEST_F(NodeViewTest, ConstructionCreatesEmptyView)
|
|
{
|
|
NodeView view;
|
|
EXPECT_TRUE(view.GetContexts().isEmpty());
|
|
EXPECT_FALSE(view.IsGroupOverlay());
|
|
}
|
|
|
|
TEST_F(NodeViewTest, SetContextsUpdatesContextList)
|
|
{
|
|
auto *solid = new SolidGenerator();
|
|
solid->setParent(project_.get());
|
|
|
|
NodeView view;
|
|
view.SetContexts({ solid });
|
|
|
|
EXPECT_EQ(view.GetContexts().size(), 1);
|
|
EXPECT_EQ(view.GetContexts().first(), solid);
|
|
}
|
|
|
|
TEST_F(NodeViewTest, ShowSelectedNodeInParamEditorNoSelectionIsNoOp)
|
|
{
|
|
NodeView view;
|
|
|
|
QSignalSpy changed_with_ctx_spy(
|
|
&view, &NodeView::NodeSelectionChangedWithContexts);
|
|
|
|
// The action must exist; silently skipping the trigger would make this
|
|
// test pass without exercising anything
|
|
QAction *show_params_action = nullptr;
|
|
foreach (QAction *action, view.actions()) {
|
|
if (action->property("id").toString() ==
|
|
QStringLiteral("shownodeparams")) {
|
|
show_params_action = action;
|
|
break;
|
|
}
|
|
}
|
|
ASSERT_NE(show_params_action, nullptr)
|
|
<< "NodeView has no action with id 'shownodeparams'";
|
|
|
|
// With nothing selected, triggering it must not emit a selection change
|
|
show_params_action->trigger();
|
|
EXPECT_EQ(changed_with_ctx_spy.count(), 0);
|
|
}
|
|
|
|
TEST_F(NodeViewTest, ClearGraphRemovesContexts)
|
|
{
|
|
auto *solid = new SolidGenerator();
|
|
solid->setParent(project_.get());
|
|
|
|
NodeView view;
|
|
view.SetContexts({ solid });
|
|
EXPECT_FALSE(view.GetContexts().isEmpty());
|
|
|
|
view.ClearGraph();
|
|
EXPECT_TRUE(view.GetContexts().isEmpty());
|
|
}
|