Files
oak-editor/app/node/keying/despill/despill.cpp
T
Mike-Solar bb40b4923e style: unify identifier naming per updated conventions
Automated with clang-tidy readability-identifier-naming (config added to
.clang-tidy) plus scripted passes, per the updated rules now documented
in CONTRIBUTING.md:

- types (class/struct/enum/alias/template params): PascalCase
- functions, variables, members: snake_case (incl. rational -> Rational)
- private/protected members: trailing underscore; static member
  variables likewise (instance_, available_themes_)
- constants and enum values: snake_case (kLinear -> k_linear,
  F32P -> f32p); ALL_CAPS reserved for macros
- macros: OAK_ prefix (OLIVE_ADD_TEST/OLIVE_ASSERT/OLIVE_CONFIG ->
  OAK_ADD_TEST/OAK_ASSERT/OAK_CONFIG, GL_PREAMBLE -> OAK_GL_PREAMBLE,
  include guards -> OAK_*)
- file names: all lowercase (Current/Plugin/OliveHost/OliveClip/
  OlivePluginInstance -> current/plugin/olivehost/oliveclip/
  oliveplugininstance)
- getters share the member name sans underscore, setters set_foo()
- Qt and third-party (OpenFX) virtual overrides and framework callbacks
  keep their original names (exempt in .clang-tidy)

Manual follow-ups required where automation could not reach:
- string-based QMetaObject/SIGNAL/SLOT references updated to renamed
  methods (AddTask, CreatedFile, DeleteSpecificFile, moveSelectionUp, ...)
- macro bodies referencing renamed methods (OLIVE_CONFIG,
  NODE_DEFAULT_DESTRUCTOR, MANAGEDDISPLAYWIDGET_*)
- self-shadowing locals renamed where signals/methods became same-named
  (size_changed, worker_count, selected_items, import param, filters)
- third_party OFX member/namespace usages restored (OFX::Host::*,
  _created, _clipPrefsDirty, createInstance, clearPersistentMessage)
- STL protocol aliases restored (const_iterator) with .clang-tidy
  ignore rules; qHash overloads restored

Full build and test suite pass: ctest 4/4, ~1960 gtest cases green.
2026-07-19 16:10:54 +08:00

117 lines
3.2 KiB
C++

/***
Olive - Non-Linear Video Editor
Copyright (C) 2019 Olive Team
Modifications Copyright (C) 2025 mikesolar
This program is free software: you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation, either version 3 of the License, or
(at your option) any later version.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>.
***/
#include "despill.h"
#include "node/project.h"
namespace olive
{
const QString DespillNode::k_texture_input = QStringLiteral("tex_in");
const QString DespillNode::k_color_input = QStringLiteral("color_in");
const QString DespillNode::k_method_input = QStringLiteral("method_in");
const QString DespillNode::k_preserve_luminance_input =
QStringLiteral("preserve_luminance_input");
#define super Node
DespillNode::DespillNode()
{
add_input(k_texture_input, NodeValue::k_texture,
InputFlags(k_input_flag_not_keyframable));
add_input(k_color_input, NodeValue::k_combo, 0);
add_input(k_method_input, NodeValue::k_combo, 0);
add_input(k_preserve_luminance_input, NodeValue::k_boolean, false);
set_flag(k_video_effect);
set_effect_input(k_texture_input);
}
QString DespillNode::name() const
{
return tr("Despill");
}
QString DespillNode::id() const
{
return QStringLiteral("org.olivevideoeditor.Olive.despill");
}
QVector<Node::CategoryID> DespillNode::category() const
{
return { k_category_keying };
}
QString DespillNode::description() const
{
return tr("Selection of simple despill operations");
}
void DespillNode::retranslate()
{
super::retranslate();
set_input_name(k_texture_input, tr("Input"));
set_input_name(k_color_input, tr("Key Color"));
set_combo_box_strings(k_color_input, { tr("Green"), tr("Blue") });
set_input_name(k_method_input, tr("Method"));
set_combo_box_strings(k_method_input, { tr("Average"), tr("Double Red Average"),
tr("Double Average"), tr("Limit") });
set_input_name(k_preserve_luminance_input, tr("Preserve Luminance"));
}
ShaderCode DespillNode::get_shader_code(const ShaderRequest &request) const
{
Q_UNUSED(request)
return ShaderCode(
FileFunctions::read_file_as_string(":/shaders/despill.frag"));
}
void DespillNode::value(const NodeValueRow &value, const NodeGlobals &globals,
NodeValueTable *table) const
{
ShaderJob job;
job.insert(value);
// Set luma coefficients
double luma_coeffs[3] = { 0.0f, 0.0f, 0.0f };
if (project() && project()->color_manager()) {
project()->color_manager()->get_default_luma_coefs(luma_coeffs);
} else {
luma_coeffs[0] = 0.2126;
luma_coeffs[1] = 0.7152;
luma_coeffs[2] = 0.0722;
}
job.insert(
QStringLiteral("luma_coeffs"),
NodeValue(NodeValue::k_vec3,
QVector3D(luma_coeffs[0], luma_coeffs[1], luma_coeffs[2])));
// If there's no texture, no need to run an operation
if (TexturePtr tex = job.get(k_texture_input).to_texture()) {
table->push(NodeValue::k_texture, tex->to_job(job), this);
}
}
} // namespace olive