Automated with clang-tidy readability-identifier-naming (config added to .clang-tidy) plus scripted passes, per the updated rules now documented in CONTRIBUTING.md: - types (class/struct/enum/alias/template params): PascalCase - functions, variables, members: snake_case (incl. rational -> Rational) - private/protected members: trailing underscore; static member variables likewise (instance_, available_themes_) - constants and enum values: snake_case (kLinear -> k_linear, F32P -> f32p); ALL_CAPS reserved for macros - macros: OAK_ prefix (OLIVE_ADD_TEST/OLIVE_ASSERT/OLIVE_CONFIG -> OAK_ADD_TEST/OAK_ASSERT/OAK_CONFIG, GL_PREAMBLE -> OAK_GL_PREAMBLE, include guards -> OAK_*) - file names: all lowercase (Current/Plugin/OliveHost/OliveClip/ OlivePluginInstance -> current/plugin/olivehost/oliveclip/ oliveplugininstance) - getters share the member name sans underscore, setters set_foo() - Qt and third-party (OpenFX) virtual overrides and framework callbacks keep their original names (exempt in .clang-tidy) Manual follow-ups required where automation could not reach: - string-based QMetaObject/SIGNAL/SLOT references updated to renamed methods (AddTask, CreatedFile, DeleteSpecificFile, moveSelectionUp, ...) - macro bodies referencing renamed methods (OLIVE_CONFIG, NODE_DEFAULT_DESTRUCTOR, MANAGEDDISPLAYWIDGET_*) - self-shadowing locals renamed where signals/methods became same-named (size_changed, worker_count, selected_items, import param, filters) - third_party OFX member/namespace usages restored (OFX::Host::*, _created, _clipPrefsDirty, createInstance, clearPersistentMessage) - STL protocol aliases restored (const_iterator) with .clang-tidy ignore rules; qHash overloads restored Full build and test suite pass: ctest 4/4, ~1960 gtest cases green.
96 lines
2.9 KiB
C++
96 lines
2.9 KiB
C++
/***
|
|
|
|
Olive - Non-Linear Video Editor
|
|
Copyright (C) 2022 Olive Team
|
|
Modifications Copyright (C) 2025 mikesolar
|
|
|
|
This program is free software: you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation, either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
***/
|
|
|
|
#include "cineformsection.h"
|
|
|
|
#include <QGridLayout>
|
|
#include <QLabel>
|
|
|
|
namespace olive
|
|
{
|
|
|
|
CineformSection::CineformSection(QWidget *parent)
|
|
: CodecSection(parent)
|
|
{
|
|
QGridLayout *layout = new QGridLayout(this);
|
|
|
|
layout->setContentsMargins(0, 0, 0, 0);
|
|
|
|
int row = 0;
|
|
|
|
layout->addWidget(new QLabel(tr("Quality:")), row, 0);
|
|
|
|
quality_combobox_ = new QComboBox();
|
|
|
|
/* Correspond to the following indexes for FFmpeg
|
|
*
|
|
* -quality <int> E..V....... set quality (from 0 to 12) (default film3+)
|
|
* film3+ 0 E..V.......
|
|
* film3 1 E..V.......
|
|
* film2+ 2 E..V.......
|
|
* film2 3 E..V.......
|
|
* film1.5 4 E..V.......
|
|
* film1+ 5 E..V.......
|
|
* film1 6 E..V.......
|
|
* high+ 7 E..V.......
|
|
* high 8 E..V.......
|
|
* medium+ 9 E..V.......
|
|
* medium 10 E..V.......
|
|
* low+ 11 E..V.......
|
|
* low 12 E..V.......
|
|
*
|
|
*/
|
|
|
|
quality_combobox_->addItem(tr("Film Scan 3+"));
|
|
quality_combobox_->addItem(tr("Film Scan 3"));
|
|
quality_combobox_->addItem(tr("Film Scan 2+"));
|
|
quality_combobox_->addItem(tr("Film Scan 2"));
|
|
quality_combobox_->addItem(tr("Film Scan 1.5"));
|
|
quality_combobox_->addItem(tr("Film Scan 1+"));
|
|
quality_combobox_->addItem(tr("Film Scan 1"));
|
|
quality_combobox_->addItem(tr("High+"));
|
|
quality_combobox_->addItem(tr("High"));
|
|
quality_combobox_->addItem(tr("Medium+"));
|
|
quality_combobox_->addItem(tr("Medium"));
|
|
quality_combobox_->addItem(tr("Low+"));
|
|
quality_combobox_->addItem(tr("Low"));
|
|
|
|
// Default to "medium"
|
|
quality_combobox_->setCurrentIndex(10);
|
|
|
|
layout->addWidget(quality_combobox_, row, 1);
|
|
}
|
|
|
|
void CineformSection::add_opts(EncodingParams *params)
|
|
{
|
|
params->set_video_option(
|
|
QStringLiteral("quality"),
|
|
QString::number(quality_combobox_->currentIndex()));
|
|
}
|
|
|
|
void CineformSection::set_opts(const EncodingParams *p)
|
|
{
|
|
quality_combobox_->setCurrentIndex(
|
|
p->video_option(QStringLiteral("quality")).toInt());
|
|
}
|
|
|
|
}
|