Automated with clang-tidy readability-identifier-naming (config added to .clang-tidy) plus scripted passes, per the updated rules now documented in CONTRIBUTING.md: - types (class/struct/enum/alias/template params): PascalCase - functions, variables, members: snake_case (incl. rational -> Rational) - private/protected members: trailing underscore; static member variables likewise (instance_, available_themes_) - constants and enum values: snake_case (kLinear -> k_linear, F32P -> f32p); ALL_CAPS reserved for macros - macros: OAK_ prefix (OLIVE_ADD_TEST/OLIVE_ASSERT/OLIVE_CONFIG -> OAK_ADD_TEST/OAK_ASSERT/OAK_CONFIG, GL_PREAMBLE -> OAK_GL_PREAMBLE, include guards -> OAK_*) - file names: all lowercase (Current/Plugin/OliveHost/OliveClip/ OlivePluginInstance -> current/plugin/olivehost/oliveclip/ oliveplugininstance) - getters share the member name sans underscore, setters set_foo() - Qt and third-party (OpenFX) virtual overrides and framework callbacks keep their original names (exempt in .clang-tidy) Manual follow-ups required where automation could not reach: - string-based QMetaObject/SIGNAL/SLOT references updated to renamed methods (AddTask, CreatedFile, DeleteSpecificFile, moveSelectionUp, ...) - macro bodies referencing renamed methods (OLIVE_CONFIG, NODE_DEFAULT_DESTRUCTOR, MANAGEDDISPLAYWIDGET_*) - self-shadowing locals renamed where signals/methods became same-named (size_changed, worker_count, selected_items, import param, filters) - third_party OFX member/namespace usages restored (OFX::Host::*, _created, _clipPrefsDirty, createInstance, clearPersistentMessage) - STL protocol aliases restored (const_iterator) with .clang-tidy ignore rules; qHash overloads restored Full build and test suite pass: ctest 4/4, ~1960 gtest cases green.
87 lines
2.2 KiB
C++
87 lines
2.2 KiB
C++
/***
|
|
|
|
Olive - Non-Linear Video Editor
|
|
Copyright (C) 2022 Olive Team
|
|
Modifications Copyright (C) 2025 mikesolar
|
|
|
|
This program is free software: you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation, either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
***/
|
|
|
|
#ifndef OAK_FFMPEGENCODER_H
|
|
#define OAK_FFMPEGENCODER_H
|
|
|
|
#include <ffmpeg_bridge/ffmpeg_bridge.h>
|
|
|
|
#include "codec/encoder.h"
|
|
|
|
namespace olive
|
|
{
|
|
|
|
/**
|
|
* @brief An Encoder derivative that uses the ffmpeg_bridge library for encoding
|
|
*
|
|
* All encoding work happens inside the ffmpeg_bridge shared library through
|
|
* its pure C API; this class only translates EncodingParams into a bridge
|
|
* configuration and forwards calls.
|
|
*/
|
|
class FFmpegEncoder : public Encoder {
|
|
Q_OBJECT
|
|
public:
|
|
FFmpegEncoder(const EncodingParams ¶ms);
|
|
|
|
virtual QStringList
|
|
get_pixel_formats_for_codec(ExportCodec::Codec c) const override;
|
|
|
|
virtual std::vector<SampleFormat>
|
|
get_sample_formats_for_codec(ExportCodec::Codec c) const override;
|
|
|
|
virtual bool open() override;
|
|
|
|
virtual bool write_frame(olive::FramePtr frame,
|
|
olive::core::Rational time) override;
|
|
|
|
virtual bool write_audio(const olive::SampleBuffer &audio) override;
|
|
|
|
bool write_audio_data(const AudioParams &audio_params, const uint8_t **data,
|
|
int input_sample_count);
|
|
|
|
virtual bool write_subtitle(const SubtitleBlock *sub_block) override;
|
|
|
|
virtual void close() override;
|
|
|
|
virtual PixelFormat get_desired_pixel_format() const override
|
|
{
|
|
return video_conversion_fmt_;
|
|
}
|
|
|
|
private:
|
|
/**
|
|
* @brief Copy the last error message from the bridge into the encoder error state
|
|
*/
|
|
void set_error_from_bridge();
|
|
|
|
static int export_codec_to_bridge(ExportCodec::Codec c);
|
|
|
|
FBEncoder *encoder_;
|
|
|
|
PixelFormat video_conversion_fmt_;
|
|
|
|
bool open_;
|
|
};
|
|
|
|
}
|
|
|
|
#endif // OAK_FFMPEGENCODER_H
|