Mike-Solar
bb40b4923e
Automated with clang-tidy readability-identifier-naming (config added to .clang-tidy) plus scripted passes, per the updated rules now documented in CONTRIBUTING.md: - types (class/struct/enum/alias/template params): PascalCase - functions, variables, members: snake_case (incl. rational -> Rational) - private/protected members: trailing underscore; static member variables likewise (instance_, available_themes_) - constants and enum values: snake_case (kLinear -> k_linear, F32P -> f32p); ALL_CAPS reserved for macros - macros: OAK_ prefix (OLIVE_ADD_TEST/OLIVE_ASSERT/OLIVE_CONFIG -> OAK_ADD_TEST/OAK_ASSERT/OAK_CONFIG, GL_PREAMBLE -> OAK_GL_PREAMBLE, include guards -> OAK_*) - file names: all lowercase (Current/Plugin/OliveHost/OliveClip/ OlivePluginInstance -> current/plugin/olivehost/oliveclip/ oliveplugininstance) - getters share the member name sans underscore, setters set_foo() - Qt and third-party (OpenFX) virtual overrides and framework callbacks keep their original names (exempt in .clang-tidy) Manual follow-ups required where automation could not reach: - string-based QMetaObject/SIGNAL/SLOT references updated to renamed methods (AddTask, CreatedFile, DeleteSpecificFile, moveSelectionUp, ...) - macro bodies referencing renamed methods (OLIVE_CONFIG, NODE_DEFAULT_DESTRUCTOR, MANAGEDDISPLAYWIDGET_*) - self-shadowing locals renamed where signals/methods became same-named (size_changed, worker_count, selected_items, import param, filters) - third_party OFX member/namespace usages restored (OFX::Host::*, _created, _clipPrefsDirty, createInstance, clearPersistentMessage) - STL protocol aliases restored (const_iterator) with .clang-tidy ignore rules; qHash overloads restored Full build and test suite pass: ctest 4/4, ~1960 gtest cases green.
35 lines
889 B
C++
35 lines
889 B
C++
#include <gtest/gtest.h>
|
|
|
|
#include <QOpenGLContext>
|
|
#include <QVariant>
|
|
#include <cstdlib>
|
|
|
|
#include "render/opengl/openglrenderer.h"
|
|
|
|
TEST(OpenGLRenderer, DownloadFromTextureWithoutCurrentContext)
|
|
{
|
|
if (std::getenv("CI")) {
|
|
GTEST_SKIP() << "Skipping OpenGL test in CI environment";
|
|
}
|
|
|
|
QOpenGLContext context;
|
|
if (!context.create()) {
|
|
GTEST_SKIP()
|
|
<< "Skipping OpenGL test because no context can be created";
|
|
}
|
|
ASSERT_EQ(QOpenGLContext::currentContext(), nullptr);
|
|
|
|
olive::OpenGLRenderer renderer;
|
|
renderer.init(&context);
|
|
|
|
olive::VideoParams params(4, 4, olive::core::PixelFormat::u8, 4,
|
|
olive::core::Rational(1, 1),
|
|
olive::VideoParams::k_interlace_none, 1);
|
|
|
|
unsigned char buffer[4 * 4 * 4] = {};
|
|
renderer.download_from_texture(QVariant::fromValue<GLuint>(0), params, buffer,
|
|
4 * 4);
|
|
|
|
EXPECT_EQ(QOpenGLContext::currentContext(), nullptr);
|
|
}
|