- capi: oakengine_node_output_connection_at/_at_ex returned the source node as the connection destination; the actual destination is conn.second.node(). Out-edge enumeration was useless, so the node view could only draw in-edges and randomly lost whichever edges needed the out-edge path (random per context build order). Regression test in oakengine_node_test - project teardown: Project::clear() pre-notifies node removal while nodes are fully constructed (observers used to crash on half-destroyed nodes); childEvent suppresses the removal dance while clearing; Node::disconnect_all/disconnect_edge get a silent mode for teardown so no invalidation/events touch dying members (is_being_cleared); ClipBlock marker disconnect guarded against dead viewer/markers; ProjectCopier and PreviewAutoCacher drop project references on Project::destroyed instead of disconnecting dead objects at shutdown - preview: add oakengine_preview_request_get_audio_sample_count; the viewer queried sample count by passing nullptr to get_audio_samples which rejects it, so all playback audio was silently dropped - app: fix unterminated input-id memcpy in ResolveGroupInput (nodeparamviewitem, widgetbridge) that corrupted every parameter id - app: unsubscribe raw C-API event subscriptions in destructors of NodeParamViewKeyframeControl, NodeParamViewConnectedLabel and ExportDialog; playhead events used to fire into dead widgets (crash when dragging the playhead) - tests: preview request roundtrip (video frame + audio range) and free-while-active teardown coverage; env-gated OAK_DEBUG_EDGES / OAK_DEBUG_INVALID_INPUT diagnostics - docs: investigation notes in docs/zh/
237 lines
6.2 KiB
C++
237 lines
6.2 KiB
C++
/***
|
|
|
|
Olive - Non-Linear Video Editor
|
|
Copyright (C) 2022 Olive Team
|
|
Modifications Copyright (C) 2025 mikesolar
|
|
|
|
This program is free software: you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation, either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
***/
|
|
|
|
#include "nodeparamviewconnectedlabel.h"
|
|
|
|
#include <QHBoxLayout>
|
|
|
|
#include "oakutil/qtutils.h"
|
|
#include "core.h"
|
|
#include "oakengine/node.h"
|
|
#include "widget/collapsebutton/collapsebutton.h"
|
|
#include "widget/menu/menu.h"
|
|
|
|
#include "oakengine/viewer.h"
|
|
#include "oakengine/events.h"
|
|
|
|
namespace olive
|
|
{
|
|
|
|
NodeParamViewConnectedLabel::NodeParamViewConnectedLabel(const oak::Input &input,
|
|
QWidget *parent)
|
|
: QWidget(parent)
|
|
, input_(input)
|
|
, connected_node_()
|
|
, viewer_(nullptr)
|
|
, bridge_(new EngineEventBridge(this))
|
|
{
|
|
QVBoxLayout *layout = new QVBoxLayout(this);
|
|
layout->setContentsMargins(0, 0, 0, 0);
|
|
|
|
QSizePolicy p = sizePolicy();
|
|
p.setHorizontalStretch(1);
|
|
p.setHorizontalPolicy(QSizePolicy::Expanding);
|
|
setSizePolicy(p);
|
|
|
|
// Set up label area
|
|
QHBoxLayout *label_layout = new QHBoxLayout();
|
|
label_layout->setSpacing(
|
|
QtUtils::q_font_metrics_width(fontMetrics(), QStringLiteral(" ")));
|
|
label_layout->setContentsMargins(0, 0, 0, 0);
|
|
layout->addLayout(label_layout);
|
|
|
|
CollapseButton *collapse_btn = new CollapseButton(this);
|
|
collapse_btn->setChecked(false);
|
|
label_layout->addWidget(collapse_btn);
|
|
|
|
label_layout->addWidget(new QLabel(tr("Connected to"), this));
|
|
|
|
connected_to_lbl_ = new ClickableLabel(this);
|
|
connected_to_lbl_->setCursor(Qt::PointingHandCursor);
|
|
connected_to_lbl_->setContextMenuPolicy(Qt::CustomContextMenu);
|
|
connect(connected_to_lbl_, &ClickableLabel::mouse_clicked, this,
|
|
&NodeParamViewConnectedLabel::connection_clicked);
|
|
connect(connected_to_lbl_, &ClickableLabel::customContextMenuRequested,
|
|
this, &NodeParamViewConnectedLabel::show_label_context_menu);
|
|
label_layout->addWidget(connected_to_lbl_);
|
|
|
|
label_layout->addStretch();
|
|
|
|
// Set up "link" font
|
|
QFont link_font = connected_to_lbl_->font();
|
|
link_font.setUnderline(true);
|
|
connected_to_lbl_->setForegroundRole(QPalette::Link);
|
|
connected_to_lbl_->setFont(link_font);
|
|
|
|
if (input_.is_connected()) {
|
|
input_connected(input_.connected_node(), input_);
|
|
} else {
|
|
input_disconnected(oak::Node(), input_);
|
|
}
|
|
|
|
bridge_->subscribe(reinterpret_cast<void *>(input_.node_handle()),
|
|
OAKENGINE_EVENT_NODE_INPUT_CONNECTED);
|
|
bridge_->subscribe(reinterpret_cast<void *>(input_.node_handle()),
|
|
OAKENGINE_EVENT_NODE_INPUT_DISCONNECTED);
|
|
connect(bridge_, &EngineEventBridge::node_input_connected, this,
|
|
[this](OakEngineNode *source, OakEngineNode *output,
|
|
const QString &input, int element) {
|
|
input_connected(output,
|
|
oak::Input(source, input, element));
|
|
});
|
|
connect(bridge_, &EngineEventBridge::node_input_disconnected, this,
|
|
[this](OakEngineNode *source, OakEngineNode *output,
|
|
const QString &input, int element) {
|
|
input_disconnected(output,
|
|
oak::Input(source, input, element));
|
|
});
|
|
|
|
// Creating the tree is expensive, hold off until the user specifically requests it
|
|
value_tree_ = nullptr;
|
|
connect(collapse_btn, &CollapseButton::toggled, this,
|
|
&NodeParamViewConnectedLabel::set_value_tree_visible);
|
|
}
|
|
|
|
NodeParamViewConnectedLabel::~NodeParamViewConnectedLabel()
|
|
{
|
|
// Raw C-API subscription carries `this` as userdata; not covered by
|
|
// Qt's auto-disconnect. Unsubscribe or the next playhead event calls
|
|
// into a dead object.
|
|
set_viewer_node(nullptr);
|
|
}
|
|
|
|
void NodeParamViewConnectedLabel::set_viewer_node(OakEngineNode *viewer)
|
|
{
|
|
if (viewer_) {
|
|
oakengine_event_unsubscribe(viewer_sub_);
|
|
viewer_sub_ = 0;
|
|
}
|
|
|
|
viewer_ = viewer;
|
|
|
|
if (viewer_) {
|
|
viewer_sub_ = oakengine_event_subscribe(
|
|
viewer_,
|
|
OAKENGINE_EVENT_VIEWER_PLAYHEAD_CHANGED,
|
|
[](const oakengine_event *, void *userdata) {
|
|
static_cast<NodeParamViewConnectedLabel *>(userdata)
|
|
->update_value_tree();
|
|
},
|
|
this);
|
|
update_value_tree();
|
|
}
|
|
}
|
|
|
|
void NodeParamViewConnectedLabel::create_tree()
|
|
{
|
|
// Set up table area
|
|
value_tree_ = new NodeValueTree(this);
|
|
layout()->addWidget(value_tree_);
|
|
}
|
|
|
|
void NodeParamViewConnectedLabel::input_connected(oak::Node output,
|
|
const oak::Input &input)
|
|
{
|
|
if (input_ != input) {
|
|
return;
|
|
}
|
|
|
|
connected_node_ = output;
|
|
|
|
update_label();
|
|
}
|
|
|
|
void NodeParamViewConnectedLabel::input_disconnected(oak::Node output,
|
|
const oak::Input &input)
|
|
{
|
|
if (input_ != input) {
|
|
return;
|
|
}
|
|
|
|
Q_UNUSED(output)
|
|
|
|
connected_node_ = oak::Node();
|
|
|
|
update_label();
|
|
}
|
|
|
|
void NodeParamViewConnectedLabel::show_label_context_menu()
|
|
{
|
|
Menu m(this);
|
|
|
|
QAction *disconnect_action = m.addAction(tr("Disconnect"));
|
|
connect(disconnect_action, &QAction::triggered, this, [this]() {
|
|
// Through the liboakengine C ABI facade (one undoable command,
|
|
// array element included, same as the old NodeEdgeRemoveCommand).
|
|
input_.disconnect();
|
|
});
|
|
|
|
m.exec(QCursor::pos());
|
|
}
|
|
|
|
void NodeParamViewConnectedLabel::connection_clicked()
|
|
{
|
|
if (!connected_node_.is_null()) {
|
|
emit request_select_node(connected_node_.handle());
|
|
}
|
|
}
|
|
|
|
void NodeParamViewConnectedLabel::update_label()
|
|
{
|
|
QString s;
|
|
|
|
if (!connected_node_.is_null()) {
|
|
s = connected_node_.name();
|
|
} else {
|
|
s = tr("Nothing");
|
|
}
|
|
|
|
connected_to_lbl_->setText(s);
|
|
}
|
|
|
|
void NodeParamViewConnectedLabel::update_value_tree()
|
|
{
|
|
if (value_tree_ && viewer_ && value_tree_->isVisible()) {
|
|
int64_t pn, pd;
|
|
oakengine_viewer_get_playhead(
|
|
reinterpret_cast<OakEngineNode *>(viewer_), &pn, &pd);
|
|
value_tree_->set_node(input_, Rational(pn, pd));
|
|
}
|
|
}
|
|
|
|
void NodeParamViewConnectedLabel::set_value_tree_visible(bool e)
|
|
{
|
|
if (value_tree_) {
|
|
value_tree_->setVisible(e);
|
|
}
|
|
|
|
if (e) {
|
|
if (!value_tree_) {
|
|
create_tree();
|
|
value_tree_->setVisible(true);
|
|
}
|
|
|
|
update_value_tree();
|
|
}
|
|
}
|
|
|
|
}
|