Automated with clang-tidy readability-identifier-naming (config added to .clang-tidy) plus scripted passes, per the updated rules now documented in CONTRIBUTING.md: - types (class/struct/enum/alias/template params): PascalCase - functions, variables, members: snake_case (incl. rational -> Rational) - private/protected members: trailing underscore; static member variables likewise (instance_, available_themes_) - constants and enum values: snake_case (kLinear -> k_linear, F32P -> f32p); ALL_CAPS reserved for macros - macros: OAK_ prefix (OLIVE_ADD_TEST/OLIVE_ASSERT/OLIVE_CONFIG -> OAK_ADD_TEST/OAK_ASSERT/OAK_CONFIG, GL_PREAMBLE -> OAK_GL_PREAMBLE, include guards -> OAK_*) - file names: all lowercase (Current/Plugin/OliveHost/OliveClip/ OlivePluginInstance -> current/plugin/olivehost/oliveclip/ oliveplugininstance) - getters share the member name sans underscore, setters set_foo() - Qt and third-party (OpenFX) virtual overrides and framework callbacks keep their original names (exempt in .clang-tidy) Manual follow-ups required where automation could not reach: - string-based QMetaObject/SIGNAL/SLOT references updated to renamed methods (AddTask, CreatedFile, DeleteSpecificFile, moveSelectionUp, ...) - macro bodies referencing renamed methods (OLIVE_CONFIG, NODE_DEFAULT_DESTRUCTOR, MANAGEDDISPLAYWIDGET_*) - self-shadowing locals renamed where signals/methods became same-named (size_changed, worker_count, selected_items, import param, filters) - third_party OFX member/namespace usages restored (OFX::Host::*, _created, _clipPrefsDirty, createInstance, clearPersistentMessage) - STL protocol aliases restored (const_iterator) with .clang-tidy ignore rules; qHash overloads restored Full build and test suite pass: ctest 4/4, ~1960 gtest cases green.
49 lines
1.6 KiB
C++
49 lines
1.6 KiB
C++
#include <gtest/gtest.h>
|
|
|
|
#include "node/globals.h"
|
|
#include "render/videoparams.h"
|
|
#include "render/loopmode.h"
|
|
|
|
TEST(NodeGlobals, DefaultConstruction)
|
|
{
|
|
olive::NodeGlobals globals;
|
|
EXPECT_EQ(globals.vparams().width(), 0);
|
|
EXPECT_EQ(globals.vparams().height(), 0);
|
|
EXPECT_EQ(globals.aparams().sample_rate(), 0);
|
|
}
|
|
|
|
TEST(NodeGlobals, ConstructedWithParams)
|
|
{
|
|
olive::VideoParams video_params(1920, 1080, olive::PixelFormat::f32, 4);
|
|
olive::AudioParams audio_params;
|
|
audio_params.set_sample_rate(48000);
|
|
audio_params.set_channel_layout(olive::core::k_channel_layout_stereo);
|
|
|
|
olive::TimeRange time(olive::core::Rational(1, 24),
|
|
olive::core::Rational(2, 24));
|
|
olive::NodeGlobals globals(video_params, audio_params, time,
|
|
olive::LoopMode::k_loop_mode_loop);
|
|
|
|
EXPECT_EQ(globals.vparams().width(), 1920);
|
|
EXPECT_EQ(globals.vparams().height(), 1080);
|
|
EXPECT_EQ(globals.aparams().sample_rate(), 48000);
|
|
EXPECT_EQ(globals.loop_mode(), olive::LoopMode::k_loop_mode_loop);
|
|
EXPECT_EQ(globals.time().in(), olive::core::Rational(1, 24));
|
|
EXPECT_EQ(globals.time().out(), olive::core::Rational(2, 24));
|
|
}
|
|
|
|
TEST(NodeGlobals, RationalConstructorExpandsToFrame)
|
|
{
|
|
olive::VideoParams video_params(1280, 720, olive::PixelFormat::f32, 4);
|
|
video_params.set_frame_rate(24);
|
|
olive::AudioParams audio_params;
|
|
audio_params.set_sample_rate(44100);
|
|
|
|
olive::NodeGlobals globals(video_params, audio_params,
|
|
olive::core::Rational(0, 1),
|
|
olive::LoopMode::k_loop_mode_clamp);
|
|
|
|
EXPECT_EQ(globals.time().in(), olive::core::Rational(0, 1));
|
|
EXPECT_EQ(globals.time().out(), olive::core::Rational(1, 24));
|
|
}
|