Automated with clang-tidy readability-identifier-naming (config added to .clang-tidy) plus scripted passes, per the updated rules now documented in CONTRIBUTING.md: - types (class/struct/enum/alias/template params): PascalCase - functions, variables, members: snake_case (incl. rational -> Rational) - private/protected members: trailing underscore; static member variables likewise (instance_, available_themes_) - constants and enum values: snake_case (kLinear -> k_linear, F32P -> f32p); ALL_CAPS reserved for macros - macros: OAK_ prefix (OLIVE_ADD_TEST/OLIVE_ASSERT/OLIVE_CONFIG -> OAK_ADD_TEST/OAK_ASSERT/OAK_CONFIG, GL_PREAMBLE -> OAK_GL_PREAMBLE, include guards -> OAK_*) - file names: all lowercase (Current/Plugin/OliveHost/OliveClip/ OlivePluginInstance -> current/plugin/olivehost/oliveclip/ oliveplugininstance) - getters share the member name sans underscore, setters set_foo() - Qt and third-party (OpenFX) virtual overrides and framework callbacks keep their original names (exempt in .clang-tidy) Manual follow-ups required where automation could not reach: - string-based QMetaObject/SIGNAL/SLOT references updated to renamed methods (AddTask, CreatedFile, DeleteSpecificFile, moveSelectionUp, ...) - macro bodies referencing renamed methods (OLIVE_CONFIG, NODE_DEFAULT_DESTRUCTOR, MANAGEDDISPLAYWIDGET_*) - self-shadowing locals renamed where signals/methods became same-named (size_changed, worker_count, selected_items, import param, filters) - third_party OFX member/namespace usages restored (OFX::Host::*, _created, _clipPrefsDirty, createInstance, clearPersistentMessage) - STL protocol aliases restored (const_iterator) with .clang-tidy ignore rules; qHash overloads restored Full build and test suite pass: ctest 4/4, ~1960 gtest cases green.
69 lines
2.0 KiB
C++
69 lines
2.0 KiB
C++
/***
|
|
|
|
Olive - Non-Linear Video Editor
|
|
Copyright (C) 2022 Olive Team
|
|
Modifications Copyright (C) 2025 mikesolar
|
|
|
|
This program is free software: you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation, either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
***/
|
|
|
|
#ifndef OAK_OLIVECOMMONDEFINE_H
|
|
#define OAK_OLIVECOMMONDEFINE_H
|
|
|
|
namespace olive
|
|
{
|
|
|
|
/// The minimum size an icon in ProjectExplorer can be
|
|
const int k_project_icon_size_minimum = 16;
|
|
|
|
/// The maximum size an icon in ProjectExplorer can be
|
|
const int k_project_icon_size_maximum = 256;
|
|
|
|
/// The default size an icon in ProjectExplorer can be
|
|
const int k_project_icon_size_default = 64;
|
|
|
|
const int k_bytes_in_gigabyte = 1073741824;
|
|
|
|
}
|
|
|
|
#define MACRO_NAME_AS_STR(s) #s
|
|
#define MACRO_VAL_AS_STR(s) MACRO_NAME_AS_STR(s)
|
|
|
|
#define OLIVE_NS_CONST_ARG(x, y) \
|
|
QArgument<const olive::x>("const " MACRO_VAL_AS_STR(olive) "::" #x, y)
|
|
#define OLIVE_NS_ARG(x, y) \
|
|
QArgument<olive::x>(MACRO_VAL_AS_STR(olive) "::" #x, y)
|
|
#define OLIVE_NS_RETURN_ARG(x, y) \
|
|
QReturnArgument<olive::x>(MACRO_VAL_AS_STR(olive) "::" #x, y)
|
|
|
|
/**
|
|
* Copy/move deleters. Similar to Q_DISABLE_COPY_MOVE, et al. but those functions are not present in Qt < 5.13 so we
|
|
* use our own functions for portability.
|
|
*/
|
|
|
|
#define DISABLE_COPY(Class) \
|
|
Class(const Class &) = delete; \
|
|
Class &operator=(const Class &) = delete;
|
|
|
|
#define DISABLE_MOVE(Class) \
|
|
Class(Class &&) = delete; \
|
|
Class &operator=(Class &&) = delete;
|
|
|
|
#define DISABLE_COPY_MOVE(Class) \
|
|
DISABLE_COPY(Class) \
|
|
DISABLE_MOVE(Class)
|
|
|
|
#endif // OAK_OLIVECOMMONDEFINE_H
|