Mike-Solar
bb40b4923e
Automated with clang-tidy readability-identifier-naming (config added to .clang-tidy) plus scripted passes, per the updated rules now documented in CONTRIBUTING.md: - types (class/struct/enum/alias/template params): PascalCase - functions, variables, members: snake_case (incl. rational -> Rational) - private/protected members: trailing underscore; static member variables likewise (instance_, available_themes_) - constants and enum values: snake_case (kLinear -> k_linear, F32P -> f32p); ALL_CAPS reserved for macros - macros: OAK_ prefix (OLIVE_ADD_TEST/OLIVE_ASSERT/OLIVE_CONFIG -> OAK_ADD_TEST/OAK_ASSERT/OAK_CONFIG, GL_PREAMBLE -> OAK_GL_PREAMBLE, include guards -> OAK_*) - file names: all lowercase (Current/Plugin/OliveHost/OliveClip/ OlivePluginInstance -> current/plugin/olivehost/oliveclip/ oliveplugininstance) - getters share the member name sans underscore, setters set_foo() - Qt and third-party (OpenFX) virtual overrides and framework callbacks keep their original names (exempt in .clang-tidy) Manual follow-ups required where automation could not reach: - string-based QMetaObject/SIGNAL/SLOT references updated to renamed methods (AddTask, CreatedFile, DeleteSpecificFile, moveSelectionUp, ...) - macro bodies referencing renamed methods (OLIVE_CONFIG, NODE_DEFAULT_DESTRUCTOR, MANAGEDDISPLAYWIDGET_*) - self-shadowing locals renamed where signals/methods became same-named (size_changed, worker_count, selected_items, import param, filters) - third_party OFX member/namespace usages restored (OFX::Host::*, _created, _clipPrefsDirty, createInstance, clearPersistentMessage) - STL protocol aliases restored (const_iterator) with .clang-tidy ignore rules; qHash overloads restored Full build and test suite pass: ctest 4/4, ~1960 gtest cases green.
74 lines
1.4 KiB
C++
74 lines
1.4 KiB
C++
#include <gtest/gtest.h>
|
|
|
|
#include "common/jobtime.h"
|
|
|
|
namespace
|
|
{
|
|
|
|
// Collects qDebug output for inspection
|
|
QStringList g_captured_messages;
|
|
|
|
void capture_message_handler(QtMsgType, const QMessageLogContext &,
|
|
const QString &msg)
|
|
{
|
|
g_captured_messages.append(msg);
|
|
}
|
|
|
|
} // namespace
|
|
|
|
TEST(CommonJobTime, ConstructorAcquiresValue)
|
|
{
|
|
olive::JobTime a;
|
|
olive::JobTime b;
|
|
|
|
EXPECT_NE(a.value(), b.value());
|
|
EXPECT_LT(a.value(), b.value());
|
|
}
|
|
|
|
TEST(CommonJobTime, AcquireUpdatesValue)
|
|
{
|
|
olive::JobTime a;
|
|
uint64_t first = a.value();
|
|
a.acquire();
|
|
uint64_t second = a.value();
|
|
|
|
EXPECT_GT(second, first);
|
|
}
|
|
|
|
TEST(CommonJobTime, ComparisonOperators)
|
|
{
|
|
olive::JobTime a;
|
|
olive::JobTime b;
|
|
|
|
// `a` was acquired first, so its value is strictly lower than `b`'s
|
|
EXPECT_LT(a, b);
|
|
EXPECT_GT(b, a);
|
|
EXPECT_LE(a, b);
|
|
EXPECT_GE(b, a);
|
|
EXPECT_NE(a, b);
|
|
|
|
// A copy holds the same value and must compare equal
|
|
olive::JobTime c = a;
|
|
EXPECT_EQ(a, c);
|
|
EXPECT_LE(a, c);
|
|
EXPECT_GE(a, c);
|
|
}
|
|
|
|
TEST(CommonJobTime, DebugStream)
|
|
{
|
|
olive::JobTime a;
|
|
|
|
g_captured_messages.clear();
|
|
QtMessageHandler old = qInstallMessageHandler(capture_message_handler);
|
|
{
|
|
QDebug debug(QtDebugMsg);
|
|
debug << a;
|
|
}
|
|
qInstallMessageHandler(old);
|
|
|
|
// operator<< streams the raw value, so the message must contain it
|
|
ASSERT_EQ(g_captured_messages.size(), 1);
|
|
EXPECT_TRUE(
|
|
g_captured_messages.first().contains(QString::number(a.value())));
|
|
}
|