Mike-Solar
9003b78176
- serializer resolves node types through the factory's dynamic (runtime-registered OpenFX) entries, so a project carrying plugin nodes loads again (was: "unknown node type"); covered by a new CI-gated round-trip test driving the real fixture plugin - built-in effect nodes expose their inputs as inspector parameters like the C++ parameter editor: localized input names from the behavior, combo option tables via the new NodeBehavior::input_combo_strings (16 nodes, string-for-string from the C++ set_combo_box_strings), connection/data inputs excluded - effect library: live drag-and-drop — onto the inspector's effect stack (lands at the indicator position) and onto the node editor canvas (creates the node at the drop point); double-click still appends to the selected clip - inspector parameter controls are no longer recreated per render (gpui stack view caches them per effect), so sliders drag and checkboxes click; the view observes the engine and silently re-syncs values (undo/redo land on the widgets) - timeline: left-press selects clips (plain/keep-multi/Ctrl-Cmd toggle); clip moves clamp the shared delta so no clip of a linked group lands before frame 0 instead of failing with "invalid move target" - oakplugin: createInstance-rejected instances skip the destroyInstance notification (the plugin never owned them); vendor-suite fetchSuite misses moved behind OAK_OFX_TRACE; the worker logs the discovered/ registered plugin counts - CI: the OFX probe step also runs the serialization round-trip test - gpui submodule: params view caching, clip click-select, library drag payload, graph_position_at
203 lines
7.6 KiB
YAML
203 lines
7.6 KiB
YAML
name: CI
|
|
|
|
on:
|
|
push:
|
|
branches:
|
|
- main
|
|
pull_request:
|
|
branches:
|
|
- main
|
|
|
|
concurrency:
|
|
group: ci-${{ github.workflow }}-${{ github.ref }}
|
|
cancel-in-progress: true
|
|
|
|
permissions:
|
|
contents: read
|
|
|
|
jobs:
|
|
build-test:
|
|
name: Build & test (${{ matrix.os }})
|
|
runs-on: ${{ matrix.os }}
|
|
strategy:
|
|
fail-fast: false
|
|
matrix:
|
|
os:
|
|
- warp-ubuntu-latest-x64-8x
|
|
- warp-macos-15-arm64-6x
|
|
- warp-windows-latest-x64-16x
|
|
|
|
steps:
|
|
- name: Checkout
|
|
uses: actions/checkout@v4
|
|
with:
|
|
# gpui/ is a git submodule; its crates are workspace members of
|
|
# their own repo and build as path dependencies of oakapp.
|
|
submodules: true
|
|
|
|
- name: Install Rust (stable)
|
|
uses: dtolnay/rust-toolchain@stable
|
|
|
|
# ------------------------------------------------------------------
|
|
# System dependencies
|
|
# ------------------------------------------------------------------
|
|
- name: Install system dependencies (Linux)
|
|
if: runner.os == 'Linux'
|
|
run: |
|
|
# Codec/filter libraries for the ffmpeg-sys-next build feature
|
|
# (see tooling/install-deps.sh).
|
|
tooling/install-deps.sh
|
|
# Real OpenColorIO (ocio-sys real bridge) plus the headless test
|
|
# infra gpui needs: X11, software Mesa Vulkan (lavapipe) and xvfb.
|
|
sudo apt-get install -y \
|
|
libopencolorio-dev \
|
|
libgl1-mesa-dev libgl1-mesa-dri mesa-vulkan-drivers \
|
|
libvulkan-dev libxkbcommon-dev xvfb
|
|
|
|
- name: Install system dependencies (macOS)
|
|
if: runner.os == 'macOS'
|
|
run: |
|
|
tooling/install-deps.sh
|
|
brew install opencolorio
|
|
|
|
- name: Setup MSYS2 (Windows)
|
|
if: runner.os == 'Windows'
|
|
uses: msys2/setup-msys2@v2
|
|
with:
|
|
msystem: UCRT64
|
|
update: true
|
|
install: >-
|
|
git
|
|
mingw-w64-ucrt-x86_64-gcc
|
|
|
|
- name: Install system dependencies (Windows)
|
|
if: runner.os == 'Windows'
|
|
shell: msys2 {0}
|
|
run: |
|
|
bash tooling/install-deps.sh
|
|
pacman -S --needed --noconfirm mingw-w64-ucrt-x86_64-opencolorio
|
|
|
|
# ------------------------------------------------------------------
|
|
# Build environment
|
|
# ------------------------------------------------------------------
|
|
# ocio-sys builds a stub bridge unless these are set; the oakcommon
|
|
# ocioutils tests need the real library (see crates/oakcommon/.cargo/
|
|
# config.toml, which only applies to builds run from that directory).
|
|
- name: Configure build environment (Linux)
|
|
if: runner.os == 'Linux'
|
|
run: |
|
|
echo "OCIO_RS_ENABLE_REAL=1" >> "$GITHUB_ENV"
|
|
echo "OCIO_INSTALL_DIR=/usr" >> "$GITHUB_ENV"
|
|
echo "OCIO_RS_LINK=dynamic" >> "$GITHUB_ENV"
|
|
|
|
- name: Configure build environment (macOS)
|
|
if: runner.os == 'macOS'
|
|
run: |
|
|
echo "OCIO_RS_ENABLE_REAL=1" >> "$GITHUB_ENV"
|
|
echo "OCIO_INSTALL_DIR=/opt/homebrew/opt/opencolorio" >> "$GITHUB_ENV"
|
|
echo "OCIO_RS_LINK=dynamic" >> "$GITHUB_ENV"
|
|
# Homebrew quirks: lame.pc / snappy / libopenjp2.pc live off the
|
|
# default pkg-config search paths (see docs/build.md).
|
|
echo "CFLAGS=-I/opt/homebrew/include" >> "$GITHUB_ENV"
|
|
echo "LDFLAGS=-L/opt/homebrew/lib" >> "$GITHUB_ENV"
|
|
echo "PKG_CONFIG_PATH=/opt/homebrew/lib/pkgconfig/openjpeg" >> "$GITHUB_ENV"
|
|
|
|
- name: Configure build environment (Windows)
|
|
if: runner.os == 'Windows'
|
|
shell: msys2 {0}
|
|
run: |
|
|
echo "OCIO_RS_ENABLE_REAL=1" >> "$GITHUB_ENV"
|
|
echo "OCIO_INSTALL_DIR=/ucrt64" >> "$GITHUB_ENV"
|
|
echo "OCIO_RS_LINK=dynamic" >> "$GITHUB_ENV"
|
|
|
|
# ------------------------------------------------------------------
|
|
# Caches
|
|
# ------------------------------------------------------------------
|
|
# Covers the whole target/ dir plus ~/.cargo; shared across branches
|
|
# of the same OS.
|
|
- name: Cache cargo artifacts
|
|
uses: Swatinem/rust-cache@v2
|
|
with:
|
|
shared-key: oak-workspace
|
|
|
|
# The project FFmpeg (release/8.0, static, all free codecs + hwaccel)
|
|
# is built by tooling/ffmpeg/build-ffmpeg.sh — 10-20 min on a cold
|
|
# cache. It does not depend on the Rust toolchain, so key it on the
|
|
# script itself and keep it out of rust-cache.
|
|
- name: Cache project FFmpeg
|
|
uses: actions/cache@v4
|
|
with:
|
|
path: .cache/ffmpeg
|
|
key: ffmpeg-${{ runner.os }}-${{ hashFiles('tooling/ffmpeg/build-ffmpeg.sh') }}
|
|
|
|
# ------------------------------------------------------------------
|
|
# Project FFmpeg (script + FFMPEG_DIR; see docs/build.md)
|
|
# ------------------------------------------------------------------
|
|
- name: Build project FFmpeg (Linux/macOS)
|
|
if: runner.os != 'Windows'
|
|
run: |
|
|
tooling/ffmpeg/build-ffmpeg.sh
|
|
echo "FFMPEG_DIR=$PWD/.cache/ffmpeg" >> "$GITHUB_ENV"
|
|
|
|
- name: Build project FFmpeg (Windows)
|
|
if: runner.os == 'Windows'
|
|
shell: msys2 {0}
|
|
run: |
|
|
bash tooling/ffmpeg/build-ffmpeg.sh
|
|
echo "FFMPEG_DIR=$(cygpath -m "$PWD/.cache/ffmpeg")" >> "$GITHUB_ENV"
|
|
|
|
# ------------------------------------------------------------------
|
|
# Build & test
|
|
# ------------------------------------------------------------------
|
|
- name: Build (Linux)
|
|
if: runner.os == 'Linux'
|
|
run: cargo build --workspace --locked
|
|
|
|
- name: Build (macOS)
|
|
if: runner.os == 'macOS'
|
|
run: cargo build --workspace --locked
|
|
|
|
- name: Build (Windows)
|
|
if: runner.os == 'Windows'
|
|
shell: msys2 {0}
|
|
run: cargo build --workspace --locked
|
|
|
|
# xvfb + 24-bit screen: the gpui #[gpui::test] tests open real windows
|
|
# and render through wgpu on Mesa's software Vulkan (lavapipe).
|
|
- name: Test (Linux)
|
|
if: runner.os == 'Linux'
|
|
run: xvfb-run -a -s "-screen 0 1920x1080x24" cargo test --workspace --locked
|
|
|
|
- name: Test (macOS)
|
|
if: runner.os == 'macOS'
|
|
run: cargo test --workspace --locked
|
|
|
|
- name: Test (Windows)
|
|
if: runner.os == 'Windows'
|
|
shell: msys2 {0}
|
|
run: cargo test --workspace --locked
|
|
|
|
# ------------------------------------------------------------------
|
|
# OFX plugin discovery end-to-end
|
|
# ------------------------------------------------------------------
|
|
# Build a minimal but real OFX plugin into a .ofx.bundle, point
|
|
# OFX_PLUGIN_PATH at it and let the scan_probe example run the full
|
|
# host path (directory scan -> dlopen -> setHost -> load -> describe
|
|
# -> register). The assertion is the plugin's registration line; CI
|
|
# machines have no system-wide OFX plugins, so the fixture is the
|
|
# only discovery.
|
|
- name: Build OFX fixture plugin (Linux/macOS)
|
|
if: runner.os != 'Windows'
|
|
run: crates/oakplugin/tests/fixtures/build_fixture.sh .cache/ofx-fixture
|
|
|
|
- name: Probe OFX plugin discovery (Linux/macOS)
|
|
if: runner.os != 'Windows'
|
|
run: |
|
|
OFX_PLUGIN_PATH="$PWD/.cache/ofx-fixture" \
|
|
cargo run --locked -p oakplugin --example scan_probe > probe.log 2>&1
|
|
grep -q 'type_id=rs.oak.CiTestPlugin' probe.log
|
|
# A project carrying a plugin node must survive save/load (the
|
|
# serializer resolves plugin types via the dynamic factory).
|
|
OAK_OFX_FIXTURE_DIR="$PWD/.cache/ofx-fixture" \
|
|
cargo test --locked -p oakplugin --test ofx_roundtrip
|