Mike-Solar
bb40b4923e
Automated with clang-tidy readability-identifier-naming (config added to .clang-tidy) plus scripted passes, per the updated rules now documented in CONTRIBUTING.md: - types (class/struct/enum/alias/template params): PascalCase - functions, variables, members: snake_case (incl. rational -> Rational) - private/protected members: trailing underscore; static member variables likewise (instance_, available_themes_) - constants and enum values: snake_case (kLinear -> k_linear, F32P -> f32p); ALL_CAPS reserved for macros - macros: OAK_ prefix (OLIVE_ADD_TEST/OLIVE_ASSERT/OLIVE_CONFIG -> OAK_ADD_TEST/OAK_ASSERT/OAK_CONFIG, GL_PREAMBLE -> OAK_GL_PREAMBLE, include guards -> OAK_*) - file names: all lowercase (Current/Plugin/OliveHost/OliveClip/ OlivePluginInstance -> current/plugin/olivehost/oliveclip/ oliveplugininstance) - getters share the member name sans underscore, setters set_foo() - Qt and third-party (OpenFX) virtual overrides and framework callbacks keep their original names (exempt in .clang-tidy) Manual follow-ups required where automation could not reach: - string-based QMetaObject/SIGNAL/SLOT references updated to renamed methods (AddTask, CreatedFile, DeleteSpecificFile, moveSelectionUp, ...) - macro bodies referencing renamed methods (OLIVE_CONFIG, NODE_DEFAULT_DESTRUCTOR, MANAGEDDISPLAYWIDGET_*) - self-shadowing locals renamed where signals/methods became same-named (size_changed, worker_count, selected_items, import param, filters) - third_party OFX member/namespace usages restored (OFX::Host::*, _created, _clipPrefsDirty, createInstance, clearPersistentMessage) - STL protocol aliases restored (const_iterator) with .clang-tidy ignore rules; qHash overloads restored Full build and test suite pass: ctest 4/4, ~1960 gtest cases green.
110 lines
2.3 KiB
C++
110 lines
2.3 KiB
C++
/***
|
|
|
|
Olive - Non-Linear Video Editor
|
|
Copyright (C) 2023 Olive Studios LLC
|
|
Modifications Copyright (C) 2025 mikesolar
|
|
|
|
This program is free software: you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation, either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
***/
|
|
|
|
#include <cstring>
|
|
|
|
#include "util/rational.h"
|
|
#include "util/tests.h"
|
|
|
|
using namespace olive::core;
|
|
|
|
bool rational_to_from_string_test()
|
|
{
|
|
Rational r(1, 30);
|
|
|
|
std::string s = r.toString();
|
|
|
|
Rational r2 = Rational::fromString(s);
|
|
|
|
return r == r2;
|
|
}
|
|
|
|
bool rational_to_from_string_test2()
|
|
{
|
|
Rational r(69, 420);
|
|
|
|
std::string s = r.toString();
|
|
|
|
Rational r2 = Rational::fromString(s);
|
|
|
|
return r == r2;
|
|
}
|
|
|
|
bool rational_defaults()
|
|
{
|
|
// By default, rationals are valid 0/1
|
|
Rational basic_constructor;
|
|
|
|
if (!basic_constructor.isNull()) {
|
|
return false;
|
|
}
|
|
|
|
if (basic_constructor.isNaN()) {
|
|
return false;
|
|
}
|
|
|
|
return true;
|
|
}
|
|
|
|
bool rational_nan()
|
|
{
|
|
// Create a NaN with a 0 denominator
|
|
Rational nan = Rational(0, 0);
|
|
if (!nan.isNaN())
|
|
return false;
|
|
if (!nan.isNull())
|
|
return false;
|
|
|
|
// Create a non-NaN with a zero numerator
|
|
Rational zero_nonnan(0, 999);
|
|
if (!zero_nonnan.isNull())
|
|
return false;
|
|
if (zero_nonnan.isNaN())
|
|
return false;
|
|
|
|
// Create a non-NaN with a non-zero numerator
|
|
Rational nonzer_nonnan(1, 30);
|
|
if (nonzer_nonnan.isNull())
|
|
return false;
|
|
if (nonzer_nonnan.isNaN())
|
|
return false;
|
|
|
|
return true;
|
|
}
|
|
|
|
bool rational_nan_constant()
|
|
{
|
|
return Rational::NaN.isNaN();
|
|
}
|
|
|
|
int main()
|
|
{
|
|
Tester t;
|
|
|
|
t.add("Rational::defaults", rational_defaults);
|
|
t.add("Rational::NaN", rational_nan);
|
|
t.add("Rational::NaN_constant", rational_nan_constant);
|
|
t.add("Rational::toString/fromString", rational_to_from_string_test);
|
|
t.add("Rational::toString/fromString2", rational_to_from_string_test2);
|
|
|
|
return t.exec();
|
|
}
|