Mike-Solar
bb40b4923e
Automated with clang-tidy readability-identifier-naming (config added to .clang-tidy) plus scripted passes, per the updated rules now documented in CONTRIBUTING.md: - types (class/struct/enum/alias/template params): PascalCase - functions, variables, members: snake_case (incl. rational -> Rational) - private/protected members: trailing underscore; static member variables likewise (instance_, available_themes_) - constants and enum values: snake_case (kLinear -> k_linear, F32P -> f32p); ALL_CAPS reserved for macros - macros: OAK_ prefix (OLIVE_ADD_TEST/OLIVE_ASSERT/OLIVE_CONFIG -> OAK_ADD_TEST/OAK_ASSERT/OAK_CONFIG, GL_PREAMBLE -> OAK_GL_PREAMBLE, include guards -> OAK_*) - file names: all lowercase (Current/Plugin/OliveHost/OliveClip/ OlivePluginInstance -> current/plugin/olivehost/oliveclip/ oliveplugininstance) - getters share the member name sans underscore, setters set_foo() - Qt and third-party (OpenFX) virtual overrides and framework callbacks keep their original names (exempt in .clang-tidy) Manual follow-ups required where automation could not reach: - string-based QMetaObject/SIGNAL/SLOT references updated to renamed methods (AddTask, CreatedFile, DeleteSpecificFile, moveSelectionUp, ...) - macro bodies referencing renamed methods (OLIVE_CONFIG, NODE_DEFAULT_DESTRUCTOR, MANAGEDDISPLAYWIDGET_*) - self-shadowing locals renamed where signals/methods became same-named (size_changed, worker_count, selected_items, import param, filters) - third_party OFX member/namespace usages restored (OFX::Host::*, _created, _clipPrefsDirty, createInstance, clearPersistentMessage) - STL protocol aliases restored (const_iterator) with .clang-tidy ignore rules; qHash overloads restored Full build and test suite pass: ctest 4/4, ~1960 gtest cases green.
80 lines
1.8 KiB
C++
80 lines
1.8 KiB
C++
#include <gtest/gtest.h>
|
|
|
|
#include <QSignalSpy>
|
|
|
|
#include "node/generator/solid/solid.h"
|
|
#include "node/project.h"
|
|
#include "widget/nodeview/nodeview.h"
|
|
|
|
using namespace olive;
|
|
|
|
class NodeViewTest : public ::testing::Test {
|
|
protected:
|
|
void SetUp() override
|
|
{
|
|
ColorManager::set_up_default_config();
|
|
|
|
project_ = std::make_unique<Project>();
|
|
project_->initialize();
|
|
}
|
|
|
|
std::unique_ptr<Project> project_;
|
|
};
|
|
|
|
TEST_F(NodeViewTest, ConstructionCreatesEmptyView)
|
|
{
|
|
NodeView view;
|
|
EXPECT_TRUE(view.get_contexts().isEmpty());
|
|
EXPECT_FALSE(view.is_group_overlay());
|
|
}
|
|
|
|
TEST_F(NodeViewTest, SetContextsUpdatesContextList)
|
|
{
|
|
auto *solid = new SolidGenerator();
|
|
solid->setParent(project_.get());
|
|
|
|
NodeView view;
|
|
view.set_contexts({ solid });
|
|
|
|
EXPECT_EQ(view.get_contexts().size(), 1);
|
|
EXPECT_EQ(view.get_contexts().first(), solid);
|
|
}
|
|
|
|
TEST_F(NodeViewTest, ShowSelectedNodeInParamEditorNoSelectionIsNoOp)
|
|
{
|
|
NodeView view;
|
|
|
|
QSignalSpy changed_with_ctx_spy(
|
|
&view, &NodeView::node_selection_changed_with_contexts);
|
|
|
|
// The action must exist; silently skipping the trigger would make this
|
|
// test pass without exercising anything
|
|
QAction *show_params_action = nullptr;
|
|
foreach (QAction *action, view.actions()) {
|
|
if (action->property("id").toString() ==
|
|
QStringLiteral("shownodeparams")) {
|
|
show_params_action = action;
|
|
break;
|
|
}
|
|
}
|
|
ASSERT_NE(show_params_action, nullptr)
|
|
<< "NodeView has no action with id 'shownodeparams'";
|
|
|
|
// With nothing selected, triggering it must not emit a selection change
|
|
show_params_action->trigger();
|
|
EXPECT_EQ(changed_with_ctx_spy.count(), 0);
|
|
}
|
|
|
|
TEST_F(NodeViewTest, ClearGraphRemovesContexts)
|
|
{
|
|
auto *solid = new SolidGenerator();
|
|
solid->setParent(project_.get());
|
|
|
|
NodeView view;
|
|
view.set_contexts({ solid });
|
|
EXPECT_FALSE(view.get_contexts().isEmpty());
|
|
|
|
view.clear_graph();
|
|
EXPECT_TRUE(view.get_contexts().isEmpty());
|
|
}
|