Mike-Solar
bb40b4923e
Automated with clang-tidy readability-identifier-naming (config added to .clang-tidy) plus scripted passes, per the updated rules now documented in CONTRIBUTING.md: - types (class/struct/enum/alias/template params): PascalCase - functions, variables, members: snake_case (incl. rational -> Rational) - private/protected members: trailing underscore; static member variables likewise (instance_, available_themes_) - constants and enum values: snake_case (kLinear -> k_linear, F32P -> f32p); ALL_CAPS reserved for macros - macros: OAK_ prefix (OLIVE_ADD_TEST/OLIVE_ASSERT/OLIVE_CONFIG -> OAK_ADD_TEST/OAK_ASSERT/OAK_CONFIG, GL_PREAMBLE -> OAK_GL_PREAMBLE, include guards -> OAK_*) - file names: all lowercase (Current/Plugin/OliveHost/OliveClip/ OlivePluginInstance -> current/plugin/olivehost/oliveclip/ oliveplugininstance) - getters share the member name sans underscore, setters set_foo() - Qt and third-party (OpenFX) virtual overrides and framework callbacks keep their original names (exempt in .clang-tidy) Manual follow-ups required where automation could not reach: - string-based QMetaObject/SIGNAL/SLOT references updated to renamed methods (AddTask, CreatedFile, DeleteSpecificFile, moveSelectionUp, ...) - macro bodies referencing renamed methods (OLIVE_CONFIG, NODE_DEFAULT_DESTRUCTOR, MANAGEDDISPLAYWIDGET_*) - self-shadowing locals renamed where signals/methods became same-named (size_changed, worker_count, selected_items, import param, filters) - third_party OFX member/namespace usages restored (OFX::Host::*, _created, _clipPrefsDirty, createInstance, clearPersistentMessage) - STL protocol aliases restored (const_iterator) with .clang-tidy ignore rules; qHash overloads restored Full build and test suite pass: ctest 4/4, ~1960 gtest cases green.
79 lines
2.8 KiB
C++
79 lines
2.8 KiB
C++
#include <gtest/gtest.h>
|
|
|
|
#include <QApplication>
|
|
#include <QColor>
|
|
#include <QPalette>
|
|
#include <QStyle>
|
|
|
|
#include "ui/style/style.h"
|
|
|
|
TEST(UIStyle, InitPopulatesThemesAndAppliesStyle)
|
|
{
|
|
olive::StyleManager::init();
|
|
|
|
const QMap<QString, QString> &themes = olive::StyleManager::available_themes();
|
|
EXPECT_EQ(themes.size(), 2);
|
|
EXPECT_EQ(themes.value(QStringLiteral("olive-dark")),
|
|
QStringLiteral("Oak Dark"));
|
|
EXPECT_EQ(themes.value(QStringLiteral("olive-light")),
|
|
QStringLiteral("Oak Light"));
|
|
|
|
// Whatever the config says, the current style must be a known theme
|
|
EXPECT_TRUE(themes.contains(olive::StyleManager::get_style()));
|
|
EXPECT_FALSE(qApp->styleSheet().isEmpty());
|
|
}
|
|
|
|
TEST(UIStyle, SetStyleAppliesPaletteFromIni)
|
|
{
|
|
olive::StyleManager::set_style(QStringLiteral("olive-dark"));
|
|
EXPECT_EQ(olive::StyleManager::get_style(), QStringLiteral("olive-dark"));
|
|
|
|
// Values from app/ui/style/olive-dark/palette.ini
|
|
const QPalette p = qApp->palette();
|
|
EXPECT_EQ(p.color(QPalette::Window), QColor(QStringLiteral("#353535")));
|
|
EXPECT_EQ(p.color(QPalette::Base), QColor(QStringLiteral("#191919")));
|
|
EXPECT_EQ(p.color(QPalette::Text), QColor(QStringLiteral("#FFFFFF")));
|
|
EXPECT_EQ(p.color(QPalette::Highlight), QColor(QStringLiteral("#2A82DA")));
|
|
EXPECT_EQ(p.color(QPalette::Disabled, QPalette::Text),
|
|
QColor(QStringLiteral("#A0A0A0")));
|
|
EXPECT_EQ(p.color(QPalette::Disabled, QPalette::ButtonText),
|
|
QColor(QStringLiteral("#808080")));
|
|
|
|
EXPECT_FALSE(qApp->styleSheet().isEmpty());
|
|
}
|
|
|
|
TEST(UIStyle, SetStyleSwitchesThemes)
|
|
{
|
|
olive::StyleManager::set_style(QStringLiteral("olive-dark"));
|
|
const QColor dark_window = qApp->palette().color(QPalette::Window);
|
|
|
|
olive::StyleManager::set_style(QStringLiteral("olive-light"));
|
|
EXPECT_EQ(olive::StyleManager::get_style(), QStringLiteral("olive-light"));
|
|
|
|
// Values from app/ui/style/olive-light/palette.ini
|
|
EXPECT_EQ(qApp->palette().color(QPalette::Window),
|
|
QColor(QStringLiteral("#D0D0D0")));
|
|
EXPECT_NE(qApp->palette().color(QPalette::Window), dark_window);
|
|
|
|
// Restore the default theme for subsequent tests
|
|
olive::StyleManager::set_style(olive::StyleManager::k_default_style);
|
|
EXPECT_EQ(olive::StyleManager::get_style(),
|
|
QStringLiteral("olive-dark"));
|
|
}
|
|
|
|
TEST(UIStyle, SetStyleWithMissingThemeClearsOverrides)
|
|
{
|
|
olive::StyleManager::set_style(QStringLiteral("does-not-exist"));
|
|
EXPECT_EQ(olive::StyleManager::get_style(),
|
|
QStringLiteral("does-not-exist"));
|
|
|
|
// No palette.ini/style.css in this theme: fall back to standard palette
|
|
// and an empty stylesheet
|
|
EXPECT_TRUE(qApp->styleSheet().isEmpty());
|
|
EXPECT_EQ(qApp->palette().color(QPalette::Window),
|
|
qApp->style()->standardPalette().color(QPalette::Window));
|
|
|
|
// Restore the default theme for subsequent tests
|
|
olive::StyleManager::set_style(olive::StyleManager::k_default_style);
|
|
}
|