- SequencePreset::Save() wrote element "interlacing_" while Load() read "interlacing", losing the interlacing mode on preset round-trips; Save() now writes "interlacing" and Load() accepts both for backward compatibility with existing preset files - ExportFormatComboBox: current_ was never initialized (UB on GetFormat before first user selection) - ExportSubtitlesTab::SetSidecarEnabled() called setEnabled instead of setChecked, so restored export params could never re-enable sidecar subtitles - h264section.h: static const int constants were odr-use unsafe (link error when referenced); changed to static constexpr
128 lines
2.7 KiB
C++
128 lines
2.7 KiB
C++
/***
|
|
|
|
Olive - Non-Linear Video Editor
|
|
Copyright (C) 2022 Olive Team
|
|
Modifications Copyright (C) 2025 mikesolar
|
|
|
|
This program is free software: you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation, either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
***/
|
|
|
|
#ifndef H264SECTION_H
|
|
#define H264SECTION_H
|
|
|
|
#include <QSlider>
|
|
#include <QStackedWidget>
|
|
#include <QComboBox>
|
|
|
|
#include "codecsection.h"
|
|
#include "widget/slider/floatslider.h"
|
|
|
|
namespace olive
|
|
{
|
|
|
|
class H264CRFSection : public QWidget {
|
|
Q_OBJECT
|
|
public:
|
|
H264CRFSection(int default_crf, QWidget *parent = nullptr);
|
|
|
|
int GetValue() const;
|
|
void SetValue(int c);
|
|
|
|
static constexpr int kDefaultH264CRF = 18;
|
|
static constexpr int kDefaultH265CRF = 23;
|
|
|
|
private:
|
|
static constexpr int kMinimumCRF = 0;
|
|
static constexpr int kMaximumCRF = 51;
|
|
|
|
QSlider *crf_slider_;
|
|
};
|
|
|
|
class H264BitRateSection : public QWidget {
|
|
Q_OBJECT
|
|
public:
|
|
H264BitRateSection(QWidget *parent = nullptr);
|
|
|
|
/**
|
|
* @brief Get user-selected target bit rate (returns in BITS)
|
|
*/
|
|
int64_t GetTargetBitRate() const;
|
|
void SetTargetBitRate(int64_t b);
|
|
|
|
/**
|
|
* @brief Get user-selected maximum bit rate (returns in BITS)
|
|
*/
|
|
int64_t GetMaximumBitRate() const;
|
|
void SetMaximumBitRate(int64_t b);
|
|
|
|
private:
|
|
FloatSlider *target_rate_;
|
|
|
|
FloatSlider *max_rate_;
|
|
};
|
|
|
|
class H264FileSizeSection : public QWidget {
|
|
Q_OBJECT
|
|
public:
|
|
H264FileSizeSection(QWidget *parent = nullptr);
|
|
|
|
/**
|
|
* @brief Returns file size in BITS
|
|
*/
|
|
int64_t GetFileSize() const;
|
|
void SetFileSize(int64_t f);
|
|
|
|
private:
|
|
FloatSlider *file_size_;
|
|
};
|
|
|
|
class H264Section : public CodecSection {
|
|
Q_OBJECT
|
|
public:
|
|
enum CompressionMethod {
|
|
kConstantRateFactor,
|
|
kTargetBitRate,
|
|
kTargetFileSize
|
|
};
|
|
|
|
H264Section(QWidget *parent = nullptr);
|
|
H264Section(int default_crf, QWidget *parent);
|
|
|
|
virtual void AddOpts(EncodingParams *params) override;
|
|
|
|
virtual void SetOpts(const EncodingParams *p) override;
|
|
|
|
private:
|
|
QStackedWidget *compression_method_stack_;
|
|
|
|
H264CRFSection *crf_section_;
|
|
|
|
H264BitRateSection *bitrate_section_;
|
|
|
|
H264FileSizeSection *filesize_section_;
|
|
|
|
QComboBox *preset_combobox_;
|
|
};
|
|
|
|
class H265Section : public H264Section {
|
|
Q_OBJECT
|
|
public:
|
|
H265Section(QWidget *parent = nullptr);
|
|
};
|
|
|
|
}
|
|
|
|
#endif // H264SECTION_H
|