Mike-Solar
bb40b4923e
Automated with clang-tidy readability-identifier-naming (config added to .clang-tidy) plus scripted passes, per the updated rules now documented in CONTRIBUTING.md: - types (class/struct/enum/alias/template params): PascalCase - functions, variables, members: snake_case (incl. rational -> Rational) - private/protected members: trailing underscore; static member variables likewise (instance_, available_themes_) - constants and enum values: snake_case (kLinear -> k_linear, F32P -> f32p); ALL_CAPS reserved for macros - macros: OAK_ prefix (OLIVE_ADD_TEST/OLIVE_ASSERT/OLIVE_CONFIG -> OAK_ADD_TEST/OAK_ASSERT/OAK_CONFIG, GL_PREAMBLE -> OAK_GL_PREAMBLE, include guards -> OAK_*) - file names: all lowercase (Current/Plugin/OliveHost/OliveClip/ OlivePluginInstance -> current/plugin/olivehost/oliveclip/ oliveplugininstance) - getters share the member name sans underscore, setters set_foo() - Qt and third-party (OpenFX) virtual overrides and framework callbacks keep their original names (exempt in .clang-tidy) Manual follow-ups required where automation could not reach: - string-based QMetaObject/SIGNAL/SLOT references updated to renamed methods (AddTask, CreatedFile, DeleteSpecificFile, moveSelectionUp, ...) - macro bodies referencing renamed methods (OLIVE_CONFIG, NODE_DEFAULT_DESTRUCTOR, MANAGEDDISPLAYWIDGET_*) - self-shadowing locals renamed where signals/methods became same-named (size_changed, worker_count, selected_items, import param, filters) - third_party OFX member/namespace usages restored (OFX::Host::*, _created, _clipPrefsDirty, createInstance, clearPersistentMessage) - STL protocol aliases restored (const_iterator) with .clang-tidy ignore rules; qHash overloads restored Full build and test suite pass: ctest 4/4, ~1960 gtest cases green.
147 lines
3.3 KiB
C++
147 lines
3.3 KiB
C++
#include <gtest/gtest.h>
|
|
|
|
#include <cmath>
|
|
|
|
#include <QApplication>
|
|
#include <QInputDialog>
|
|
#include <QMessageBox>
|
|
#include <QTimer>
|
|
|
|
#include "common/ratiodialog.h"
|
|
|
|
using namespace olive;
|
|
|
|
namespace
|
|
{
|
|
|
|
// Drives the modal dialogs that GetFloatRatioFromUser() pops up: feeds the
|
|
// queued text responses into QInputDialogs and accepts any QMessageBox shown
|
|
// in between (i.e. the invalid-ratio warning)
|
|
class DialogDriver : public QObject {
|
|
public:
|
|
explicit DialogDriver(const QStringList &responses)
|
|
: responses_(responses)
|
|
{
|
|
connect(&timer_, &QTimer::timeout, this, &DialogDriver::step);
|
|
timer_.start(10);
|
|
}
|
|
|
|
private:
|
|
void step()
|
|
{
|
|
QWidget *modal = QApplication::activeModalWidget();
|
|
if (!modal) {
|
|
return;
|
|
}
|
|
|
|
if (auto *box = qobject_cast<QMessageBox *>(modal)) {
|
|
box->accept();
|
|
return;
|
|
}
|
|
|
|
if (auto *input = qobject_cast<QInputDialog *>(modal)) {
|
|
if (responses_.isEmpty()) {
|
|
// No more responses queued: cancel the dialog
|
|
input->reject();
|
|
timer_.stop();
|
|
return;
|
|
}
|
|
|
|
input->setTextValue(responses_.takeFirst());
|
|
input->accept();
|
|
|
|
if (responses_.isEmpty()) {
|
|
timer_.stop();
|
|
}
|
|
}
|
|
}
|
|
|
|
QStringList responses_;
|
|
QTimer timer_;
|
|
};
|
|
|
|
} // namespace
|
|
|
|
TEST(CommonRatioDialog, AcceptsPlainDecimal)
|
|
{
|
|
DialogDriver driver({ QStringLiteral("1.5") });
|
|
|
|
bool ok = false;
|
|
const double ratio = get_float_ratio_from_user(nullptr, QStringLiteral("Test"), &ok);
|
|
|
|
EXPECT_TRUE(ok);
|
|
EXPECT_DOUBLE_EQ(ratio, 1.5);
|
|
}
|
|
|
|
TEST(CommonRatioDialog, AcceptsColonSeparatedRatio)
|
|
{
|
|
DialogDriver driver({ QStringLiteral("16:9") });
|
|
|
|
bool ok = false;
|
|
const double ratio = get_float_ratio_from_user(nullptr, QStringLiteral("Test"), &ok);
|
|
|
|
EXPECT_TRUE(ok);
|
|
EXPECT_DOUBLE_EQ(ratio, 16.0 / 9.0);
|
|
}
|
|
|
|
TEST(CommonRatioDialog, AcceptsSlashSeparatedRatio)
|
|
{
|
|
DialogDriver driver({ QStringLiteral("4/3") });
|
|
|
|
bool ok = false;
|
|
const double ratio = get_float_ratio_from_user(nullptr, QStringLiteral("Test"), &ok);
|
|
|
|
EXPECT_TRUE(ok);
|
|
EXPECT_DOUBLE_EQ(ratio, 4.0 / 3.0);
|
|
}
|
|
|
|
TEST(CommonRatioDialog, AcceptsSemicolonSeparatedRatio)
|
|
{
|
|
DialogDriver driver({ QStringLiteral("1;2") });
|
|
|
|
bool ok = false;
|
|
const double ratio = get_float_ratio_from_user(nullptr, QStringLiteral("Test"), &ok);
|
|
|
|
EXPECT_TRUE(ok);
|
|
EXPECT_DOUBLE_EQ(ratio, 0.5);
|
|
}
|
|
|
|
TEST(CommonRatioDialog, CancelReturnsNaN)
|
|
{
|
|
// An empty response list makes the driver cancel the input dialog
|
|
DialogDriver driver({});
|
|
|
|
bool ok = true;
|
|
const double ratio = get_float_ratio_from_user(nullptr, QStringLiteral("Test"), &ok);
|
|
|
|
EXPECT_FALSE(ok);
|
|
EXPECT_TRUE(std::isnan(ratio));
|
|
}
|
|
|
|
TEST(CommonRatioDialog, InvalidInputWarnsAndRetries)
|
|
{
|
|
// "banana" fails to parse (the driver accepts the warning box), the retry
|
|
// with a valid ratio succeeds
|
|
DialogDriver driver({ QStringLiteral("banana"), QStringLiteral("2") });
|
|
|
|
bool ok = false;
|
|
const double ratio = get_float_ratio_from_user(nullptr, QStringLiteral("Test"), &ok);
|
|
|
|
EXPECT_TRUE(ok);
|
|
EXPECT_DOUBLE_EQ(ratio, 2.0);
|
|
}
|
|
|
|
TEST(CommonRatioDialog, RejectsNonPositiveValues)
|
|
{
|
|
// Zero and negative values are rejected with a warning before a valid
|
|
// value is accepted
|
|
DialogDriver driver(
|
|
{ QStringLiteral("0"), QStringLiteral("-4:2"), QStringLiteral("3") });
|
|
|
|
bool ok = false;
|
|
const double ratio = get_float_ratio_from_user(nullptr, QStringLiteral("Test"), &ok);
|
|
|
|
EXPECT_TRUE(ok);
|
|
EXPECT_DOUBLE_EQ(ratio, 3.0);
|
|
}
|