Mike-Solar
bb40b4923e
Automated with clang-tidy readability-identifier-naming (config added to .clang-tidy) plus scripted passes, per the updated rules now documented in CONTRIBUTING.md: - types (class/struct/enum/alias/template params): PascalCase - functions, variables, members: snake_case (incl. rational -> Rational) - private/protected members: trailing underscore; static member variables likewise (instance_, available_themes_) - constants and enum values: snake_case (kLinear -> k_linear, F32P -> f32p); ALL_CAPS reserved for macros - macros: OAK_ prefix (OLIVE_ADD_TEST/OLIVE_ASSERT/OLIVE_CONFIG -> OAK_ADD_TEST/OAK_ASSERT/OAK_CONFIG, GL_PREAMBLE -> OAK_GL_PREAMBLE, include guards -> OAK_*) - file names: all lowercase (Current/Plugin/OliveHost/OliveClip/ OlivePluginInstance -> current/plugin/olivehost/oliveclip/ oliveplugininstance) - getters share the member name sans underscore, setters set_foo() - Qt and third-party (OpenFX) virtual overrides and framework callbacks keep their original names (exempt in .clang-tidy) Manual follow-ups required where automation could not reach: - string-based QMetaObject/SIGNAL/SLOT references updated to renamed methods (AddTask, CreatedFile, DeleteSpecificFile, moveSelectionUp, ...) - macro bodies referencing renamed methods (OLIVE_CONFIG, NODE_DEFAULT_DESTRUCTOR, MANAGEDDISPLAYWIDGET_*) - self-shadowing locals renamed where signals/methods became same-named (size_changed, worker_count, selected_items, import param, filters) - third_party OFX member/namespace usages restored (OFX::Host::*, _created, _clipPrefsDirty, createInstance, clearPersistentMessage) - STL protocol aliases restored (const_iterator) with .clang-tidy ignore rules; qHash overloads restored Full build and test suite pass: ctest 4/4, ~1960 gtest cases green.
100 lines
2.2 KiB
C++
100 lines
2.2 KiB
C++
#include <gtest/gtest.h>
|
|
|
|
#include <QBuffer>
|
|
#include <QXmlStreamReader>
|
|
#include <QXmlStreamWriter>
|
|
|
|
#include "node/node.h"
|
|
#include "node/serializeddata.h"
|
|
#include "node/splitvalue.h"
|
|
#include "node/value.h"
|
|
#include "render/diskmanager.h"
|
|
|
|
namespace
|
|
{
|
|
class TestNode final : public olive::Node {
|
|
public:
|
|
TestNode()
|
|
{
|
|
add_input(QStringLiteral("Value"), olive::NodeValue::k_float);
|
|
olive::SplitValue value;
|
|
value.append(3.5);
|
|
set_split_standard_value(QStringLiteral("Value"), value, -1);
|
|
}
|
|
|
|
TestNode *copy() const override
|
|
{
|
|
return new TestNode();
|
|
}
|
|
|
|
QString name() const override
|
|
{
|
|
return QStringLiteral("TestNode");
|
|
}
|
|
|
|
QString id() const override
|
|
{
|
|
return QStringLiteral("org.olivevideoeditor.TestNode");
|
|
}
|
|
|
|
QVector<CategoryID> category() const override
|
|
{
|
|
return { k_category_unknown };
|
|
}
|
|
|
|
QString description() const override
|
|
{
|
|
return QStringLiteral("Test node for serialization");
|
|
}
|
|
|
|
void value(const olive::NodeValueRow &, const olive::NodeGlobals &,
|
|
olive::NodeValueTable *) const override
|
|
{
|
|
}
|
|
};
|
|
}
|
|
|
|
TEST(NodeSerialization, SaveAndLoadInput)
|
|
{
|
|
const bool created_disk_manager =
|
|
(olive::DiskManager::instance() == nullptr);
|
|
if (created_disk_manager) {
|
|
olive::DiskManager::create_instance();
|
|
}
|
|
|
|
TestNode node;
|
|
node.set_label(QStringLiteral("MyNode"));
|
|
node.set_override_color(2);
|
|
|
|
QByteArray xml;
|
|
QBuffer buffer(&xml);
|
|
buffer.open(QIODevice::WriteOnly);
|
|
QXmlStreamWriter writer(&buffer);
|
|
writer.writeStartDocument();
|
|
writer.writeStartElement(QStringLiteral("node"));
|
|
node.save(&writer);
|
|
writer.writeEndElement();
|
|
writer.writeEndDocument();
|
|
buffer.close();
|
|
|
|
TestNode loaded;
|
|
olive::SerializedData data;
|
|
QBuffer read_buffer(&xml);
|
|
read_buffer.open(QIODevice::ReadOnly);
|
|
QXmlStreamReader reader(&read_buffer);
|
|
EXPECT_TRUE(reader.readNextStartElement());
|
|
EXPECT_EQ(reader.name().toString(), QStringLiteral("node"));
|
|
EXPECT_TRUE(loaded.load(&reader, &data));
|
|
|
|
EXPECT_EQ(loaded.get_label(), QStringLiteral("MyNode"));
|
|
EXPECT_EQ(loaded.get_override_color(), 2);
|
|
EXPECT_DOUBLE_EQ(loaded.get_split_standard_value(QStringLiteral("Value"), -1)
|
|
.first()
|
|
.toDouble(),
|
|
3.5);
|
|
|
|
if (created_disk_manager) {
|
|
olive::DiskManager::destroy_instance();
|
|
}
|
|
}
|