Mike-Solar
bb40b4923e
Automated with clang-tidy readability-identifier-naming (config added to .clang-tidy) plus scripted passes, per the updated rules now documented in CONTRIBUTING.md: - types (class/struct/enum/alias/template params): PascalCase - functions, variables, members: snake_case (incl. rational -> Rational) - private/protected members: trailing underscore; static member variables likewise (instance_, available_themes_) - constants and enum values: snake_case (kLinear -> k_linear, F32P -> f32p); ALL_CAPS reserved for macros - macros: OAK_ prefix (OLIVE_ADD_TEST/OLIVE_ASSERT/OLIVE_CONFIG -> OAK_ADD_TEST/OAK_ASSERT/OAK_CONFIG, GL_PREAMBLE -> OAK_GL_PREAMBLE, include guards -> OAK_*) - file names: all lowercase (Current/Plugin/OliveHost/OliveClip/ OlivePluginInstance -> current/plugin/olivehost/oliveclip/ oliveplugininstance) - getters share the member name sans underscore, setters set_foo() - Qt and third-party (OpenFX) virtual overrides and framework callbacks keep their original names (exempt in .clang-tidy) Manual follow-ups required where automation could not reach: - string-based QMetaObject/SIGNAL/SLOT references updated to renamed methods (AddTask, CreatedFile, DeleteSpecificFile, moveSelectionUp, ...) - macro bodies referencing renamed methods (OLIVE_CONFIG, NODE_DEFAULT_DESTRUCTOR, MANAGEDDISPLAYWIDGET_*) - self-shadowing locals renamed where signals/methods became same-named (size_changed, worker_count, selected_items, import param, filters) - third_party OFX member/namespace usages restored (OFX::Host::*, _created, _clipPrefsDirty, createInstance, clearPersistentMessage) - STL protocol aliases restored (const_iterator) with .clang-tidy ignore rules; qHash overloads restored Full build and test suite pass: ctest 4/4, ~1960 gtest cases green.
85 lines
2.5 KiB
C++
85 lines
2.5 KiB
C++
#include <gtest/gtest.h>
|
|
|
|
#include <QBuffer>
|
|
#include <QXmlStreamReader>
|
|
#include <QXmlStreamWriter>
|
|
|
|
#include "common/xmlutils.h"
|
|
|
|
TEST(CommonXmlUtils, ReadNextStartElement)
|
|
{
|
|
QByteArray xml = "<root><child>value</child></root>";
|
|
QBuffer buffer(&xml);
|
|
buffer.open(QIODevice::ReadOnly);
|
|
QXmlStreamReader reader(&buffer);
|
|
|
|
EXPECT_TRUE(olive::xml_read_next_start_element(&reader));
|
|
EXPECT_EQ(reader.name().toString(), QStringLiteral("root"));
|
|
EXPECT_TRUE(olive::xml_read_next_start_element(&reader));
|
|
EXPECT_EQ(reader.name().toString(), QStringLiteral("child"));
|
|
}
|
|
|
|
TEST(CommonXmlUtils, ReadNextStartElementSkipsWhitespace)
|
|
{
|
|
QByteArray xml = "\n \n<root>\n\n<child/>\n</root>";
|
|
QBuffer buffer(&xml);
|
|
buffer.open(QIODevice::ReadOnly);
|
|
QXmlStreamReader reader(&buffer);
|
|
|
|
EXPECT_TRUE(olive::xml_read_next_start_element(&reader));
|
|
EXPECT_EQ(reader.name().toString(), QStringLiteral("root"));
|
|
EXPECT_TRUE(olive::xml_read_next_start_element(&reader));
|
|
EXPECT_EQ(reader.name().toString(), QStringLiteral("child"));
|
|
}
|
|
|
|
TEST(CommonXmlUtils, ReadNextStartElementReturnsFalseAtEnd)
|
|
{
|
|
QByteArray xml = "<root/>";
|
|
QBuffer buffer(&xml);
|
|
buffer.open(QIODevice::ReadOnly);
|
|
QXmlStreamReader reader(&buffer);
|
|
|
|
EXPECT_TRUE(olive::xml_read_next_start_element(&reader));
|
|
EXPECT_EQ(reader.name().toString(), QStringLiteral("root"));
|
|
EXPECT_FALSE(olive::xml_read_next_start_element(&reader));
|
|
}
|
|
|
|
TEST(CommonXmlUtils, ReadNextStartElementSkipsUnknown)
|
|
{
|
|
QByteArray xml = "<root><unknown/><known/></root>";
|
|
QBuffer buffer(&xml);
|
|
buffer.open(QIODevice::ReadOnly);
|
|
QXmlStreamReader reader(&buffer);
|
|
|
|
EXPECT_TRUE(olive::xml_read_next_start_element(&reader));
|
|
EXPECT_TRUE(olive::xml_read_next_start_element(&reader));
|
|
EXPECT_EQ(reader.name().toString(), QStringLiteral("unknown"));
|
|
reader.skipCurrentElement();
|
|
EXPECT_TRUE(olive::xml_read_next_start_element(&reader));
|
|
EXPECT_EQ(reader.name().toString(), QStringLiteral("known"));
|
|
}
|
|
|
|
TEST(CommonXmlUtils, ReadNextStartElementWithCancel)
|
|
{
|
|
QByteArray xml = "<root><child/></root>";
|
|
QBuffer buffer(&xml);
|
|
buffer.open(QIODevice::ReadOnly);
|
|
QXmlStreamReader reader(&buffer);
|
|
|
|
olive::CancelAtom atom;
|
|
EXPECT_TRUE(olive::xml_read_next_start_element(&reader, &atom));
|
|
EXPECT_EQ(reader.name().toString(), QStringLiteral("root"));
|
|
}
|
|
|
|
TEST(CommonXmlUtils, ReadNextStartElementRespectsCancel)
|
|
{
|
|
QByteArray xml = "<root><child/></root>";
|
|
QBuffer buffer(&xml);
|
|
buffer.open(QIODevice::ReadOnly);
|
|
QXmlStreamReader reader(&buffer);
|
|
|
|
olive::CancelAtom atom;
|
|
atom.cancel();
|
|
EXPECT_FALSE(olive::xml_read_next_start_element(&reader, &atom));
|
|
}
|