From 9aa6c534552db800d91557a425996bdda3a605ed Mon Sep 17 00:00:00 2001 From: Aaron-Mann <46825032+Aaron-Mann@users.noreply.github.com> Date: Sun, 13 Oct 2019 19:21:23 -0700 Subject: [PATCH 1/2] Update README.md This README update includes clarity on the project and how to get started. --- README.md | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/README.md b/README.md index 379735ba7..faf62793f 100644 --- a/README.md +++ b/README.md @@ -8,12 +8,26 @@ Olive is a free non-linear video editor for Windows, macOS, and Linux. **NOTE: The issue tracker is temporarily closed while Olive's core is getting rewritten. We apologize for any inconvenience. Please check back soon for the next release, as well as the [Patreon page](https://www.patreon.com/olivevideoeditor) for news and updates.** + + +## Getting Started with Olive: + +Installation of Olive is available at: https://olivevideoeditor.org/download.php + +Instructions on how to use Olive are available on our wiki: https://github.com/olive-editor/olive/wiki/Overview-Guide + +**NOTE: Olive is Alpha Software, and it should be treated as highly unstable. Work at your own risk.** + +## Support Olive: + Please consider supporting Olive: [![Become a Patron](https://olivevideoeditor.org/img/become_a_patron_button.png)](https://www.patreon.com/olivevideoeditor) **NOTE: It is strongly discouraged to use or compile the `master` branch in its current state as it's under heavy restructuring. Please use the 0.1.x code from the "Releases" tab instead.** +## Compiling from Source: + Compiling instructions for Windows, macOS, and Linux can be found [on the main site](https://olivevideoeditor.org/compile.php). Olive has Doxygen-compatible documentation hosted at http://olivevideoeditor.org/doxygen/. You can also run `doxygen` in the source root directory to generate a local copy. From 2453b1d10c5abc43652150320e042c9292efe259 Mon Sep 17 00:00:00 2001 From: lightyear15 Date: Sat, 26 Oct 2019 21:39:34 +0200 Subject: [PATCH 2/2] Code Cleanup: common: removing default constructors As C++11 is the adopted standard, trivial constructors are not needed, compiler can generate it for us. --- app/common/rational.h | 5 +---- app/common/threadedobject.cpp | 4 ---- app/common/threadedobject.h | 1 - app/common/timerange.cpp | 4 ---- app/common/timerange.h | 2 +- 5 files changed, 2 insertions(+), 14 deletions(-) diff --git a/app/common/rational.h b/app/common/rational.h index 15a8d0825..7bd5408b8 100644 --- a/app/common/rational.h +++ b/app/common/rational.h @@ -51,10 +51,7 @@ public: numer = intType(0); } - rational(const rational &rhs) - :numer(rhs.numer), denom(rhs.denom) - { - } + rational(const rational &rhs) = default; rational(const AVRational& r); diff --git a/app/common/threadedobject.cpp b/app/common/threadedobject.cpp index a80ff44fc..a180cfeba 100644 --- a/app/common/threadedobject.cpp +++ b/app/common/threadedobject.cpp @@ -1,9 +1,5 @@ #include "threadedobject.h" -ThreadedObject::ThreadedObject() -{ -} - void ThreadedObject::LockDeletes() { threadobj_delete_lock_++; diff --git a/app/common/threadedobject.h b/app/common/threadedobject.h index 709c146e5..d69577345 100644 --- a/app/common/threadedobject.h +++ b/app/common/threadedobject.h @@ -6,7 +6,6 @@ class ThreadedObject { public: - ThreadedObject(); void LockMutex(); void UnlockMutex(); diff --git a/app/common/timerange.cpp b/app/common/timerange.cpp index e4ec160a1..6188c85eb 100644 --- a/app/common/timerange.cpp +++ b/app/common/timerange.cpp @@ -1,9 +1,5 @@ #include "timerange.h" -TimeRange::TimeRange() -{ -} - TimeRange::TimeRange(const rational &in, const rational &out) : in_(in), out_(out) diff --git a/app/common/timerange.h b/app/common/timerange.h index 1ff31992b..ae32be165 100644 --- a/app/common/timerange.h +++ b/app/common/timerange.h @@ -5,7 +5,7 @@ class TimeRange { public: - TimeRange(); + TimeRange() = default; TimeRange(const rational& in, const rational& out); const rational& in() const;