From e3f1d31a2be313f1f176cdd143c99e31af07acb8 Mon Sep 17 00:00:00 2001
From: itsmattkc <itsmattkc@gmail.com>
Date: Mon, 27 Aug 2018 17:53:48 +1000
Subject: [PATCH] fixed select all crash and multiple effect deleting crash

---
 panels/timeline.cpp | 12 +++++++-----
 project/undo.cpp    |  2 +-
 2 files changed, 8 insertions(+), 6 deletions(-)

diff --git a/panels/timeline.cpp b/panels/timeline.cpp
index 8ff9d8835..752252dbc 100644
--- a/panels/timeline.cpp
+++ b/panels/timeline.cpp
@@ -315,11 +315,13 @@ void Timeline::select_all() {
 		selections.clear();
 		for (int i=0;i<sequence->clip_count();i++) {
 			Clip* c = sequence->get_clip(i);
-			Selection s;
-			s.in = c->timeline_in;
-			s.out = c->timeline_out;
-			s.track = c->track;
-			if (c != NULL) selections.append(s);
+			if (c != NULL) {
+				Selection s;
+				s.in = c->timeline_in;
+				s.out = c->timeline_out;
+				s.track = c->track;
+				selections.append(s);
+			}
 		}
 		repaint_timeline();
 	}
diff --git a/project/undo.cpp b/project/undo.cpp
index 2ccb4fc13..0ad7763df 100644
--- a/project/undo.cpp
+++ b/project/undo.cpp
@@ -727,7 +727,7 @@ void EffectDeleteCommand::redo() {
 	deleted_objects.clear();
 	for (int i=0;i<clips.size();i++) {
 		Clip* c = clips.at(i);
-		int fx_id = fx.at(i);
+		int fx_id = fx.at(i) - i;
 		deleted_objects.append(c->effects.at(fx_id));
 		c->effects.removeAt(fx_id);
 	}