From cfbc37cd959df6efdb811062c22f9725e0c8d92e Mon Sep 17 00:00:00 2001 From: itsmattkc <34096995+itsmattkc@users.noreply.github.com> Date: Tue, 22 Nov 2022 11:23:54 -0800 Subject: [PATCH] previewautocacher: ignore render requests when params are invalid --- app/render/previewautocacher.cpp | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/app/render/previewautocacher.cpp b/app/render/previewautocacher.cpp index 149a1b83c..827b02c98 100644 --- a/app/render/previewautocacher.cpp +++ b/app/render/previewautocacher.cpp @@ -372,6 +372,11 @@ void PreviewAutoCacher::StartCachingAudioRange(PlaybackCache *cache, const TimeR void PreviewAutoCacher::VideoInvalidatedFromNode(PlaybackCache *cache, const TimeRange &range) { + // Ignore render requests if no video is present + if (!viewer_node_ || !viewer_node_->GetVideoParams().is_valid()) { + return; + } + // Stop any current render tasks because a) they might be out of date now anyway, and b) we // want to dedicate all our rendering power to realtime feedback for the user //CancelVideoTasks(node); @@ -386,6 +391,11 @@ void PreviewAutoCacher::VideoInvalidatedFromNode(PlaybackCache *cache, const Tim void PreviewAutoCacher::AudioInvalidatedFromNode(PlaybackCache *cache, const TimeRange &range) { + // Ignore render requests if no video is present + if (!viewer_node_ || !viewer_node_->GetAudioParams().is_valid()) { + return; + } + // We don't stop rendering audio because currently there's no system of requeuing audio if it's // cancelled, so some areas may end up unrendered forever // ClearAudioQueue();