From ce486f6b8432029ff804f5ffe9e263ff6bbf1f7a Mon Sep 17 00:00:00 2001 From: itsmattkc Date: Thu, 23 Jul 2020 18:46:47 +1000 Subject: [PATCH] cache: null check on saving frames Includes a warning since I'm not sure yet if this is problematic behavior or not yet. --- app/render/framehashcache.cpp | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/app/render/framehashcache.cpp b/app/render/framehashcache.cpp index 58f18a957..34437fe9b 100644 --- a/app/render/framehashcache.cpp +++ b/app/render/framehashcache.cpp @@ -193,7 +193,11 @@ void FrameHashCache::SaveCacheFrame(const QByteArray& hash, void FrameHashCache::SaveCacheFrame(const QByteArray &hash, FramePtr frame) { - SaveCacheFrame(hash, frame->data(), frame->video_params(), frame->linesize_bytes()); + if (frame) { + SaveCacheFrame(hash, frame->data(), frame->video_params(), frame->linesize_bytes()); + } else { + qWarning() << "Attempted to save a NULL frame to the cache. This may or may not be desirable."; + } } FramePtr FrameHashCache::LoadCacheFrame(const QByteArray &hash)