From cdfba418fcb17ab831f3a49dd9371c3ff45e3b45 Mon Sep 17 00:00:00 2001 From: itsmattkc Date: Sun, 16 Feb 2020 00:45:36 +1100 Subject: [PATCH] ffmpegdecoder: added fixme comments for errors that aren't handled --- app/codec/ffmpeg/ffmpegdecoder.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/app/codec/ffmpeg/ffmpegdecoder.cpp b/app/codec/ffmpeg/ffmpegdecoder.cpp index 8b4dde3e5..dc72465ad 100644 --- a/app/codec/ffmpeg/ffmpegdecoder.cpp +++ b/app/codec/ffmpeg/ffmpegdecoder.cpp @@ -334,6 +334,7 @@ FramePtr FFmpegDecoder::RetrieveAudio(const rational &timecode, const rational & WaveInput input(GetConformedFilename(params)); + // FIXME: No handling if input failed to open/is corrupt if (input.open()) { const AudioRenderingParams& input_params = input.params(); @@ -424,6 +425,7 @@ void FFmpegDecoder::Conform(const AudioRenderingParams ¶ms) // Get indexed WAV file WaveInput input(GetIndexFilename()); + // FIXME: No handling if input failed to open/is corrupt if (input.open()) { // If the parameters are equal, nothing to be done // FIXME: Technically we only need to conform if the SAMPLE RATE is not equal. Format and channel layout conversion @@ -722,6 +724,7 @@ QString FFmpegDecoder::GetConformedFilename(const AudioRenderingParams ¶ms) QString index_fn = GetIndexFilename(); WaveInput input(GetIndexFilename()); + // FIXME: No handling if input failed to open/is corrupt if (input.open()) { // If the parameters are equal, nothing to be done AudioRenderingParams index_params = input.params();