From 82454c09c9edf0ae91fc7a5c28f429fcdacccb40 Mon Sep 17 00:00:00 2001
From: itsmattkc <34096995+itsmattkc@users.noreply.github.com>
Date: Mon, 27 Feb 2023 18:12:13 -0800
Subject: [PATCH 1/2] viewer: force valid sample type

Fixes #2183
---
 app/render/previewautocacher.cpp | 5 ++++-
 app/widget/viewer/viewer.cpp     | 2 ++
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/app/render/previewautocacher.cpp b/app/render/previewautocacher.cpp
index db4466329..2abe537bd 100644
--- a/app/render/previewautocacher.cpp
+++ b/app/render/previewautocacher.cpp
@@ -625,9 +625,12 @@ RenderTicketPtr PreviewAutoCacher::RenderAudio(Node *node, ViewerOutput *context
   connect(watcher, &RenderTicketWatcher::Finished, this, &PreviewAutoCacher::AudioRendered);
   running_audio_tasks_.append(watcher);
 
+  AudioParams p = context->GetAudioParams();
+  p.set_format(ViewerOutput::kDefaultSampleFormat);
+
   RenderManager::RenderAudioParams rap(node,
                                        r,
-                                       context->GetAudioParams(),
+                                       p,
                                        RenderMode::kOffline);
 
   rap.generate_waveforms = dynamic_cast<AudioWaveformCache*>(cache);
diff --git a/app/widget/viewer/viewer.cpp b/app/widget/viewer/viewer.cpp
index 70e973ddd..0e4f25aa9 100644
--- a/app/widget/viewer/viewer.cpp
+++ b/app/widget/viewer/viewer.cpp
@@ -510,6 +510,8 @@ void ViewerWidget::UpdateAudioProcessor()
     CloseAudioProcessor();
 
     AudioParams ap = GetConnectedNode()->GetAudioParams();
+    ap.set_format(ViewerOutput::kDefaultSampleFormat);
+
     AudioParams packed(OLIVE_CONFIG("AudioOutputSampleRate").toInt(),
                        OLIVE_CONFIG("AudioOutputChannelLayout").toULongLong(),
                        SampleFormat::from_string(OLIVE_CONFIG("AudioOutputSampleFormat").toString().toStdString()));

From ec2ff82229d31a41274104766cb0287c0c2f3fd1 Mon Sep 17 00:00:00 2001
From: itsmattkc <34096995+itsmattkc@users.noreply.github.com>
Date: Mon, 27 Feb 2023 18:12:28 -0800
Subject: [PATCH 2/2] node: merge tooltip into data function

---
 app/node/node.h                               | 15 +---
 app/node/project/footage/footage.cpp          | 81 +++++++++----------
 app/node/project/footage/footage.h            | 16 ----
 .../projectexplorer/projectviewmodel.cpp      |  2 +-
 4 files changed, 43 insertions(+), 71 deletions(-)

diff --git a/app/node/node.h b/app/node/node.h
index 974db61f8..3eeadedf4 100644
--- a/app/node/node.h
+++ b/app/node/node.h
@@ -175,11 +175,6 @@ public:
    */
   virtual QString Description() const;
 
-  const QString& ToolTip() const
-  {
-    return tooltip_;
-  }
-
   Folder* folder() const
   {
     return folder_;
@@ -198,7 +193,8 @@ public:
     DURATION,
     CREATED_TIME,
     MODIFIED_TIME,
-    FREQUENCY_RATE
+    FREQUENCY_RATE,
+    TOOLTIP
   };
 
   virtual QVariant data(const DataType &d) const;
@@ -1026,11 +1022,6 @@ protected:
     effect_input_ = input;
   }
 
-  void SetToolTip(const QString& s)
-  {
-    tooltip_ = s;
-  }
-
   void SetFlag(Flag f, bool on = true)
   {
     if (on) {
@@ -1229,8 +1220,6 @@ private:
 
   OutputConnections output_connections_;
 
-  QString tooltip_;
-
   Folder* folder_;
 
   QMap<InputElementPair, ValueHint> value_hints_;
diff --git a/app/node/project/footage/footage.cpp b/app/node/project/footage/footage.cpp
index 87b962459..80c2fda66 100644
--- a/app/node/project/footage/footage.cpp
+++ b/app/node/project/footage/footage.cpp
@@ -397,6 +397,46 @@ QVariant Footage::data(const DataType &d) const
 
     return icon::Error;
   }
+  case TOOLTIP:
+  {
+    if (valid_) {
+      QString tip = tr("Filename: %1").arg(filename());
+
+      int vp_sz = GetVideoStreamCount();
+      for (int i=0; i<vp_sz; i++) {
+        VideoParams p = GetVideoParams(i);
+
+        if (p.enabled()) {
+          tip.append("\n");
+          tip.append(DescribeVideoStream(p));
+        }
+      }
+
+      int ap_sz = GetAudioStreamCount();
+      for (int i=0; i<ap_sz; i++) {
+        AudioParams p = GetAudioParams(i);
+
+        if (p.enabled()) {
+          tip.append("\n");
+          tip.append(DescribeAudioStream(p));
+        }
+      }
+
+      int sp_sz = GetSubtitleStreamCount();
+      for (int i=0; i<sp_sz; i++) {
+        SubtitleParams p = GetSubtitleParams(i);
+
+        if (p.enabled()) {
+          tip.append("\n");
+          tip.append(DescribeSubtitleStream(p));
+        }
+      }
+
+      return tip;
+    } else {
+      return tr("Invalid");
+    }
+  }
   default:
     break;
   }
@@ -404,47 +444,6 @@ QVariant Footage::data(const DataType &d) const
   return super::data(d);
 }
 
-void Footage::UpdateTooltip()
-{
-  if (valid_) {
-    QString tip = tr("Filename: %1").arg(filename());
-
-    int vp_sz = GetVideoStreamCount();
-    for (int i=0; i<vp_sz; i++) {
-      VideoParams p = GetVideoParams(i);
-
-      if (p.enabled()) {
-        tip.append("\n");
-        tip.append(DescribeVideoStream(p));
-      }
-    }
-
-    int ap_sz = GetAudioStreamCount();
-    for (int i=0; i<ap_sz; i++) {
-      AudioParams p = GetAudioParams(i);
-
-      if (p.enabled()) {
-        tip.append("\n");
-        tip.append(DescribeAudioStream(p));
-      }
-    }
-
-    int sp_sz = GetSubtitleStreamCount();
-    for (int i=0; i<sp_sz; i++) {
-      SubtitleParams p = GetSubtitleParams(i);
-
-      if (p.enabled()) {
-        tip.append("\n");
-        tip.append(DescribeSubtitleStream(p));
-      }
-    }
-
-    SetToolTip(tip);
-  } else {
-    SetToolTip(tr("Invalid"));
-  }
-}
-
 void Footage::Reprobe()
 {
   // Determine if file still exists
diff --git a/app/node/project/footage/footage.h b/app/node/project/footage/footage.h
index 20c24bab1..f7b6db370 100644
--- a/app/node/project/footage/footage.h
+++ b/app/node/project/footage/footage.h
@@ -183,22 +183,6 @@ protected:
 private:
   QString GetColorspaceToUse(const VideoParams& params) const;
 
-  /**
-   * @brief Update the icon based on the Footage status
-   *
-   * For kUnprobed and kError an appropriate icon will be shown. For kReady, this function will determine what the
-   * dominant type of media in this Footage is (video/audio/image) and set the icon accordingly based on that.
-   */
-  void UpdateIcon();
-
-  /**
-   * @brief Update the tooltip based on the Footage status
-   *
-   * For kUnprobed and kError, this sets an appropriate generic message. For kReady, this function will set
-   * basic information about the Footage in the tooltip (based on the results of a previous probe).
-   */
-  void UpdateTooltip();
-
   void Reprobe();
 
   VideoParams MergeVideoStream(const VideoParams &base, const VideoParams &over);
diff --git a/app/widget/projectexplorer/projectviewmodel.cpp b/app/widget/projectexplorer/projectviewmodel.cpp
index 28223f586..8efe73014 100644
--- a/app/widget/projectexplorer/projectviewmodel.cpp
+++ b/app/widget/projectexplorer/projectviewmodel.cpp
@@ -181,7 +181,7 @@ QVariant ProjectViewModel::data(const QModelIndex &index, int role) const
     }
     break;
   case Qt::ToolTipRole:
-    return internal_item->ToolTip();
+    return internal_item->data(Node::TOOLTIP);
   }
 
   return QVariant();