From caf0d3d42a679c93a76521265ca6d6d8c5d226fa Mon Sep 17 00:00:00 2001
From: itsmattkc <itsmattkc@gmail.com>
Date: Mon, 3 Feb 2020 01:28:43 +1100
Subject: [PATCH] renderer: minor code improvements

---
 app/render/backend/opengl/openglrenderfunctions.cpp | 2 +-
 app/render/backend/renderbackend.cpp                | 2 +-
 app/render/backend/videorenderbackend.cpp           | 8 +++-----
 3 files changed, 5 insertions(+), 7 deletions(-)

diff --git a/app/render/backend/opengl/openglrenderfunctions.cpp b/app/render/backend/opengl/openglrenderfunctions.cpp
index 48c33d2cd..1375a1a95 100644
--- a/app/render/backend/opengl/openglrenderfunctions.cpp
+++ b/app/render/backend/opengl/openglrenderfunctions.cpp
@@ -139,7 +139,7 @@ void OpenGLRenderFunctions::OCIOBlit(OpenGLShaderPtr pipeline,
 
   pipeline->setUniformValue("ove_ociolut", 2);
 
-  OpenGLRenderFunctions::Blit(pipeline, flipped, matrix);
+  Blit(pipeline, flipped, matrix);
 
   pipeline->release();
 
diff --git a/app/render/backend/renderbackend.cpp b/app/render/backend/renderbackend.cpp
index 5cb51fb52..93fd9d566 100644
--- a/app/render/backend/renderbackend.cpp
+++ b/app/render/backend/renderbackend.cpp
@@ -25,7 +25,7 @@ bool RenderBackend::Init()
     return true;
   }
 
-  threads_.resize(qMax(1, QThread::idealThreadCount() - 1));
+  threads_.resize(QThread::idealThreadCount());
 
   for (int i=0;i<threads_.size();i++) {
     QThread* thread = new QThread(this);
diff --git a/app/render/backend/videorenderbackend.cpp b/app/render/backend/videorenderbackend.cpp
index 117023634..1f56556d5 100644
--- a/app/render/backend/videorenderbackend.cpp
+++ b/app/render/backend/videorenderbackend.cpp
@@ -245,18 +245,16 @@ TimeRange VideoRenderBackend::PopNextFrameFromQueue()
   // Use this variable to find the closest frame in the range
   rational closest_time = -1;
 
-  for (int i=0;i<cache_queue_.size();i++) {
-    const TimeRange& range_here = cache_queue_.at(i);
-
+  foreach (const TimeRange& range_here, cache_queue_) {
     if (range_here.OverlapsWith(test_range, false, false)) {
       closest_time = -1;
       break;
     }
 
-    for (int i=0;i<2;i++) {
+    for (int j=0;j<2;j++) {
       rational compare;
 
-      if (i == 0) {
+      if (j == 0) {
         compare = Timecode::snap_time_to_timebase(range_here.in(), params_.time_base());
         if (compare > range_here.in()) {
           compare -= params_.time_base();