oak-team/oak-editor
3
1
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

style/preferences: don't set style if it hasn't changed

Browse Source 
Improves Preferences dialog's "accept" speed. Before it would try changing the
style no matter what which took a noticeable amount of time to do for no real
purpose if the style didn't change.
This commit is contained in:
itsmattkc
2020-04-21 19:35:04 +10:00
parent 50d336ffb8
commit c84f7fe724
3 changed files with 32 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/dialog/preferences/tabs/preferencesappearancetab.cpp
+4 -8
View File
@@ -47,7 +47,7 @@ PreferencesAppearanceTab::PreferencesAppearanceTab()
foreach (StyleDescriptor s, style_list_) {
style_->addItem(s.name(), s.path());
if (s.path() == Config::Current()["Style"]) {
if (s.path() == StyleManager::GetStyle()) {
style_->setCurrentIndex(style_->count()-1);
}
}
@@ -62,14 +62,10 @@ PreferencesAppearanceTab::PreferencesAppearanceTab()
void PreferencesAppearanceTab::Accept()
{
QString style_path = style_->currentData().toString();
StyleManager::SetStyle(style_path);
Config::Current()["Style"] = style_path;
if (style_->currentIndex() < style_list_.size()) {
// This is an internal style, set accordingly
} else {
StyleManager::SetStyle(style_->currentData().toString());
if (style_path != StyleManager::GetStyle()) {
StyleManager::SetStyle(style_path);
Config::Current()["Style"] = style_path;
}
}