oak-team/oak-editor
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

tests: make unknown-icon check robust across Qt builds

Browse Source 
QIcon::addFile() differs between Qt versions in whether entries for
nonexistent files keep the icon non-null (Ubuntu CI failure). Assert
on what matters: no usable pixmap or size is produced.
This commit is contained in:
Mike-Solar
2026-07-17 18:28:38 +08:00
parent ff95ffa216
commit c734ecdba1
1 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/gtest/ui_icons_test.cpp
+7 -2
View File
@@ -32,12 +32,17 @@ TEST(UIIcons, CreateLoadsAllSizes)
EXPECT_FALSE(icon.pixmap(QSize(32, 32)).isNull()); EXPECT_FALSE(icon.pixmap(QSize(32, 32)).isNull());
} }
TEST(UIIcons, CreateWithUnknownNameIsNull) TEST(UIIcons, CreateWithUnknownNameYieldsNoUsableIcon)
{ {
QIcon icon = olive::icon::Create(QStringLiteral(":/style/olive-dark"), QIcon icon = olive::icon::Create(QStringLiteral(":/style/olive-dark"),
QStringLiteral("no-such-icon")); QStringLiteral("no-such-icon"));
EXPECT_TRUE(icon.isNull());
// QIcon::addFile() differs across Qt builds in whether entries for
// nonexistent files keep the icon "null". What matters is that no usable
// pixmap can be produced for an unknown icon name.
EXPECT_TRUE(icon.availableSizes().isEmpty()); EXPECT_TRUE(icon.availableSizes().isEmpty());
EXPECT_TRUE(icon.pixmap(QSize(16, 16)).isNull());
EXPECT_TRUE(icon.pixmap(32, 32, QIcon::Disabled).isNull());
} }
TEST(UIIcons, LoadAllPopulatesGlobalIcons) TEST(UIIcons, LoadAllPopulatesGlobalIcons)