oak-team/oak-editor
3
1
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

make nodes more const friendly and prepare their functions for stateless work

Browse Source 
Since the nodes won't be holding any rendering data themselves in this system,
we may as well enforce some level of non-write access by setting all the
functions to const. They were already const-friendly, they just weren't
labelled as such.
This commit is contained in:
itsmattkc
2019-12-04 20:10:42 +11:00
parent cbf4d5b8c7
commit bc0f01d9a3
30 changed files with 505 additions and 346 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/node/output/viewer/viewer.cpp
+7 -6
View File
@@ -35,27 +35,27 @@ ViewerOutput::ViewerOutput()
AddParameter(length_input_);
}
Node *ViewerOutput::copy()
Node *ViewerOutput::copy() const
{
return new ViewerOutput();
}
QString ViewerOutput::Name()
QString ViewerOutput::Name() const
{
return tr("Viewer");
}
QString ViewerOutput::id()
QString ViewerOutput::id() const
{
return "org.olivevideoeditor.Olive.vieweroutput";
}
QString ViewerOutput::Category()
QString ViewerOutput::Category() const
{
return tr("Output");
}
QString ViewerOutput::Description()
QString ViewerOutput::Description() const
{
return tr("Interface between a Viewer panel and the node system.");
}
@@ -115,7 +115,8 @@ void ViewerOutput::set_audio_params(const AudioParams &audio)
rational ViewerOutput::Length()
{
return length_input_->get_realtime_value_of_connected_output().value<rational>();
// FIXME: This is pretty messy, there's probably a better way...
return length_input_->get_connected_node()->Value(NodeValueDatabase()).Get(NodeParam::kRational).value<rational>();
}
void ViewerOutput::DependentEdgeChanged(NodeInput *from)
app/node/output/viewer/viewer.h
+5 -5
View File
@@ -36,12 +36,12 @@ class ViewerOutput : public Node
public:
ViewerOutput();
virtual Node* copy() override;
virtual Node* copy() const override;
virtual QString Name() override;
virtual QString id() override;
virtual QString Category() override;
virtual QString Description() override;
virtual QString Name() const override;
virtual QString id() const override;
virtual QString Category() const override;
virtual QString Description() const override;
NodeInput* texture_input();
NodeInput* samples_input();