oak-team/oak-editor
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

style: unify identifier naming per updated conventions

Browse Source 
Automated with clang-tidy readability-identifier-naming (config added to
.clang-tidy) plus scripted passes, per the updated rules now documented
in CONTRIBUTING.md:

- types (class/struct/enum/alias/template params): PascalCase
- functions, variables, members: snake_case (incl. rational -> Rational)
- private/protected members: trailing underscore; static member
  variables likewise (instance_, available_themes_)
- constants and enum values: snake_case (kLinear -> k_linear,
  F32P -> f32p); ALL_CAPS reserved for macros
- macros: OAK_ prefix (OLIVE_ADD_TEST/OLIVE_ASSERT/OLIVE_CONFIG ->
  OAK_ADD_TEST/OAK_ASSERT/OAK_CONFIG, GL_PREAMBLE -> OAK_GL_PREAMBLE,
  include guards -> OAK_*)
- file names: all lowercase (Current/Plugin/OliveHost/OliveClip/
  OlivePluginInstance -> current/plugin/olivehost/oliveclip/
  oliveplugininstance)
- getters share the member name sans underscore, setters set_foo()
- Qt and third-party (OpenFX) virtual overrides and framework callbacks
  keep their original names (exempt in .clang-tidy)

Manual follow-ups required where automation could not reach:
- string-based QMetaObject/SIGNAL/SLOT references updated to renamed
  methods (AddTask, CreatedFile, DeleteSpecificFile, moveSelectionUp, ...)
- macro bodies referencing renamed methods (OLIVE_CONFIG,
  NODE_DEFAULT_DESTRUCTOR, MANAGEDDISPLAYWIDGET_*)
- self-shadowing locals renamed where signals/methods became same-named
  (size_changed, worker_count, selected_items, import param, filters)
- third_party OFX member/namespace usages restored (OFX::Host::*,
  _created, _clipPrefsDirty, createInstance, clearPersistentMessage)
- STL protocol aliases restored (const_iterator) with .clang-tidy
  ignore rules; qHash overloads restored

Full build and test suite pass: ctest 4/4, ~1960 gtest cases green.
This commit is contained in:
Mike-Solar
2026-07-19 16:10:54 +08:00
parent cb1718a103
commit bb40b4923e
1014 changed files with 44257 additions and 44220 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/gtest/undo_stack_test.cpp
+13 -13
View File
@@ -14,7 +14,7 @@ public:
{
}
olive::Project *GetRelevantProject() const override
olive::Project *get_relevant_project() const override
{
return nullptr;
}
@@ -54,8 +54,8 @@ TEST(UndoStack, PushUndoRedo)
TEST(UndoStack, EmptyStateAndModelData)
{
olive::UndoStack stack;
EXPECT_FALSE(stack.CanUndo());
EXPECT_FALSE(stack.CanRedo());
EXPECT_FALSE(stack.can_undo());
EXPECT_FALSE(stack.can_redo());
EXPECT_EQ(stack.columnCount(), 2);
EXPECT_EQ(stack.rowCount(), 1);
EXPECT_TRUE(stack.hasChildren(QModelIndex()));
@@ -80,7 +80,7 @@ TEST(UndoStack, UndoRedoListsAndColors)
stack.undo();
EXPECT_EQ(counter, 1);
EXPECT_TRUE(stack.CanRedo());
EXPECT_TRUE(stack.can_redo());
QModelIndex undone_name = stack.index(2, 1);
EXPECT_EQ(stack.data(undone_name, Qt::DisplayRole).toString(),
@@ -91,7 +91,7 @@ TEST(UndoStack, UndoRedoListsAndColors)
stack.redo();
EXPECT_EQ(counter, 2);
EXPECT_FALSE(stack.CanRedo());
EXPECT_FALSE(stack.can_redo());
}
TEST(UndoStack, JumpRestoresState)
@@ -106,11 +106,11 @@ TEST(UndoStack, JumpRestoresState)
stack.jump(1);
EXPECT_EQ(counter, 0);
EXPECT_TRUE(stack.CanRedo());
EXPECT_TRUE(stack.can_redo());
stack.jump(4);
EXPECT_EQ(counter, 3);
EXPECT_FALSE(stack.CanRedo());
EXPECT_FALSE(stack.can_redo());
}
TEST(UndoStack, EmptyMultiUndoCommandIsIgnored)
@@ -119,7 +119,7 @@ TEST(UndoStack, EmptyMultiUndoCommandIsIgnored)
auto *empty_multi = new olive::MultiUndoCommand();
stack.push(empty_multi, QStringLiteral("Empty"));
EXPECT_EQ(stack.rowCount(), 1);
EXPECT_FALSE(stack.CanUndo());
EXPECT_FALSE(stack.can_undo());
}
TEST(UndoStack, MultipleUndosAndRedos)
@@ -134,8 +134,8 @@ TEST(UndoStack, MultipleUndosAndRedos)
stack.undo();
stack.undo();
EXPECT_EQ(counter, 1);
EXPECT_TRUE(stack.CanUndo());
EXPECT_TRUE(stack.CanRedo());
EXPECT_TRUE(stack.can_undo());
EXPECT_TRUE(stack.can_redo());
stack.redo();
EXPECT_EQ(counter, 2);
@@ -154,7 +154,7 @@ TEST(UndoStack, PushAfterUndoClearsRedoBranch)
stack.push(new TestCommand(&counter), QStringLiteral("Third"));
EXPECT_EQ(counter, 2);
EXPECT_FALSE(stack.CanRedo());
EXPECT_FALSE(stack.can_redo());
}
TEST(UndoStack, ResetClearsHistory)
@@ -165,8 +165,8 @@ TEST(UndoStack, ResetClearsHistory)
EXPECT_EQ(counter, 1);
stack.clear();
EXPECT_FALSE(stack.CanUndo());
EXPECT_FALSE(stack.CanRedo());
EXPECT_FALSE(stack.can_undo());
EXPECT_FALSE(stack.can_redo());
EXPECT_EQ(stack.rowCount(), 1);
}