oak-team/oak-editor
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

style: unify identifier naming per updated conventions

Browse Source 
Automated with clang-tidy readability-identifier-naming (config added to
.clang-tidy) plus scripted passes, per the updated rules now documented
in CONTRIBUTING.md:

- types (class/struct/enum/alias/template params): PascalCase
- functions, variables, members: snake_case (incl. rational -> Rational)
- private/protected members: trailing underscore; static member
  variables likewise (instance_, available_themes_)
- constants and enum values: snake_case (kLinear -> k_linear,
  F32P -> f32p); ALL_CAPS reserved for macros
- macros: OAK_ prefix (OLIVE_ADD_TEST/OLIVE_ASSERT/OLIVE_CONFIG ->
  OAK_ADD_TEST/OAK_ASSERT/OAK_CONFIG, GL_PREAMBLE -> OAK_GL_PREAMBLE,
  include guards -> OAK_*)
- file names: all lowercase (Current/Plugin/OliveHost/OliveClip/
  OlivePluginInstance -> current/plugin/olivehost/oliveclip/
  oliveplugininstance)
- getters share the member name sans underscore, setters set_foo()
- Qt and third-party (OpenFX) virtual overrides and framework callbacks
  keep their original names (exempt in .clang-tidy)

Manual follow-ups required where automation could not reach:
- string-based QMetaObject/SIGNAL/SLOT references updated to renamed
  methods (AddTask, CreatedFile, DeleteSpecificFile, moveSelectionUp, ...)
- macro bodies referencing renamed methods (OLIVE_CONFIG,
  NODE_DEFAULT_DESTRUCTOR, MANAGEDDISPLAYWIDGET_*)
- self-shadowing locals renamed where signals/methods became same-named
  (size_changed, worker_count, selected_items, import param, filters)
- third_party OFX member/namespace usages restored (OFX::Host::*,
  _created, _clipPrefsDirty, createInstance, clearPersistentMessage)
- STL protocol aliases restored (const_iterator) with .clang-tidy
  ignore rules; qHash overloads restored

Full build and test suite pass: ctest 4/4, ~1960 gtest cases green.
This commit is contained in:
Mike-Solar
2026-07-19 16:10:54 +08:00
parent cb1718a103
commit bb40b4923e
1014 changed files with 44257 additions and 44220 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/gtest/ui_style_test.cpp
+12 -12
View File
@@ -9,7 +9,7 @@
TEST(UIStyle, InitPopulatesThemesAndAppliesStyle)
{
olive::StyleManager::Init();
olive::StyleManager::init();
const QMap<QString, QString> &themes = olive::StyleManager::available_themes();
EXPECT_EQ(themes.size(), 2);
@@ -19,14 +19,14 @@ TEST(UIStyle, InitPopulatesThemesAndAppliesStyle)
QStringLiteral("Oak Light"));
// Whatever the config says, the current style must be a known theme
EXPECT_TRUE(themes.contains(olive::StyleManager::GetStyle()));
EXPECT_TRUE(themes.contains(olive::StyleManager::get_style()));
EXPECT_FALSE(qApp->styleSheet().isEmpty());
}
TEST(UIStyle, SetStyleAppliesPaletteFromIni)
{
olive::StyleManager::SetStyle(QStringLiteral("olive-dark"));
EXPECT_EQ(olive::StyleManager::GetStyle(), QStringLiteral("olive-dark"));
olive::StyleManager::set_style(QStringLiteral("olive-dark"));
EXPECT_EQ(olive::StyleManager::get_style(), QStringLiteral("olive-dark"));
// Values from app/ui/style/olive-dark/palette.ini
const QPalette p = qApp->palette();
@@ -44,11 +44,11 @@ TEST(UIStyle, SetStyleAppliesPaletteFromIni)
TEST(UIStyle, SetStyleSwitchesThemes)
{
olive::StyleManager::SetStyle(QStringLiteral("olive-dark"));
olive::StyleManager::set_style(QStringLiteral("olive-dark"));
const QColor dark_window = qApp->palette().color(QPalette::Window);
olive::StyleManager::SetStyle(QStringLiteral("olive-light"));
EXPECT_EQ(olive::StyleManager::GetStyle(), QStringLiteral("olive-light"));
olive::StyleManager::set_style(QStringLiteral("olive-light"));
EXPECT_EQ(olive::StyleManager::get_style(), QStringLiteral("olive-light"));
// Values from app/ui/style/olive-light/palette.ini
EXPECT_EQ(qApp->palette().color(QPalette::Window),
@@ -56,15 +56,15 @@ TEST(UIStyle, SetStyleSwitchesThemes)
EXPECT_NE(qApp->palette().color(QPalette::Window), dark_window);
// Restore the default theme for subsequent tests
olive::StyleManager::SetStyle(olive::StyleManager::kDefaultStyle);
EXPECT_EQ(olive::StyleManager::GetStyle(),
olive::StyleManager::set_style(olive::StyleManager::k_default_style);
EXPECT_EQ(olive::StyleManager::get_style(),
QStringLiteral("olive-dark"));
}
TEST(UIStyle, SetStyleWithMissingThemeClearsOverrides)
{
olive::StyleManager::SetStyle(QStringLiteral("does-not-exist"));
EXPECT_EQ(olive::StyleManager::GetStyle(),
olive::StyleManager::set_style(QStringLiteral("does-not-exist"));
EXPECT_EQ(olive::StyleManager::get_style(),
QStringLiteral("does-not-exist"));
// No palette.ini/style.css in this theme: fall back to standard palette
@@ -74,5 +74,5 @@ TEST(UIStyle, SetStyleWithMissingThemeClearsOverrides)
qApp->style()->standardPalette().color(QPalette::Window));
// Restore the default theme for subsequent tests
olive::StyleManager::SetStyle(olive::StyleManager::kDefaultStyle);
olive::StyleManager::set_style(olive::StyleManager::k_default_style);
}