oak-team/oak-editor
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

style: unify identifier naming per updated conventions

Browse Source 
Automated with clang-tidy readability-identifier-naming (config added to
.clang-tidy) plus scripted passes, per the updated rules now documented
in CONTRIBUTING.md:

- types (class/struct/enum/alias/template params): PascalCase
- functions, variables, members: snake_case (incl. rational -> Rational)
- private/protected members: trailing underscore; static member
  variables likewise (instance_, available_themes_)
- constants and enum values: snake_case (kLinear -> k_linear,
  F32P -> f32p); ALL_CAPS reserved for macros
- macros: OAK_ prefix (OLIVE_ADD_TEST/OLIVE_ASSERT/OLIVE_CONFIG ->
  OAK_ADD_TEST/OAK_ASSERT/OAK_CONFIG, GL_PREAMBLE -> OAK_GL_PREAMBLE,
  include guards -> OAK_*)
- file names: all lowercase (Current/Plugin/OliveHost/OliveClip/
  OlivePluginInstance -> current/plugin/olivehost/oliveclip/
  oliveplugininstance)
- getters share the member name sans underscore, setters set_foo()
- Qt and third-party (OpenFX) virtual overrides and framework callbacks
  keep their original names (exempt in .clang-tidy)

Manual follow-ups required where automation could not reach:
- string-based QMetaObject/SIGNAL/SLOT references updated to renamed
  methods (AddTask, CreatedFile, DeleteSpecificFile, moveSelectionUp, ...)
- macro bodies referencing renamed methods (OLIVE_CONFIG,
  NODE_DEFAULT_DESTRUCTOR, MANAGEDDISPLAYWIDGET_*)
- self-shadowing locals renamed where signals/methods became same-named
  (size_changed, worker_count, selected_items, import param, filters)
- third_party OFX member/namespace usages restored (OFX::Host::*,
  _created, _clipPrefsDirty, createInstance, clearPersistentMessage)
- STL protocol aliases restored (const_iterator) with .clang-tidy
  ignore rules; qHash overloads restored

Full build and test suite pass: ctest 4/4, ~1960 gtest cases green.
This commit is contained in:
Mike-Solar
2026-07-19 16:10:54 +08:00
parent cb1718a103
commit bb40b4923e
1014 changed files with 44257 additions and 44220 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/gtest/timecode_metadata_test.cpp
+38 -38
View File
@@ -12,77 +12,77 @@
TEST(TimecodeMetadata, ParsesNonDropFrameTimecode)
{
const olive::TimecodeMetadata::SourceTime parsed =
olive::TimecodeMetadata::FromTimecodeString(
QStringLiteral("01:02:03:12"), olive::core::rational(1, 24));
olive::TimecodeMetadata::from_timecode_string(
QStringLiteral("01:02:03:12"), olive::core::Rational(1, 24));
ASSERT_TRUE(parsed.valid);
EXPECT_EQ(parsed.source, QStringLiteral("timecode"));
EXPECT_EQ(parsed.time, olive::core::rational(1 * 3600 + 2 * 60 + 3, 1) +
olive::core::rational(12, 24));
EXPECT_EQ(parsed.time, olive::core::Rational(1 * 3600 + 2 * 60 + 3, 1) +
olive::core::Rational(12, 24));
}
TEST(TimecodeMetadata, ParsesDropFrameTimecode)
{
const olive::TimecodeMetadata::SourceTime parsed =
olive::TimecodeMetadata::FromTimecodeString(
QStringLiteral("00:01:00;02"), olive::core::rational(1001, 30000));
olive::TimecodeMetadata::from_timecode_string(
QStringLiteral("00:01:00;02"), olive::core::Rational(1001, 30000));
ASSERT_TRUE(parsed.valid);
EXPECT_EQ(parsed.source, QStringLiteral("timecode"));
EXPECT_GT(parsed.time, olive::core::rational(59));
EXPECT_LT(parsed.time, olive::core::rational(61));
EXPECT_GT(parsed.time, olive::core::Rational(59));
EXPECT_LT(parsed.time, olive::core::Rational(61));
}
TEST(TimecodeMetadata, ParsesBwfTimeReference)
{
const olive::TimecodeMetadata::SourceTime parsed =
olive::TimecodeMetadata::FromBwfTimeReference(QStringLiteral("96000"),
olive::TimecodeMetadata::from_bwf_time_reference(QStringLiteral("96000"),
48000);
ASSERT_TRUE(parsed.valid);
EXPECT_EQ(parsed.source, QStringLiteral("bwf_time_reference"));
EXPECT_EQ(parsed.time, olive::core::rational(2));
EXPECT_EQ(parsed.time, olive::core::Rational(2));
}
TEST(TimecodeMetadata, ParsesLargeBwfTimeReferenceWithoutTruncation)
{
const olive::TimecodeMetadata::SourceTime parsed =
olive::TimecodeMetadata::FromBwfTimeReference(
olive::TimecodeMetadata::from_bwf_time_reference(
QStringLiteral("4294967296"), 48000);
ASSERT_TRUE(parsed.valid);
EXPECT_GT(parsed.time, olive::core::rational(89478));
EXPECT_LT(parsed.time, olive::core::rational(89479));
EXPECT_GT(parsed.time, olive::core::Rational(89478));
EXPECT_LT(parsed.time, olive::core::Rational(89479));
}
TEST(TimecodeMetadata, RejectsInvalidMetadata)
{
EXPECT_FALSE(olive::TimecodeMetadata::FromTimecodeString(
QString(), olive::core::rational(1, 24))
EXPECT_FALSE(olive::TimecodeMetadata::from_timecode_string(
QString(), olive::core::Rational(1, 24))
.valid);
EXPECT_FALSE(olive::TimecodeMetadata::FromBwfTimeReference(
EXPECT_FALSE(olive::TimecodeMetadata::from_bwf_time_reference(
QStringLiteral("not-a-number"), 48000)
.valid);
EXPECT_FALSE(
olive::TimecodeMetadata::FromBwfTimeReference(QStringLiteral("123"), 0)
olive::TimecodeMetadata::from_bwf_time_reference(QStringLiteral("123"), 0)
.valid);
EXPECT_FALSE(
olive::TimecodeMetadata::FromTimecodeString(
QStringLiteral("not-a-timecode"), olive::core::rational(1, 24))
olive::TimecodeMetadata::from_timecode_string(
QStringLiteral("not-a-timecode"), olive::core::Rational(1, 24))
.valid);
}
TEST(TimecodeMetadata, FromBwfTimeReferenceZeroSampleRateIsInvalid)
{
EXPECT_FALSE(
olive::TimecodeMetadata::FromBwfTimeReference(QStringLiteral("0"), 0)
olive::TimecodeMetadata::from_bwf_time_reference(QStringLiteral("0"), 0)
.valid);
}
TEST(TimecodeMetadata, FootageDescriptionWithoutSourceStartTime)
{
olive::FootageDescription desc(QStringLiteral("ffmpeg"));
EXPECT_FALSE(desc.HasSourceStartTime());
EXPECT_FALSE(desc.has_source_start_time());
}
TEST(TimecodeMetadata, FootageDescriptionCachesSourceStartTime)
@@ -93,14 +93,14 @@ TEST(TimecodeMetadata, FootageDescriptionCachesSourceStartTime)
QDir(dir.path()).filePath(QStringLiteral("footage-cache.xml"));
olive::FootageDescription desc(QStringLiteral("ffmpeg"));
desc.SetSourceStartTime(olive::core::rational(96000, 48000),
desc.set_source_start_time(olive::core::Rational(96000, 48000),
QStringLiteral("bwf_time_reference"));
ASSERT_TRUE(desc.Save(path));
ASSERT_TRUE(desc.save(path));
olive::FootageDescription loaded;
ASSERT_TRUE(loaded.Load(path));
ASSERT_TRUE(loaded.HasSourceStartTime());
EXPECT_EQ(loaded.source_start_time(), olive::core::rational(2));
ASSERT_TRUE(loaded.load(path));
ASSERT_TRUE(loaded.has_source_start_time());
EXPECT_EQ(loaded.source_start_time(), olive::core::Rational(2));
EXPECT_EQ(loaded.source_start_time_source(),
QStringLiteral("bwf_time_reference"));
}
@@ -124,37 +124,37 @@ TEST(TimecodeMetadata, FootagePersistsSourceStartTime)
ASSERT_EQ(reader.name(), QStringLiteral("custom"));
olive::Footage footage;
ASSERT_TRUE(footage.LoadCustom(&reader, nullptr));
ASSERT_TRUE(footage.HasSourceStartTime());
EXPECT_EQ(footage.source_start_time(), olive::core::rational(3600));
ASSERT_TRUE(footage.load_custom(&reader, nullptr));
ASSERT_TRUE(footage.has_source_start_time());
EXPECT_EQ(footage.source_start_time(), olive::core::Rational(3600));
EXPECT_EQ(footage.source_start_time_source(), QStringLiteral("timecode"));
}
TEST(TimecodeMetadata, FootageClearSourceStartTime)
{
olive::Footage footage;
footage.SetSourceStartTime(olive::core::rational(3600),
footage.set_source_start_time(olive::core::Rational(3600),
QStringLiteral("manual"));
ASSERT_TRUE(footage.HasSourceStartTime());
ASSERT_TRUE(footage.has_source_start_time());
footage.ClearSourceStartTime();
footage.clear_source_start_time();
EXPECT_FALSE(footage.HasSourceStartTime());
EXPECT_EQ(footage.source_start_time(), olive::core::rational());
EXPECT_FALSE(footage.has_source_start_time());
EXPECT_EQ(footage.source_start_time(), olive::core::Rational());
EXPECT_TRUE(footage.source_start_time_source().isEmpty());
}
TEST(TimecodeMetadata, FootageSetSourceStartTimeOverridesPreviousValue)
{
olive::Footage footage;
footage.SetSourceStartTime(olive::core::rational(3600),
footage.set_source_start_time(olive::core::Rational(3600),
QStringLiteral("timecode"));
// A manual edit replaces both the value and the recorded source
footage.SetSourceStartTime(olive::core::rational(1800),
footage.set_source_start_time(olive::core::Rational(1800),
QStringLiteral("manual"));
EXPECT_TRUE(footage.HasSourceStartTime());
EXPECT_EQ(footage.source_start_time(), olive::core::rational(1800));
EXPECT_TRUE(footage.has_source_start_time());
EXPECT_EQ(footage.source_start_time(), olive::core::Rational(1800));
EXPECT_EQ(footage.source_start_time_source(), QStringLiteral("manual"));
}