oak-team/oak-editor
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

style: unify identifier naming per updated conventions

Browse Source 
Automated with clang-tidy readability-identifier-naming (config added to
.clang-tidy) plus scripted passes, per the updated rules now documented
in CONTRIBUTING.md:

- types (class/struct/enum/alias/template params): PascalCase
- functions, variables, members: snake_case (incl. rational -> Rational)
- private/protected members: trailing underscore; static member
  variables likewise (instance_, available_themes_)
- constants and enum values: snake_case (kLinear -> k_linear,
  F32P -> f32p); ALL_CAPS reserved for macros
- macros: OAK_ prefix (OLIVE_ADD_TEST/OLIVE_ASSERT/OLIVE_CONFIG ->
  OAK_ADD_TEST/OAK_ASSERT/OAK_CONFIG, GL_PREAMBLE -> OAK_GL_PREAMBLE,
  include guards -> OAK_*)
- file names: all lowercase (Current/Plugin/OliveHost/OliveClip/
  OlivePluginInstance -> current/plugin/olivehost/oliveclip/
  oliveplugininstance)
- getters share the member name sans underscore, setters set_foo()
- Qt and third-party (OpenFX) virtual overrides and framework callbacks
  keep their original names (exempt in .clang-tidy)

Manual follow-ups required where automation could not reach:
- string-based QMetaObject/SIGNAL/SLOT references updated to renamed
  methods (AddTask, CreatedFile, DeleteSpecificFile, moveSelectionUp, ...)
- macro bodies referencing renamed methods (OLIVE_CONFIG,
  NODE_DEFAULT_DESTRUCTOR, MANAGEDDISPLAYWIDGET_*)
- self-shadowing locals renamed where signals/methods became same-named
  (size_changed, worker_count, selected_items, import param, filters)
- third_party OFX member/namespace usages restored (OFX::Host::*,
  _created, _clipPrefsDirty, createInstance, clearPersistentMessage)
- STL protocol aliases restored (const_iterator) with .clang-tidy
  ignore rules; qHash overloads restored

Full build and test suite pass: ctest 4/4, ~1960 gtest cases green.
This commit is contained in:
Mike-Solar
2026-07-19 16:10:54 +08:00
parent cb1718a103
commit bb40b4923e
1014 changed files with 44257 additions and 44220 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/gtest/plugin_render_pipeline_test.cpp
+10 -10
View File
@@ -11,9 +11,9 @@ namespace
class PluginJobTraverser : public olive::NodeTraverser {
public:
void Resolve(olive::NodeValue &value)
void resolve(olive::NodeValue &value)
{
ResolveJobs(value);
resolve_jobs(value);
}
bool called() const
@@ -22,7 +22,7 @@ public:
}
protected:
olive::TexturePtr ProcessPluginJob(olive::TexturePtr /*texture*/,
olive::TexturePtr process_plugin_job(olive::TexturePtr /*texture*/,
olive::TexturePtr destination,
const olive::Node * /*node*/) override
{
@@ -38,18 +38,18 @@ private:
TEST(PluginRenderPipeline, PluginJobIsResolved)
{
olive::VideoParams params(320, 240, olive::core::PixelFormat::U8, 4);
olive::VideoParams params(320, 240, olive::core::PixelFormat::u8, 4);
olive::plugin::PluginJob job(nullptr, nullptr, olive::NodeValueRow());
olive::TexturePtr job_tex = olive::Texture::Job(params, job);
olive::TexturePtr job_tex = olive::Texture::job(params, job);
olive::NodeValue val(olive::NodeValue::kTexture, job_tex);
olive::NodeValue val(olive::NodeValue::k_texture, job_tex);
PluginJobTraverser traverser;
traverser.SetCacheVideoParams(params);
traverser.Resolve(val);
traverser.set_cache_video_params(params);
traverser.resolve(val);
EXPECT_TRUE(traverser.called());
ASSERT_TRUE(val.toTexture());
EXPECT_NE(val.toTexture().get(), job_tex.get());
ASSERT_TRUE(val.to_texture());
EXPECT_NE(val.to_texture().get(), job_tex.get());
}