oak-team/oak-editor
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

style: unify identifier naming per updated conventions

Browse Source 
Automated with clang-tidy readability-identifier-naming (config added to
.clang-tidy) plus scripted passes, per the updated rules now documented
in CONTRIBUTING.md:

- types (class/struct/enum/alias/template params): PascalCase
- functions, variables, members: snake_case (incl. rational -> Rational)
- private/protected members: trailing underscore; static member
  variables likewise (instance_, available_themes_)
- constants and enum values: snake_case (kLinear -> k_linear,
  F32P -> f32p); ALL_CAPS reserved for macros
- macros: OAK_ prefix (OLIVE_ADD_TEST/OLIVE_ASSERT/OLIVE_CONFIG ->
  OAK_ADD_TEST/OAK_ASSERT/OAK_CONFIG, GL_PREAMBLE -> OAK_GL_PREAMBLE,
  include guards -> OAK_*)
- file names: all lowercase (Current/Plugin/OliveHost/OliveClip/
  OlivePluginInstance -> current/plugin/olivehost/oliveclip/
  oliveplugininstance)
- getters share the member name sans underscore, setters set_foo()
- Qt and third-party (OpenFX) virtual overrides and framework callbacks
  keep their original names (exempt in .clang-tidy)

Manual follow-ups required where automation could not reach:
- string-based QMetaObject/SIGNAL/SLOT references updated to renamed
  methods (AddTask, CreatedFile, DeleteSpecificFile, moveSelectionUp, ...)
- macro bodies referencing renamed methods (OLIVE_CONFIG,
  NODE_DEFAULT_DESTRUCTOR, MANAGEDDISPLAYWIDGET_*)
- self-shadowing locals renamed where signals/methods became same-named
  (size_changed, worker_count, selected_items, import param, filters)
- third_party OFX member/namespace usages restored (OFX::Host::*,
  _created, _clipPrefsDirty, createInstance, clearPersistentMessage)
- STL protocol aliases restored (const_iterator) with .clang-tidy
  ignore rules; qHash overloads restored

Full build and test suite pass: ctest 4/4, ~1960 gtest cases green.
This commit is contained in:
Mike-Solar
2026-07-19 16:10:54 +08:00
parent cb1718a103
commit bb40b4923e
1014 changed files with 44257 additions and 44220 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/gtest/node_keyframe_test.cpp
+10 -10
View File
@@ -11,8 +11,8 @@ TEST(NodeKeyframe, SaveLoadRoundTrip)
{
olive::NodeKeyframe key;
key.set_input(QStringLiteral("Value"));
key.set_time(olive::core::rational(1, 24));
key.set_type(olive::NodeKeyframe::kLinear);
key.set_time(olive::core::Rational(1, 24));
key.set_type(olive::NodeKeyframe::k_linear);
key.set_value(42.0);
key.set_bezier_control_in(QPointF(0.1, 0.2));
key.set_bezier_control_out(QPointF(0.3, 0.4));
@@ -23,7 +23,7 @@ TEST(NodeKeyframe, SaveLoadRoundTrip)
QXmlStreamWriter writer(&buffer);
writer.writeStartDocument();
writer.writeStartElement(QStringLiteral("key"));
key.save(&writer, olive::NodeValue::kFloat);
key.save(&writer, olive::NodeValue::k_float);
writer.writeEndElement();
writer.writeEndDocument();
buffer.close();
@@ -35,10 +35,10 @@ TEST(NodeKeyframe, SaveLoadRoundTrip)
EXPECT_EQ(reader.name().toString(), QStringLiteral("key"));
olive::NodeKeyframe loaded;
EXPECT_TRUE(loaded.load(&reader, olive::NodeValue::kFloat));
EXPECT_TRUE(loaded.load(&reader, olive::NodeValue::k_float));
EXPECT_EQ(loaded.input(), QStringLiteral("Value"));
EXPECT_EQ(loaded.time(), olive::core::rational(1, 24));
EXPECT_EQ(loaded.type(), olive::NodeKeyframe::kLinear);
EXPECT_EQ(loaded.time(), olive::core::Rational(1, 24));
EXPECT_EQ(loaded.type(), olive::NodeKeyframe::k_linear);
EXPECT_DOUBLE_EQ(loaded.value().toDouble(), 42.0);
EXPECT_DOUBLE_EQ(loaded.bezier_control_in().x(), 0.1);
EXPECT_DOUBLE_EQ(loaded.bezier_control_in().y(), 0.2);
@@ -50,16 +50,16 @@ TEST(NodeKeyframe, TypeEnumeration)
{
using olive::NodeKeyframe;
EXPECT_NE(NodeKeyframe::kLinear, NodeKeyframe::kHold);
EXPECT_NE(NodeKeyframe::kLinear, NodeKeyframe::kBezier);
EXPECT_NE(NodeKeyframe::k_linear, NodeKeyframe::k_hold);
EXPECT_NE(NodeKeyframe::k_linear, NodeKeyframe::k_bezier);
}
TEST(NodeKeyframe, DefaultState)
{
olive::NodeKeyframe key;
EXPECT_TRUE(key.input().isEmpty());
EXPECT_EQ(key.time(), olive::core::rational(0, 1));
EXPECT_EQ(key.type(), olive::NodeKeyframe::kLinear);
EXPECT_EQ(key.time(), olive::core::Rational(0, 1));
EXPECT_EQ(key.type(), olive::NodeKeyframe::k_linear);
EXPECT_TRUE(key.value().isNull());
}