oak-team/oak-editor
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

style: unify identifier naming per updated conventions

Browse Source 
Automated with clang-tidy readability-identifier-naming (config added to
.clang-tidy) plus scripted passes, per the updated rules now documented
in CONTRIBUTING.md:

- types (class/struct/enum/alias/template params): PascalCase
- functions, variables, members: snake_case (incl. rational -> Rational)
- private/protected members: trailing underscore; static member
  variables likewise (instance_, available_themes_)
- constants and enum values: snake_case (kLinear -> k_linear,
  F32P -> f32p); ALL_CAPS reserved for macros
- macros: OAK_ prefix (OLIVE_ADD_TEST/OLIVE_ASSERT/OLIVE_CONFIG ->
  OAK_ADD_TEST/OAK_ASSERT/OAK_CONFIG, GL_PREAMBLE -> OAK_GL_PREAMBLE,
  include guards -> OAK_*)
- file names: all lowercase (Current/Plugin/OliveHost/OliveClip/
  OlivePluginInstance -> current/plugin/olivehost/oliveclip/
  oliveplugininstance)
- getters share the member name sans underscore, setters set_foo()
- Qt and third-party (OpenFX) virtual overrides and framework callbacks
  keep their original names (exempt in .clang-tidy)

Manual follow-ups required where automation could not reach:
- string-based QMetaObject/SIGNAL/SLOT references updated to renamed
  methods (AddTask, CreatedFile, DeleteSpecificFile, moveSelectionUp, ...)
- macro bodies referencing renamed methods (OLIVE_CONFIG,
  NODE_DEFAULT_DESTRUCTOR, MANAGEDDISPLAYWIDGET_*)
- self-shadowing locals renamed where signals/methods became same-named
  (size_changed, worker_count, selected_items, import param, filters)
- third_party OFX member/namespace usages restored (OFX::Host::*,
  _created, _clipPrefsDirty, createInstance, clearPersistentMessage)
- STL protocol aliases restored (const_iterator) with .clang-tidy
  ignore rules; qHash overloads restored

Full build and test suite pass: ctest 4/4, ~1960 gtest cases green.
This commit is contained in:
Mike-Solar
2026-07-19 16:10:54 +08:00
parent cb1718a103
commit bb40b4923e
1014 changed files with 44257 additions and 44220 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/gtest/ffmpeg_decoder_hw_test.cpp
+8 -8
View File
@@ -23,20 +23,20 @@ TEST(FFmpegDecoderHW, H264_422_10bit_CPUFrame_IsNotBlack)
GTEST_SKIP() << "Test footage not available: " << path.toStdString();
}
DecoderPtr decoder = Decoder::CreateFromID(QStringLiteral("ffmpeg"));
DecoderPtr decoder = Decoder::create_from_id(QStringLiteral("ffmpeg"));
ASSERT_TRUE(decoder);
Footage footage(path);
ASSERT_TRUE(footage.IsValid());
ASSERT_TRUE(footage.is_valid());
Decoder::CodecStream stream(path, footage.GetStreamIndex(Track::kVideo, 0),
Decoder::CodecStream stream(path, footage.get_stream_index(Track::k_video, 0),
nullptr);
ASSERT_TRUE(decoder->Open(stream));
ASSERT_TRUE(decoder->open(stream));
Decoder::RetrieveVideoParams params;
params.time = rational(0);
params.maximum_format = PixelFormat::U16;
FramePtr frame = decoder->RetrieveVideoFrame(params);
params.time = Rational(0);
params.maximum_format = PixelFormat::u16;
FramePtr frame = decoder->retrieve_video_frame(params);
ASSERT_TRUE(frame);
ASSERT_TRUE(frame->is_allocated());
@@ -47,7 +47,7 @@ TEST(FFmpegDecoderHW, H264_422_10bit_CPUFrame_IsNotBlack)
double avg = 0.0;
int samples = 0;
const int bpc = VideoParams::GetBytesPerChannel(frame->format());
const int bpc = VideoParams::get_bytes_per_channel(frame->format());
const int stride = frame->linesize_bytes();
for (int y = 0; y < height && y < 1080; y += 120) {
for (int x = 0; x < width && x < 1920; x += 240) {