oak-team/oak-editor
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

style: unify identifier naming per updated conventions

Browse Source 
Automated with clang-tidy readability-identifier-naming (config added to
.clang-tidy) plus scripted passes, per the updated rules now documented
in CONTRIBUTING.md:

- types (class/struct/enum/alias/template params): PascalCase
- functions, variables, members: snake_case (incl. rational -> Rational)
- private/protected members: trailing underscore; static member
  variables likewise (instance_, available_themes_)
- constants and enum values: snake_case (kLinear -> k_linear,
  F32P -> f32p); ALL_CAPS reserved for macros
- macros: OAK_ prefix (OLIVE_ADD_TEST/OLIVE_ASSERT/OLIVE_CONFIG ->
  OAK_ADD_TEST/OAK_ASSERT/OAK_CONFIG, GL_PREAMBLE -> OAK_GL_PREAMBLE,
  include guards -> OAK_*)
- file names: all lowercase (Current/Plugin/OliveHost/OliveClip/
  OlivePluginInstance -> current/plugin/olivehost/oliveclip/
  oliveplugininstance)
- getters share the member name sans underscore, setters set_foo()
- Qt and third-party (OpenFX) virtual overrides and framework callbacks
  keep their original names (exempt in .clang-tidy)

Manual follow-ups required where automation could not reach:
- string-based QMetaObject/SIGNAL/SLOT references updated to renamed
  methods (AddTask, CreatedFile, DeleteSpecificFile, moveSelectionUp, ...)
- macro bodies referencing renamed methods (OLIVE_CONFIG,
  NODE_DEFAULT_DESTRUCTOR, MANAGEDDISPLAYWIDGET_*)
- self-shadowing locals renamed where signals/methods became same-named
  (size_changed, worker_count, selected_items, import param, filters)
- third_party OFX member/namespace usages restored (OFX::Host::*,
  _created, _clipPrefsDirty, createInstance, clearPersistentMessage)
- STL protocol aliases restored (const_iterator) with .clang-tidy
  ignore rules; qHash overloads restored

Full build and test suite pass: ctest 4/4, ~1960 gtest cases green.
This commit is contained in:
Mike-Solar
2026-07-19 16:10:54 +08:00
parent cb1718a103
commit bb40b4923e
1014 changed files with 44257 additions and 44220 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/gtest/core_rational_test.cpp
+45 -45
View File
@@ -10,35 +10,35 @@ using namespace olive::core;
TEST(CoreRational, DefaultConstruction)
{
rational r;
Rational r;
EXPECT_EQ(r.numerator(), 0);
EXPECT_EQ(r.denominator(), 1);
}
TEST(CoreRational, IntegerConstruction)
{
rational r(5);
Rational r(5);
EXPECT_EQ(r.numerator(), 5);
EXPECT_EQ(r.denominator(), 1);
}
TEST(CoreRational, FractionConstructionReduces)
{
rational r(4, 8);
Rational r(4, 8);
EXPECT_EQ(r.numerator(), 1);
EXPECT_EQ(r.denominator(), 2);
}
TEST(CoreRational, NegativeDenominatorNormalizes)
{
rational r(1, -2);
Rational r(1, -2);
EXPECT_EQ(r.numerator(), -1);
EXPECT_EQ(r.denominator(), 2);
}
TEST(CoreRational, ZeroNormalizes)
{
rational r(0, 5);
Rational r(0, 5);
EXPECT_EQ(r.numerator(), 0);
EXPECT_EQ(r.denominator(), 1);
}
@@ -46,11 +46,11 @@ TEST(CoreRational, ZeroNormalizes)
TEST(CoreRational, FromDouble)
{
bool ok = false;
rational r = rational::fromDouble(0.5, &ok);
Rational r = Rational::from_double(0.5, &ok);
EXPECT_TRUE(ok);
EXPECT_EQ(r, rational(1, 2));
EXPECT_EQ(r, Rational(1, 2));
r = rational::fromDouble(std::numeric_limits<double>::quiet_NaN(), &ok);
r = Rational::from_double(std::numeric_limits<double>::quiet_NaN(), &ok);
EXPECT_FALSE(ok);
EXPECT_TRUE(r.isNaN());
}
@@ -58,56 +58,56 @@ TEST(CoreRational, FromDouble)
TEST(CoreRational, FromString)
{
bool ok = false;
rational r = rational::fromString("3/4", &ok);
Rational r = Rational::from_string("3/4", &ok);
EXPECT_TRUE(ok);
EXPECT_EQ(r, rational(3, 4));
EXPECT_EQ(r, Rational(3, 4));
r = rational::fromString("42", &ok);
r = Rational::from_string("42", &ok);
EXPECT_TRUE(ok);
EXPECT_EQ(r, rational(42));
EXPECT_EQ(r, Rational(42));
r = rational::fromString("1/2/3", &ok);
r = Rational::from_string("1/2/3", &ok);
EXPECT_FALSE(ok);
EXPECT_TRUE(r.isNaN());
}
TEST(CoreRational, ToDouble)
{
EXPECT_DOUBLE_EQ(rational(1, 2).toDouble(), 0.5);
EXPECT_TRUE(std::isnan(rational::NaN.toDouble()));
EXPECT_DOUBLE_EQ(Rational(1, 2).to_double(), 0.5);
EXPECT_TRUE(std::isnan(Rational::na_n.to_double()));
}
TEST(CoreRational, ToString)
{
EXPECT_EQ(rational(1, 2).toString(), "1/2");
EXPECT_EQ(Rational(1, 2).to_string(), "1/2");
}
TEST(CoreRational, Arithmetic)
{
rational a(1, 2);
rational b(1, 3);
Rational a(1, 2);
Rational b(1, 3);
EXPECT_EQ(a + b, rational(5, 6));
EXPECT_EQ(a - b, rational(1, 6));
EXPECT_EQ(a * b, rational(1, 6));
EXPECT_EQ(a / b, rational(3, 2));
EXPECT_EQ(a + b, Rational(5, 6));
EXPECT_EQ(a - b, Rational(1, 6));
EXPECT_EQ(a * b, Rational(1, 6));
EXPECT_EQ(a / b, Rational(3, 2));
}
TEST(CoreRational, CompoundAssignment)
{
rational a(1, 2);
a += rational(1, 4);
EXPECT_EQ(a, rational(3, 4));
Rational a(1, 2);
a += Rational(1, 4);
EXPECT_EQ(a, Rational(3, 4));
a *= rational(2, 3);
EXPECT_EQ(a, rational(1, 2));
a *= Rational(2, 3);
EXPECT_EQ(a, Rational(1, 2));
}
TEST(CoreRational, Comparisons)
{
rational a(1, 2);
rational b(2, 4);
rational c(1, 3);
Rational a(1, 2);
Rational b(2, 4);
Rational c(1, 3);
EXPECT_TRUE(a == b);
EXPECT_FALSE(a != b);
@@ -119,46 +119,46 @@ TEST(CoreRational, Comparisons)
TEST(CoreRational, UnaryOperators)
{
rational a(1, 2);
Rational a(1, 2);
EXPECT_EQ(+a, a);
EXPECT_EQ(-a, rational(-1, 2));
EXPECT_EQ(-a, Rational(-1, 2));
EXPECT_FALSE(!a);
rational zero(0);
Rational zero(0);
EXPECT_TRUE(!zero);
}
TEST(CoreRational, Flip)
{
rational a(2, 3);
Rational a(2, 3);
a.flip();
EXPECT_EQ(a, rational(3, 2));
EXPECT_EQ(a, Rational(3, 2));
rational zero(0);
Rational zero(0);
zero.flip();
EXPECT_EQ(zero, rational(0));
EXPECT_EQ(zero, Rational(0));
}
TEST(CoreRational, Flipped)
{
EXPECT_EQ(rational(2, 3).flipped(), rational(3, 2));
EXPECT_EQ(Rational(2, 3).flipped(), Rational(3, 2));
}
TEST(CoreRational, IsNullAndIsNaN)
{
rational zero(0);
Rational zero(0);
EXPECT_TRUE(zero.isNull());
EXPECT_FALSE(zero.isNaN());
rational nan = rational::NaN;
Rational nan = Rational::na_n;
EXPECT_TRUE(nan.isNaN());
EXPECT_TRUE(nan.isNull());
}
TEST(CoreRational, NaNPropagation)
{
rational a(1, 2);
rational nan = rational::NaN;
Rational a(1, 2);
Rational nan = Rational::na_n;
a += nan;
EXPECT_TRUE(a.isNaN());
@@ -167,12 +167,12 @@ TEST(CoreRational, NaNPropagation)
TEST(CoreRational, StreamOutput)
{
std::ostringstream oss;
oss << rational(3, 4);
oss << Rational(3, 4);
EXPECT_EQ(oss.str(), "3/4");
}
TEST(CoreRational, MinMaxConstants)
{
EXPECT_TRUE(RATIONAL_MIN < rational(0));
EXPECT_TRUE(RATIONAL_MAX > rational(0));
EXPECT_TRUE(RATIONAL_MIN < Rational(0));
EXPECT_TRUE(RATIONAL_MAX > Rational(0));
}