oak-team/oak-editor
3
1
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

style: unify identifier naming per updated conventions

Browse Source 
Automated with clang-tidy readability-identifier-naming (config added to
.clang-tidy) plus scripted passes, per the updated rules now documented
in CONTRIBUTING.md:

- types (class/struct/enum/alias/template params): PascalCase
- functions, variables, members: snake_case (incl. rational -> Rational)
- private/protected members: trailing underscore; static member
  variables likewise (instance_, available_themes_)
- constants and enum values: snake_case (kLinear -> k_linear,
  F32P -> f32p); ALL_CAPS reserved for macros
- macros: OAK_ prefix (OLIVE_ADD_TEST/OLIVE_ASSERT/OLIVE_CONFIG ->
  OAK_ADD_TEST/OAK_ASSERT/OAK_CONFIG, GL_PREAMBLE -> OAK_GL_PREAMBLE,
  include guards -> OAK_*)
- file names: all lowercase (Current/Plugin/OliveHost/OliveClip/
  OlivePluginInstance -> current/plugin/olivehost/oliveclip/
  oliveplugininstance)
- getters share the member name sans underscore, setters set_foo()
- Qt and third-party (OpenFX) virtual overrides and framework callbacks
  keep their original names (exempt in .clang-tidy)

Manual follow-ups required where automation could not reach:
- string-based QMetaObject/SIGNAL/SLOT references updated to renamed
  methods (AddTask, CreatedFile, DeleteSpecificFile, moveSelectionUp, ...)
- macro bodies referencing renamed methods (OLIVE_CONFIG,
  NODE_DEFAULT_DESTRUCTOR, MANAGEDDISPLAYWIDGET_*)
- self-shadowing locals renamed where signals/methods became same-named
  (size_changed, worker_count, selected_items, import param, filters)
- third_party OFX member/namespace usages restored (OFX::Host::*,
  _created, _clipPrefsDirty, createInstance, clearPersistentMessage)
- STL protocol aliases restored (const_iterator) with .clang-tidy
  ignore rules; qHash overloads restored

Full build and test suite pass: ctest 4/4, ~1960 gtest cases green.
This commit is contained in:
Mike-Solar
2026-07-19 16:10:54 +08:00
parent cb1718a103
commit bb40b4923e
1014 changed files with 44257 additions and 44220 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/gtest/core_bezier_test.cpp
+11 -11
View File
@@ -53,21 +53,21 @@ TEST(CoreBezier, Setters)
TEST(CoreBezier, QuadraticXtoT)
{
double t = Bezier::QuadraticXtoT(0.5, 0.0, 0.5, 1.0);
double t = Bezier::quadratic_xto_t(0.5, 0.0, 0.5, 1.0);
EXPECT_NEAR(t, 0.5, 0.00001);
t = Bezier::QuadraticXtoT(0.0, 0.0, 0.5, 1.0);
t = Bezier::quadratic_xto_t(0.0, 0.0, 0.5, 1.0);
EXPECT_NEAR(t, 0.0, 0.00001);
t = Bezier::QuadraticXtoT(1.0, 0.0, 0.5, 1.0);
t = Bezier::quadratic_xto_t(1.0, 0.0, 0.5, 1.0);
EXPECT_NEAR(t, 1.0, 0.00001);
}
TEST(CoreBezier, QuadraticTtoY)
{
EXPECT_NEAR(Bezier::QuadraticTtoY(0.0, 0.5, 1.0, 0.0), 0.0, 0.00001);
EXPECT_NEAR(Bezier::QuadraticTtoY(0.0, 0.5, 1.0, 0.5), 0.5, 0.00001);
EXPECT_NEAR(Bezier::QuadraticTtoY(0.0, 0.5, 1.0, 1.0), 1.0, 0.00001);
EXPECT_NEAR(Bezier::quadratic_tto_y(0.0, 0.5, 1.0, 0.0), 0.0, 0.00001);
EXPECT_NEAR(Bezier::quadratic_tto_y(0.0, 0.5, 1.0, 0.5), 0.5, 0.00001);
EXPECT_NEAR(Bezier::quadratic_tto_y(0.0, 0.5, 1.0, 1.0), 1.0, 0.00001);
}
TEST(CoreBezier, QuadraticXtoY)
@@ -76,7 +76,7 @@ TEST(CoreBezier, QuadraticXtoY)
Imath::V2d b(0.5, 0.5);
Imath::V2d c(1.0, 1.0);
EXPECT_NEAR(Bezier::QuadraticXtoY(0.5, a, b, c), 0.5, 0.00001);
EXPECT_NEAR(Bezier::quadratic_xto_y(0.5, a, b, c), 0.5, 0.00001);
}
TEST(CoreBezier, CubicXtoT)
@@ -86,14 +86,14 @@ TEST(CoreBezier, CubicXtoT)
// and x(t) = 0.5 is solved by t = 0.5037592 (Newton-Raphson). The
// implementation bisects until |x(t) - x| < 1e-6 and dx/dt >= 0.99 on
// [0,1], so the returned t is well within 1e-5 of the true root.
double t = Bezier::CubicXtoT(0.5, 0.0, 0.33, 0.66, 1.0);
double t = Bezier::cubic_xto_t(0.5, 0.0, 0.33, 0.66, 1.0);
EXPECT_NEAR(t, 0.5037592, 1e-5);
}
TEST(CoreBezier, CubicTtoY)
{
EXPECT_NEAR(Bezier::CubicTtoY(0.0, 0.33, 0.66, 1.0, 0.0), 0.0, 0.00001);
EXPECT_NEAR(Bezier::CubicTtoY(0.0, 0.33, 0.66, 1.0, 1.0), 1.0, 0.00001);
EXPECT_NEAR(Bezier::cubic_tto_y(0.0, 0.33, 0.66, 1.0, 0.0), 0.0, 0.00001);
EXPECT_NEAR(Bezier::cubic_tto_y(0.0, 0.33, 0.66, 1.0, 1.0), 1.0, 0.00001);
}
TEST(CoreBezier, CubicXtoY)
@@ -108,7 +108,7 @@ TEST(CoreBezier, CubicXtoY)
// the y curve is y(t) = 3(1-t)t^2 + t^3 = 3t^2 - 2t^3, which then yields
// y = 0.5056392. The implementation's 1e-6 bisection tolerance in x is
// amplified by dy/dt < 1.5, keeping the y error well under 1e-5.
double y = Bezier::CubicXtoY(0.5, a, b, c, d);
double y = Bezier::cubic_xto_y(0.5, a, b, c, d);
EXPECT_NEAR(y, 0.5056392, 1e-5);
}