oak-team/oak-editor
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

style: unify identifier naming per updated conventions

Browse Source 
Automated with clang-tidy readability-identifier-naming (config added to
.clang-tidy) plus scripted passes, per the updated rules now documented
in CONTRIBUTING.md:

- types (class/struct/enum/alias/template params): PascalCase
- functions, variables, members: snake_case (incl. rational -> Rational)
- private/protected members: trailing underscore; static member
  variables likewise (instance_, available_themes_)
- constants and enum values: snake_case (kLinear -> k_linear,
  F32P -> f32p); ALL_CAPS reserved for macros
- macros: OAK_ prefix (OLIVE_ADD_TEST/OLIVE_ASSERT/OLIVE_CONFIG ->
  OAK_ADD_TEST/OAK_ASSERT/OAK_CONFIG, GL_PREAMBLE -> OAK_GL_PREAMBLE,
  include guards -> OAK_*)
- file names: all lowercase (Current/Plugin/OliveHost/OliveClip/
  OlivePluginInstance -> current/plugin/olivehost/oliveclip/
  oliveplugininstance)
- getters share the member name sans underscore, setters set_foo()
- Qt and third-party (OpenFX) virtual overrides and framework callbacks
  keep their original names (exempt in .clang-tidy)

Manual follow-ups required where automation could not reach:
- string-based QMetaObject/SIGNAL/SLOT references updated to renamed
  methods (AddTask, CreatedFile, DeleteSpecificFile, moveSelectionUp, ...)
- macro bodies referencing renamed methods (OLIVE_CONFIG,
  NODE_DEFAULT_DESTRUCTOR, MANAGEDDISPLAYWIDGET_*)
- self-shadowing locals renamed where signals/methods became same-named
  (size_changed, worker_count, selected_items, import param, filters)
- third_party OFX member/namespace usages restored (OFX::Host::*,
  _created, _clipPrefsDirty, createInstance, clearPersistentMessage)
- STL protocol aliases restored (const_iterator) with .clang-tidy
  ignore rules; qHash overloads restored

Full build and test suite pass: ctest 4/4, ~1960 gtest cases green.
This commit is contained in:
Mike-Solar
2026-07-19 16:10:54 +08:00
parent cb1718a103
commit bb40b4923e
1014 changed files with 44257 additions and 44220 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/gtest/common_ratiodialog_test.cpp
+9 -9
View File
@@ -22,12 +22,12 @@ public:
explicit DialogDriver(const QStringList &responses)
: responses_(responses)
{
connect(&timer_, &QTimer::timeout, this, &DialogDriver::Step);
connect(&timer_, &QTimer::timeout, this, &DialogDriver::step);
timer_.start(10);
}
private:
void Step()
void step()
{
QWidget *modal = QApplication::activeModalWidget();
if (!modal) {
@@ -67,7 +67,7 @@ TEST(CommonRatioDialog, AcceptsPlainDecimal)
DialogDriver driver({ QStringLiteral("1.5") });
bool ok = false;
const double ratio = GetFloatRatioFromUser(nullptr, QStringLiteral("Test"), &ok);
const double ratio = get_float_ratio_from_user(nullptr, QStringLiteral("Test"), &ok);
EXPECT_TRUE(ok);
EXPECT_DOUBLE_EQ(ratio, 1.5);
@@ -78,7 +78,7 @@ TEST(CommonRatioDialog, AcceptsColonSeparatedRatio)
DialogDriver driver({ QStringLiteral("16:9") });
bool ok = false;
const double ratio = GetFloatRatioFromUser(nullptr, QStringLiteral("Test"), &ok);
const double ratio = get_float_ratio_from_user(nullptr, QStringLiteral("Test"), &ok);
EXPECT_TRUE(ok);
EXPECT_DOUBLE_EQ(ratio, 16.0 / 9.0);
@@ -89,7 +89,7 @@ TEST(CommonRatioDialog, AcceptsSlashSeparatedRatio)
DialogDriver driver({ QStringLiteral("4/3") });
bool ok = false;
const double ratio = GetFloatRatioFromUser(nullptr, QStringLiteral("Test"), &ok);
const double ratio = get_float_ratio_from_user(nullptr, QStringLiteral("Test"), &ok);
EXPECT_TRUE(ok);
EXPECT_DOUBLE_EQ(ratio, 4.0 / 3.0);
@@ -100,7 +100,7 @@ TEST(CommonRatioDialog, AcceptsSemicolonSeparatedRatio)
DialogDriver driver({ QStringLiteral("1;2") });
bool ok = false;
const double ratio = GetFloatRatioFromUser(nullptr, QStringLiteral("Test"), &ok);
const double ratio = get_float_ratio_from_user(nullptr, QStringLiteral("Test"), &ok);
EXPECT_TRUE(ok);
EXPECT_DOUBLE_EQ(ratio, 0.5);
@@ -112,7 +112,7 @@ TEST(CommonRatioDialog, CancelReturnsNaN)
DialogDriver driver({});
bool ok = true;
const double ratio = GetFloatRatioFromUser(nullptr, QStringLiteral("Test"), &ok);
const double ratio = get_float_ratio_from_user(nullptr, QStringLiteral("Test"), &ok);
EXPECT_FALSE(ok);
EXPECT_TRUE(std::isnan(ratio));
@@ -125,7 +125,7 @@ TEST(CommonRatioDialog, InvalidInputWarnsAndRetries)
DialogDriver driver({ QStringLiteral("banana"), QStringLiteral("2") });
bool ok = false;
const double ratio = GetFloatRatioFromUser(nullptr, QStringLiteral("Test"), &ok);
const double ratio = get_float_ratio_from_user(nullptr, QStringLiteral("Test"), &ok);
EXPECT_TRUE(ok);
EXPECT_DOUBLE_EQ(ratio, 2.0);
@@ -139,7 +139,7 @@ TEST(CommonRatioDialog, RejectsNonPositiveValues)
{ QStringLiteral("0"), QStringLiteral("-4:2"), QStringLiteral("3") });
bool ok = false;
const double ratio = GetFloatRatioFromUser(nullptr, QStringLiteral("Test"), &ok);
const double ratio = get_float_ratio_from_user(nullptr, QStringLiteral("Test"), &ok);
EXPECT_TRUE(ok);
EXPECT_DOUBLE_EQ(ratio, 3.0);