oak-team/oak-editor
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

style: unify identifier naming per updated conventions

Browse Source 
Automated with clang-tidy readability-identifier-naming (config added to
.clang-tidy) plus scripted passes, per the updated rules now documented
in CONTRIBUTING.md:

- types (class/struct/enum/alias/template params): PascalCase
- functions, variables, members: snake_case (incl. rational -> Rational)
- private/protected members: trailing underscore; static member
  variables likewise (instance_, available_themes_)
- constants and enum values: snake_case (kLinear -> k_linear,
  F32P -> f32p); ALL_CAPS reserved for macros
- macros: OAK_ prefix (OLIVE_ADD_TEST/OLIVE_ASSERT/OLIVE_CONFIG ->
  OAK_ADD_TEST/OAK_ASSERT/OAK_CONFIG, GL_PREAMBLE -> OAK_GL_PREAMBLE,
  include guards -> OAK_*)
- file names: all lowercase (Current/Plugin/OliveHost/OliveClip/
  OlivePluginInstance -> current/plugin/olivehost/oliveclip/
  oliveplugininstance)
- getters share the member name sans underscore, setters set_foo()
- Qt and third-party (OpenFX) virtual overrides and framework callbacks
  keep their original names (exempt in .clang-tidy)

Manual follow-ups required where automation could not reach:
- string-based QMetaObject/SIGNAL/SLOT references updated to renamed
  methods (AddTask, CreatedFile, DeleteSpecificFile, moveSelectionUp, ...)
- macro bodies referencing renamed methods (OLIVE_CONFIG,
  NODE_DEFAULT_DESTRUCTOR, MANAGEDDISPLAYWIDGET_*)
- self-shadowing locals renamed where signals/methods became same-named
  (size_changed, worker_count, selected_items, import param, filters)
- third_party OFX member/namespace usages restored (OFX::Host::*,
  _created, _clipPrefsDirty, createInstance, clearPersistentMessage)
- STL protocol aliases restored (const_iterator) with .clang-tidy
  ignore rules; qHash overloads restored

Full build and test suite pass: ctest 4/4, ~1960 gtest cases green.
This commit is contained in:
Mike-Solar
2026-07-19 16:10:54 +08:00
parent cb1718a103
commit bb40b4923e
1014 changed files with 44257 additions and 44220 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/gtest/common_commandlineparser_test.cpp
+23 -23
View File
@@ -10,7 +10,7 @@ namespace
// Collects qDebug/qWarning/qCritical output for inspection
QStringList g_captured_messages;
void CaptureMessageHandler(QtMsgType, const QMessageLogContext &,
void capture_message_handler(QtMsgType, const QMessageLogContext &,
const QString &msg)
{
g_captured_messages.append(msg);
@@ -22,60 +22,60 @@ TEST(CommonCommandLineParser, OptionWithoutArgument)
{
CommandLineParser parser;
const CommandLineParser::Option *opt =
parser.AddOption({ QStringLiteral("help"), QStringLiteral("h") },
parser.add_option({ QStringLiteral("help"), QStringLiteral("h") },
QStringLiteral("Show help"), false);
parser.Process({ QStringLiteral("app"), QStringLiteral("-help") });
parser.process({ QStringLiteral("app"), QStringLiteral("-help") });
EXPECT_TRUE(opt->IsSet());
EXPECT_TRUE(opt->is_set());
}
TEST(CommonCommandLineParser, ShortOption)
{
CommandLineParser parser;
const CommandLineParser::Option *opt =
parser.AddOption({ QStringLiteral("help"), QStringLiteral("h") },
parser.add_option({ QStringLiteral("help"), QStringLiteral("h") },
QStringLiteral("Show help"), false);
parser.Process({ QStringLiteral("app"), QStringLiteral("-h") });
parser.process({ QStringLiteral("app"), QStringLiteral("-h") });
EXPECT_TRUE(opt->IsSet());
EXPECT_TRUE(opt->is_set());
}
TEST(CommonCommandLineParser, OptionWithArgument)
{
CommandLineParser parser;
const CommandLineParser::Option *opt = parser.AddOption(
const CommandLineParser::Option *opt = parser.add_option(
{ QStringLiteral("project") }, QStringLiteral("Project file"), true,
QStringLiteral("file"));
parser.Process({ QStringLiteral("app"), QStringLiteral("-project"),
parser.process({ QStringLiteral("app"), QStringLiteral("-project"),
QStringLiteral("test.ove") });
EXPECT_TRUE(opt->IsSet());
EXPECT_EQ(opt->GetSetting(), QStringLiteral("test.ove"));
EXPECT_TRUE(opt->is_set());
EXPECT_EQ(opt->get_setting(), QStringLiteral("test.ove"));
}
TEST(CommonCommandLineParser, PositionalArgument)
{
CommandLineParser parser;
const CommandLineParser::PositionalArgument *arg =
parser.AddPositionalArgument(QStringLiteral("filename"),
parser.add_positional_argument(QStringLiteral("filename"),
QStringLiteral("Project file"), true);
parser.Process({ QStringLiteral("app"), QStringLiteral("test.ove") });
parser.process({ QStringLiteral("app"), QStringLiteral("test.ove") });
EXPECT_EQ(arg->GetSetting(), QStringLiteral("test.ove"));
EXPECT_EQ(arg->get_setting(), QStringLiteral("test.ove"));
}
TEST(CommonCommandLineParser, UnknownOptionWarning)
{
CommandLineParser parser;
parser.AddOption({ QStringLiteral("known") }, QStringLiteral("Known"));
parser.add_option({ QStringLiteral("known") }, QStringLiteral("Known"));
g_captured_messages.clear();
QtMessageHandler old = qInstallMessageHandler(CaptureMessageHandler);
parser.Process({ QStringLiteral("app"), QStringLiteral("-unknown") });
QtMessageHandler old = qInstallMessageHandler(capture_message_handler);
parser.process({ QStringLiteral("app"), QStringLiteral("-unknown") });
qInstallMessageHandler(old);
// The warning must name the offending option
@@ -91,8 +91,8 @@ TEST(CommonCommandLineParser, UnknownPositionalWarning)
CommandLineParser parser;
g_captured_messages.clear();
QtMessageHandler old = qInstallMessageHandler(CaptureMessageHandler);
parser.Process({ QStringLiteral("app"), QStringLiteral("extra") });
QtMessageHandler old = qInstallMessageHandler(capture_message_handler);
parser.process({ QStringLiteral("app"), QStringLiteral("extra") });
qInstallMessageHandler(old);
// The warning must name the offending positional argument
@@ -106,15 +106,15 @@ TEST(CommonCommandLineParser, UnknownPositionalWarning)
TEST(CommonCommandLineParser, HiddenOptionExcludedFromHelp)
{
CommandLineParser parser;
parser.AddOption({ QStringLiteral("visible") }, QStringLiteral("Visible"));
parser.AddOption({ QStringLiteral("hidden") }, QStringLiteral("Hidden"),
parser.add_option({ QStringLiteral("visible") }, QStringLiteral("Visible"));
parser.add_option({ QStringLiteral("hidden") }, QStringLiteral("Hidden"),
false, QString(), true);
parser.AddPositionalArgument(QStringLiteral("file"),
parser.add_positional_argument(QStringLiteral("file"),
QStringLiteral("Input file"));
// PrintHelp writes to stdout via printf
testing::internal::CaptureStdout();
parser.PrintHelp("/usr/bin/app");
parser.print_help("/usr/bin/app");
std::string help = testing::internal::GetCapturedStdout();
// Visible option and positional argument must be listed