oak-team/oak-editor
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

style: unify identifier naming per updated conventions

Browse Source 
Automated with clang-tidy readability-identifier-naming (config added to
.clang-tidy) plus scripted passes, per the updated rules now documented
in CONTRIBUTING.md:

- types (class/struct/enum/alias/template params): PascalCase
- functions, variables, members: snake_case (incl. rational -> Rational)
- private/protected members: trailing underscore; static member
  variables likewise (instance_, available_themes_)
- constants and enum values: snake_case (kLinear -> k_linear,
  F32P -> f32p); ALL_CAPS reserved for macros
- macros: OAK_ prefix (OLIVE_ADD_TEST/OLIVE_ASSERT/OLIVE_CONFIG ->
  OAK_ADD_TEST/OAK_ASSERT/OAK_CONFIG, GL_PREAMBLE -> OAK_GL_PREAMBLE,
  include guards -> OAK_*)
- file names: all lowercase (Current/Plugin/OliveHost/OliveClip/
  OlivePluginInstance -> current/plugin/olivehost/oliveclip/
  oliveplugininstance)
- getters share the member name sans underscore, setters set_foo()
- Qt and third-party (OpenFX) virtual overrides and framework callbacks
  keep their original names (exempt in .clang-tidy)

Manual follow-ups required where automation could not reach:
- string-based QMetaObject/SIGNAL/SLOT references updated to renamed
  methods (AddTask, CreatedFile, DeleteSpecificFile, moveSelectionUp, ...)
- macro bodies referencing renamed methods (OLIVE_CONFIG,
  NODE_DEFAULT_DESTRUCTOR, MANAGEDDISPLAYWIDGET_*)
- self-shadowing locals renamed where signals/methods became same-named
  (size_changed, worker_count, selected_items, import param, filters)
- third_party OFX member/namespace usages restored (OFX::Host::*,
  _created, _clipPrefsDirty, createInstance, clearPersistentMessage)
- STL protocol aliases restored (const_iterator) with .clang-tidy
  ignore rules; qHash overloads restored

Full build and test suite pass: ctest 4/4, ~1960 gtest cases green.
This commit is contained in:
Mike-Solar
2026-07-19 16:10:54 +08:00
parent cb1718a103
commit bb40b4923e
1014 changed files with 44257 additions and 44220 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/gtest/codec_exportcodec_test.cpp
+17 -17
View File
@@ -6,26 +6,26 @@ TEST(CodecExportCodec, NamesAndFlags)
{
using olive::ExportCodec;
EXPECT_EQ(ExportCodec::GetCodecName(ExportCodec::kCodecH264),
EXPECT_EQ(ExportCodec::get_codec_name(ExportCodec::k_codec_h264),
QStringLiteral("H.264"));
EXPECT_EQ(ExportCodec::GetCodecName(ExportCodec::kCodecCount),
EXPECT_EQ(ExportCodec::get_codec_name(ExportCodec::k_codec_count),
QStringLiteral("Unknown"));
EXPECT_TRUE(ExportCodec::IsCodecAStillImage(ExportCodec::kCodecPNG));
EXPECT_FALSE(ExportCodec::IsCodecAStillImage(ExportCodec::kCodecH264));
EXPECT_TRUE(ExportCodec::is_codec_a_still_image(ExportCodec::k_codec_png));
EXPECT_FALSE(ExportCodec::is_codec_a_still_image(ExportCodec::k_codec_h264));
EXPECT_TRUE(ExportCodec::IsCodecLossless(ExportCodec::kCodecPCM));
EXPECT_TRUE(ExportCodec::IsCodecLossless(ExportCodec::kCodecFLAC));
EXPECT_FALSE(ExportCodec::IsCodecLossless(ExportCodec::kCodecH265));
EXPECT_TRUE(ExportCodec::is_codec_lossless(ExportCodec::k_codec_pcm));
EXPECT_TRUE(ExportCodec::is_codec_lossless(ExportCodec::k_codec_flac));
EXPECT_FALSE(ExportCodec::is_codec_lossless(ExportCodec::k_codec_h265));
}
TEST(CodecExportCodec, VideoCodecNamesAreNonEmpty)
{
using olive::ExportCodec;
for (int i = 0; i < ExportCodec::kCodecCount; ++i) {
for (int i = 0; i < ExportCodec::k_codec_count; ++i) {
const auto codec = static_cast<ExportCodec::Codec>(i);
const QString name = ExportCodec::GetCodecName(codec);
const QString name = ExportCodec::get_codec_name(codec);
EXPECT_FALSE(name.isEmpty()) << "Codec " << i;
}
}
@@ -34,18 +34,18 @@ TEST(CodecExportCodec, AudioCodecsAreNotStillImages)
{
using olive::ExportCodec;
EXPECT_FALSE(ExportCodec::IsCodecAStillImage(ExportCodec::kCodecPCM));
EXPECT_FALSE(ExportCodec::IsCodecAStillImage(ExportCodec::kCodecAAC));
EXPECT_FALSE(ExportCodec::IsCodecAStillImage(ExportCodec::kCodecFLAC));
EXPECT_FALSE(ExportCodec::IsCodecAStillImage(ExportCodec::kCodecOpus));
EXPECT_FALSE(ExportCodec::is_codec_a_still_image(ExportCodec::k_codec_pcm));
EXPECT_FALSE(ExportCodec::is_codec_a_still_image(ExportCodec::k_codec_aac));
EXPECT_FALSE(ExportCodec::is_codec_a_still_image(ExportCodec::k_codec_flac));
EXPECT_FALSE(ExportCodec::is_codec_a_still_image(ExportCodec::k_codec_opus));
}
TEST(CodecExportCodec, LossyCodecsAreNotLossless)
{
using olive::ExportCodec;
EXPECT_FALSE(ExportCodec::IsCodecLossless(ExportCodec::kCodecH264));
EXPECT_FALSE(ExportCodec::IsCodecLossless(ExportCodec::kCodecH265));
EXPECT_FALSE(ExportCodec::IsCodecLossless(ExportCodec::kCodecVP9));
EXPECT_FALSE(ExportCodec::IsCodecLossless(ExportCodec::kCodecAAC));
EXPECT_FALSE(ExportCodec::is_codec_lossless(ExportCodec::k_codec_h264));
EXPECT_FALSE(ExportCodec::is_codec_lossless(ExportCodec::k_codec_h265));
EXPECT_FALSE(ExportCodec::is_codec_lossless(ExportCodec::k_codec_v_p9));
EXPECT_FALSE(ExportCodec::is_codec_lossless(ExportCodec::k_codec_aac));
}