oak-team/oak-editor
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

style: unify identifier naming per updated conventions

Browse Source 
Automated with clang-tidy readability-identifier-naming (config added to
.clang-tidy) plus scripted passes, per the updated rules now documented
in CONTRIBUTING.md:

- types (class/struct/enum/alias/template params): PascalCase
- functions, variables, members: snake_case (incl. rational -> Rational)
- private/protected members: trailing underscore; static member
  variables likewise (instance_, available_themes_)
- constants and enum values: snake_case (kLinear -> k_linear,
  F32P -> f32p); ALL_CAPS reserved for macros
- macros: OAK_ prefix (OLIVE_ADD_TEST/OLIVE_ASSERT/OLIVE_CONFIG ->
  OAK_ADD_TEST/OAK_ASSERT/OAK_CONFIG, GL_PREAMBLE -> OAK_GL_PREAMBLE,
  include guards -> OAK_*)
- file names: all lowercase (Current/Plugin/OliveHost/OliveClip/
  OlivePluginInstance -> current/plugin/olivehost/oliveclip/
  oliveplugininstance)
- getters share the member name sans underscore, setters set_foo()
- Qt and third-party (OpenFX) virtual overrides and framework callbacks
  keep their original names (exempt in .clang-tidy)

Manual follow-ups required where automation could not reach:
- string-based QMetaObject/SIGNAL/SLOT references updated to renamed
  methods (AddTask, CreatedFile, DeleteSpecificFile, moveSelectionUp, ...)
- macro bodies referencing renamed methods (OLIVE_CONFIG,
  NODE_DEFAULT_DESTRUCTOR, MANAGEDDISPLAYWIDGET_*)
- self-shadowing locals renamed where signals/methods became same-named
  (size_changed, worker_count, selected_items, import param, filters)
- third_party OFX member/namespace usages restored (OFX::Host::*,
  _created, _clipPrefsDirty, createInstance, clearPersistentMessage)
- STL protocol aliases restored (const_iterator) with .clang-tidy
  ignore rules; qHash overloads restored

Full build and test suite pass: ctest 4/4, ~1960 gtest cases green.
This commit is contained in:
Mike-Solar
2026-07-19 16:10:54 +08:00
parent cb1718a103
commit bb40b4923e
1014 changed files with 44257 additions and 44220 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/gtest/cli_test.cpp
+11 -11
View File
@@ -12,14 +12,14 @@ public:
explicit DummyTask(bool succeed)
: succeed_(succeed)
{
SetTitle(QStringLiteral("Dummy"));
set_title(QStringLiteral("Dummy"));
}
protected:
virtual bool Run() override
virtual bool run() override
{
emit ProgressChanged(0.5);
emit ProgressChanged(1.0);
emit progress_changed(0.5);
emit progress_changed(1.0);
return succeed_;
}
@@ -47,7 +47,7 @@ TEST(CLIProgress, SameProgressValueDoesNotRedraw)
olive::CLIProgressDialog dlg(QStringLiteral("Job"));
testing::internal::CaptureStdout();
dlg.SetProgress(0.0);
dlg.set_progress(0.0);
const QString out =
QString::fromStdString(testing::internal::GetCapturedStdout());
@@ -59,7 +59,7 @@ TEST(CLIProgress, ProgressRendersPercentage)
olive::CLIProgressDialog dlg(QStringLiteral("Job"));
testing::internal::CaptureStdout();
dlg.SetProgress(0.25);
dlg.set_progress(0.25);
const QString out =
QString::fromStdString(testing::internal::GetCapturedStdout());
@@ -86,7 +86,7 @@ TEST(CLIProgress, BarFillMatchesProgress)
olive::CLIProgressDialog dlg(QStringLiteral("Job"));
testing::internal::CaptureStdout();
dlg.SetProgress(1.0);
dlg.set_progress(1.0);
const QString out =
QString::fromStdString(testing::internal::GetCapturedStdout());
@@ -100,7 +100,7 @@ TEST(CLIProgress, PercentageIsPaddedToThreeColumns)
auto pct_field = [&](double p) {
testing::internal::CaptureStdout();
dlg.SetProgress(p);
dlg.set_progress(p);
const QString out =
QString::fromStdString(testing::internal::GetCapturedStdout());
const int bracket = out.indexOf(QLatin1Char(']'));
@@ -124,7 +124,7 @@ TEST(CLITask, RunReturnsTaskResult)
olive::CLITaskDialog dlg(&task);
testing::internal::CaptureStdout();
const bool ok = dlg.Run();
const bool ok = dlg.run();
testing::internal::GetCapturedStdout();
EXPECT_TRUE(ok);
@@ -135,7 +135,7 @@ TEST(CLITask, RunReturnsTaskResult)
olive::CLITaskDialog dlg(&task);
testing::internal::CaptureStdout();
const bool ok = dlg.Run();
const bool ok = dlg.run();
testing::internal::GetCapturedStdout();
EXPECT_FALSE(ok);
@@ -148,7 +148,7 @@ TEST(CLITask, TaskProgressIsForwardedToDisplay)
olive::CLITaskDialog dlg(&task);
testing::internal::CaptureStdout();
dlg.Run();
dlg.run();
const QString out =
QString::fromStdString(testing::internal::GetCapturedStdout());