oak-team/oak-editor
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

style: unify identifier naming per updated conventions

Browse Source 
Automated with clang-tidy readability-identifier-naming (config added to
.clang-tidy) plus scripted passes, per the updated rules now documented
in CONTRIBUTING.md:

- types (class/struct/enum/alias/template params): PascalCase
- functions, variables, members: snake_case (incl. rational -> Rational)
- private/protected members: trailing underscore; static member
  variables likewise (instance_, available_themes_)
- constants and enum values: snake_case (kLinear -> k_linear,
  F32P -> f32p); ALL_CAPS reserved for macros
- macros: OAK_ prefix (OLIVE_ADD_TEST/OLIVE_ASSERT/OLIVE_CONFIG ->
  OAK_ADD_TEST/OAK_ASSERT/OAK_CONFIG, GL_PREAMBLE -> OAK_GL_PREAMBLE,
  include guards -> OAK_*)
- file names: all lowercase (Current/Plugin/OliveHost/OliveClip/
  OlivePluginInstance -> current/plugin/olivehost/oliveclip/
  oliveplugininstance)
- getters share the member name sans underscore, setters set_foo()
- Qt and third-party (OpenFX) virtual overrides and framework callbacks
  keep their original names (exempt in .clang-tidy)

Manual follow-ups required where automation could not reach:
- string-based QMetaObject/SIGNAL/SLOT references updated to renamed
  methods (AddTask, CreatedFile, DeleteSpecificFile, moveSelectionUp, ...)
- macro bodies referencing renamed methods (OLIVE_CONFIG,
  NODE_DEFAULT_DESTRUCTOR, MANAGEDDISPLAYWIDGET_*)
- self-shadowing locals renamed where signals/methods became same-named
  (size_changed, worker_count, selected_items, import param, filters)
- third_party OFX member/namespace usages restored (OFX::Host::*,
  _created, _clipPrefsDirty, createInstance, clearPersistentMessage)
- STL protocol aliases restored (const_iterator) with .clang-tidy
  ignore rules; qHash overloads restored

Full build and test suite pass: ctest 4/4, ~1960 gtest cases green.
This commit is contained in:
Mike-Solar
2026-07-19 16:10:54 +08:00
parent cb1718a103
commit bb40b4923e
1014 changed files with 44257 additions and 44220 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/gtest/audio_synchronizer_test.cpp
+21 -21
View File
@@ -5,52 +5,52 @@
TEST(AudioSynchronizer, PlacesCandidateBySourceStartTime)
{
olive::AudioSynchronizer::SourceClip reference;
reference.source_start_time = olive::core::rational(100);
reference.source_start_time = olive::core::Rational(100);
reference.has_source_start_time = true;
olive::AudioSynchronizer::SourceClip candidate;
candidate.source_start_time = olive::core::rational(112);
candidate.source_start_time = olive::core::Rational(112);
candidate.has_source_start_time = true;
const olive::AudioSynchronizer::Placement placement =
olive::AudioSynchronizer::PlaceBySourceTime(reference, candidate,
olive::core::rational(10));
olive::AudioSynchronizer::place_by_source_time(reference, candidate,
olive::core::Rational(10));
ASSERT_TRUE(placement.valid);
EXPECT_EQ(placement.timeline_in, olive::core::rational(22));
EXPECT_EQ(placement.timeline_in, olive::core::Rational(22));
}
TEST(AudioSynchronizer, AccountsForMediaInWhenPlacingBySourceTime)
{
olive::AudioSynchronizer::SourceClip reference;
reference.source_start_time = olive::core::rational(100);
reference.media_in = olive::core::rational(2);
reference.source_start_time = olive::core::Rational(100);
reference.media_in = olive::core::Rational(2);
reference.has_source_start_time = true;
olive::AudioSynchronizer::SourceClip candidate;
candidate.source_start_time = olive::core::rational(100);
candidate.media_in = olive::core::rational(5);
candidate.source_start_time = olive::core::Rational(100);
candidate.media_in = olive::core::Rational(5);
candidate.has_source_start_time = true;
const olive::AudioSynchronizer::Placement placement =
olive::AudioSynchronizer::PlaceBySourceTime(reference, candidate,
olive::core::rational(20));
olive::AudioSynchronizer::place_by_source_time(reference, candidate,
olive::core::Rational(20));
ASSERT_TRUE(placement.valid);
EXPECT_EQ(placement.timeline_in, olive::core::rational(23));
EXPECT_EQ(placement.timeline_in, olive::core::Rational(23));
}
TEST(AudioSynchronizer, RejectsMissingSourceStartTime)
{
olive::AudioSynchronizer::SourceClip reference;
reference.source_start_time = olive::core::rational(100);
reference.source_start_time = olive::core::Rational(100);
reference.has_source_start_time = true;
olive::AudioSynchronizer::SourceClip candidate;
const olive::AudioSynchronizer::Placement placement =
olive::AudioSynchronizer::PlaceBySourceTime(reference, candidate,
olive::core::rational(10));
olive::AudioSynchronizer::place_by_source_time(reference, candidate,
olive::core::Rational(10));
EXPECT_FALSE(placement.valid);
}
@@ -58,19 +58,19 @@ TEST(AudioSynchronizer, RejectsMissingSourceStartTime)
TEST(AudioSynchronizer, PlacesCandidateByWaveformOffset)
{
const olive::AudioSynchronizer::Placement placement =
olive::AudioSynchronizer::PlaceByWaveformOffset(
olive::core::rational(10), 24000, 48000);
olive::AudioSynchronizer::place_by_waveform_offset(
olive::core::Rational(10), 24000, 48000);
ASSERT_TRUE(placement.valid);
EXPECT_EQ(placement.timeline_in, olive::core::rational(21, 2));
EXPECT_EQ(placement.timeline_in, olive::core::Rational(21, 2));
}
TEST(AudioSynchronizer, SupportsCandidateLeadByWaveformOffset)
{
const olive::AudioSynchronizer::Placement placement =
olive::AudioSynchronizer::PlaceByWaveformOffset(
olive::core::rational(10), -48000, 48000);
olive::AudioSynchronizer::place_by_waveform_offset(
olive::core::Rational(10), -48000, 48000);
ASSERT_TRUE(placement.valid);
EXPECT_EQ(placement.timeline_in, olive::core::rational(9));
EXPECT_EQ(placement.timeline_in, olive::core::Rational(9));
}