oak-team/oak-editor
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

style: unify identifier naming per updated conventions

Browse Source 
Automated with clang-tidy readability-identifier-naming (config added to
.clang-tidy) plus scripted passes, per the updated rules now documented
in CONTRIBUTING.md:

- types (class/struct/enum/alias/template params): PascalCase
- functions, variables, members: snake_case (incl. rational -> Rational)
- private/protected members: trailing underscore; static member
  variables likewise (instance_, available_themes_)
- constants and enum values: snake_case (kLinear -> k_linear,
  F32P -> f32p); ALL_CAPS reserved for macros
- macros: OAK_ prefix (OLIVE_ADD_TEST/OLIVE_ASSERT/OLIVE_CONFIG ->
  OAK_ADD_TEST/OAK_ASSERT/OAK_CONFIG, GL_PREAMBLE -> OAK_GL_PREAMBLE,
  include guards -> OAK_*)
- file names: all lowercase (Current/Plugin/OliveHost/OliveClip/
  OlivePluginInstance -> current/plugin/olivehost/oliveclip/
  oliveplugininstance)
- getters share the member name sans underscore, setters set_foo()
- Qt and third-party (OpenFX) virtual overrides and framework callbacks
  keep their original names (exempt in .clang-tidy)

Manual follow-ups required where automation could not reach:
- string-based QMetaObject/SIGNAL/SLOT references updated to renamed
  methods (AddTask, CreatedFile, DeleteSpecificFile, moveSelectionUp, ...)
- macro bodies referencing renamed methods (OLIVE_CONFIG,
  NODE_DEFAULT_DESTRUCTOR, MANAGEDDISPLAYWIDGET_*)
- self-shadowing locals renamed where signals/methods became same-named
  (size_changed, worker_count, selected_items, import param, filters)
- third_party OFX member/namespace usages restored (OFX::Host::*,
  _created, _clipPrefsDirty, createInstance, clearPersistentMessage)
- STL protocol aliases restored (const_iterator) with .clang-tidy
  ignore rules; qHash overloads restored

Full build and test suite pass: ctest 4/4, ~1960 gtest cases green.
This commit is contained in:
Mike-Solar
2026-07-19 16:10:54 +08:00
parent cb1718a103
commit bb40b4923e
1014 changed files with 44257 additions and 44220 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/general/common-tests.cpp
+21 -21
View File
@@ -1,8 +1,8 @@
/***
Olive - Non-Linear Video Editor
Copyright (C) 2022 Olive Team
Modifications Copyright (C) 2025 mikesolar
Olive - Non-Linear video Editor
Copyright (c) 2022 Olive Team
Modifications Copyright (c) 2025 mikesolar
This program is free software: you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
@@ -26,26 +26,26 @@
namespace olive
{
OLIVE_ADD_TEST(DigitTest)
OAK_ADD_TEST(DigitTest)
{
OLIVE_ASSERT(GetDigitCount(1) == 1);
OLIVE_ASSERT(GetDigitCount(69) == 2);
OLIVE_ASSERT(GetDigitCount(420) == 3);
OLIVE_ASSERT(GetDigitCount(1337) == 4);
OLIVE_ASSERT(GetDigitCount(80085) == 5);
OLIVE_ASSERT(GetDigitCount(555555) == 6);
OLIVE_ASSERT(GetDigitCount(8675309) == 7);
OLIVE_ASSERT(GetDigitCount(78956423) == 8);
OLIVE_ASSERT(GetDigitCount(148497523) == 9);
OLIVE_ASSERT(GetDigitCount(4845821233) == 10);
OLIVE_ASSERT(GetDigitCount(18002738255) == 11);
OLIVE_ASSERT(GetDigitCount(180027382556) == 12);
OLIVE_ASSERT(GetDigitCount(1800273825568) == 13);
OLIVE_ASSERT(GetDigitCount(18002738255685) == 14);
OLIVE_ASSERT(GetDigitCount(180027382556857) == 15);
OLIVE_ASSERT(GetDigitCount(1800273825564857) == 16);
OAK_ASSERT(get_digit_count(1) == 1);
OAK_ASSERT(get_digit_count(69) == 2);
OAK_ASSERT(get_digit_count(420) == 3);
OAK_ASSERT(get_digit_count(1337) == 4);
OAK_ASSERT(get_digit_count(80085) == 5);
OAK_ASSERT(get_digit_count(555555) == 6);
OAK_ASSERT(get_digit_count(8675309) == 7);
OAK_ASSERT(get_digit_count(78956423) == 8);
OAK_ASSERT(get_digit_count(148497523) == 9);
OAK_ASSERT(get_digit_count(4845821233) == 10);
OAK_ASSERT(get_digit_count(18002738255) == 11);
OAK_ASSERT(get_digit_count(180027382556) == 12);
OAK_ASSERT(get_digit_count(1800273825568) == 13);
OAK_ASSERT(get_digit_count(18002738255685) == 14);
OAK_ASSERT(get_digit_count(180027382556857) == 15);
OAK_ASSERT(get_digit_count(1800273825564857) == 16);
OLIVE_TEST_END;
OAK_TEST_END;
}
}