style: unify identifier naming per updated conventions

Automated with clang-tidy readability-identifier-naming (config added to
.clang-tidy) plus scripted passes, per the updated rules now documented
in CONTRIBUTING.md:

- types (class/struct/enum/alias/template params): PascalCase
- functions, variables, members: snake_case (incl. rational -> Rational)
- private/protected members: trailing underscore; static member
  variables likewise (instance_, available_themes_)
- constants and enum values: snake_case (kLinear -> k_linear,
  F32P -> f32p); ALL_CAPS reserved for macros
- macros: OAK_ prefix (OLIVE_ADD_TEST/OLIVE_ASSERT/OLIVE_CONFIG ->
  OAK_ADD_TEST/OAK_ASSERT/OAK_CONFIG, GL_PREAMBLE -> OAK_GL_PREAMBLE,
  include guards -> OAK_*)
- file names: all lowercase (Current/Plugin/OliveHost/OliveClip/
  OlivePluginInstance -> current/plugin/olivehost/oliveclip/
  oliveplugininstance)
- getters share the member name sans underscore, setters set_foo()
- Qt and third-party (OpenFX) virtual overrides and framework callbacks
  keep their original names (exempt in .clang-tidy)

Manual follow-ups required where automation could not reach:
- string-based QMetaObject/SIGNAL/SLOT references updated to renamed
  methods (AddTask, CreatedFile, DeleteSpecificFile, moveSelectionUp, ...)
- macro bodies referencing renamed methods (OLIVE_CONFIG,
  NODE_DEFAULT_DESTRUCTOR, MANAGEDDISPLAYWIDGET_*)
- self-shadowing locals renamed where signals/methods became same-named
  (size_changed, worker_count, selected_items, import param, filters)
- third_party OFX member/namespace usages restored (OFX::Host::*,
  _created, _clipPrefsDirty, createInstance, clearPersistentMessage)
- STL protocol aliases restored (const_iterator) with .clang-tidy
  ignore rules; qHash overloads restored

Full build and test suite pass: ctest 4/4, ~1960 gtest cases green.
This commit is contained in:
2026-07-19 16:10:54 +08:00
parent cb1718a103
commit bb40b4923e
1014 changed files with 44257 additions and 44220 deletions
+14 -14
View File
@@ -28,22 +28,22 @@ using namespace olive::core;
bool rational_to_from_string_test()
{
rational r(1, 30);
Rational r(1, 30);
std::string s = r.toString();
rational r2 = rational::fromString(s);
Rational r2 = Rational::fromString(s);
return r == r2;
}
bool rational_to_from_string_test2()
{
rational r(69, 420);
Rational r(69, 420);
std::string s = r.toString();
rational r2 = rational::fromString(s);
Rational r2 = Rational::fromString(s);
return r == r2;
}
@@ -51,7 +51,7 @@ bool rational_to_from_string_test2()
bool rational_defaults()
{
// By default, rationals are valid 0/1
rational basic_constructor;
Rational basic_constructor;
if (!basic_constructor.isNull()) {
return false;
@@ -67,21 +67,21 @@ bool rational_defaults()
bool rational_nan()
{
// Create a NaN with a 0 denominator
rational nan = rational(0, 0);
Rational nan = Rational(0, 0);
if (!nan.isNaN())
return false;
if (!nan.isNull())
return false;
// Create a non-NaN with a zero numerator
rational zero_nonnan(0, 999);
Rational zero_nonnan(0, 999);
if (!zero_nonnan.isNull())
return false;
if (zero_nonnan.isNaN())
return false;
// Create a non-NaN with a non-zero numerator
rational nonzer_nonnan(1, 30);
Rational nonzer_nonnan(1, 30);
if (nonzer_nonnan.isNull())
return false;
if (nonzer_nonnan.isNaN())
@@ -92,18 +92,18 @@ bool rational_nan()
bool rational_nan_constant()
{
return rational::NaN.isNaN();
return Rational::NaN.isNaN();
}
int main()
{
Tester t;
t.add("rational::defaults", rational_defaults);
t.add("rational::NaN", rational_nan);
t.add("rational::NaN_constant", rational_nan_constant);
t.add("rational::toString/fromString", rational_to_from_string_test);
t.add("rational::toString/fromString2", rational_to_from_string_test2);
t.add("Rational::defaults", rational_defaults);
t.add("Rational::NaN", rational_nan);
t.add("Rational::NaN_constant", rational_nan_constant);
t.add("Rational::toString/fromString", rational_to_from_string_test);
t.add("Rational::toString/fromString2", rational_to_from_string_test2);
return t.exec();
}
+4 -4
View File
@@ -28,10 +28,10 @@ using namespace olive::core;
bool timecodefunctions_time_to_timecode_test()
{
rational drop_frame_30(1001, 30000);
Rational drop_frame_30(1001, 30000);
std::string timecode = Timecode::time_to_timecode(
rational(1), drop_frame_30, Timecode::kTimecodeDropFrame);
Rational(1), drop_frame_30, Timecode::kTimecodeDropFrame);
if (strcmp(timecode.c_str(), "00:00:01;00") != 0) {
return false;
}
@@ -41,10 +41,10 @@ bool timecodefunctions_time_to_timecode_test()
bool timecodefunctions_time_to_timecode_test2()
{
rational bizarre_timebase(156632219);
Rational bizarre_timebase(156632219);
std::string timecode = Timecode::time_to_timecode(
rational(0), bizarre_timebase, Timecode::kTimecodeDropFrame);
Rational(0), bizarre_timebase, Timecode::kTimecodeDropFrame);
if (strcmp(timecode.c_str(), "INVALID TIMEBASE") != 0) {
return false;
}