oak-team/oak-editor
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

style: unify identifier naming per updated conventions

Browse Source 
Automated with clang-tidy readability-identifier-naming (config added to
.clang-tidy) plus scripted passes, per the updated rules now documented
in CONTRIBUTING.md:

- types (class/struct/enum/alias/template params): PascalCase
- functions, variables, members: snake_case (incl. rational -> Rational)
- private/protected members: trailing underscore; static member
  variables likewise (instance_, available_themes_)
- constants and enum values: snake_case (kLinear -> k_linear,
  F32P -> f32p); ALL_CAPS reserved for macros
- macros: OAK_ prefix (OLIVE_ADD_TEST/OLIVE_ASSERT/OLIVE_CONFIG ->
  OAK_ADD_TEST/OAK_ASSERT/OAK_CONFIG, GL_PREAMBLE -> OAK_GL_PREAMBLE,
  include guards -> OAK_*)
- file names: all lowercase (Current/Plugin/OliveHost/OliveClip/
  OlivePluginInstance -> current/plugin/olivehost/oliveclip/
  oliveplugininstance)
- getters share the member name sans underscore, setters set_foo()
- Qt and third-party (OpenFX) virtual overrides and framework callbacks
  keep their original names (exempt in .clang-tidy)

Manual follow-ups required where automation could not reach:
- string-based QMetaObject/SIGNAL/SLOT references updated to renamed
  methods (AddTask, CreatedFile, DeleteSpecificFile, moveSelectionUp, ...)
- macro bodies referencing renamed methods (OLIVE_CONFIG,
  NODE_DEFAULT_DESTRUCTOR, MANAGEDDISPLAYWIDGET_*)
- self-shadowing locals renamed where signals/methods became same-named
  (size_changed, worker_count, selected_items, import param, filters)
- third_party OFX member/namespace usages restored (OFX::Host::*,
  _created, _clipPrefsDirty, createInstance, clearPersistentMessage)
- STL protocol aliases restored (const_iterator) with .clang-tidy
  ignore rules; qHash overloads restored

Full build and test suite pass: ctest 4/4, ~1960 gtest cases green.
This commit is contained in:
Mike-Solar
2026-07-19 16:10:54 +08:00
parent cb1718a103
commit bb40b4923e
1014 changed files with 44257 additions and 44220 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/window/mainwindow/mainstatusbar.cpp
+20 -20
View File
@@ -46,64 +46,64 @@ MainStatusBar::MainStatusBar(QWidget *parent)
10000);
}
void MainStatusBar::ConnectTaskManager(TaskManager *manager)
void MainStatusBar::connect_task_manager(TaskManager *manager)
{
if (manager_) {
disconnect(manager_, &TaskManager::TaskListChanged, this,
&MainStatusBar::UpdateStatus);
disconnect(manager_, &TaskManager::task_list_changed, this,
&MainStatusBar::update_status);
}
manager_ = manager;
if (manager_) {
connect(manager_, &TaskManager::TaskListChanged, this,
&MainStatusBar::UpdateStatus);
connect(manager_, &TaskManager::task_list_changed, this,
&MainStatusBar::update_status);
}
}
void MainStatusBar::UpdateStatus()
void MainStatusBar::update_status()
{
if (!manager_) {
return;
}
if (manager_->GetTaskCount() == 0) {
if (manager_->get_task_count() == 0) {
clearMessage();
bar_->setVisible(false);
bar_->setValue(0);
} else {
Task *t = manager_->GetFirstTask();
Task *t = manager_->get_first_task();
if (manager_->GetTaskCount() == 1) {
showMessage(t->GetTitle());
if (manager_->get_task_count() == 1) {
showMessage(t->get_title());
} else {
showMessage(tr("Running %n background task(s)", nullptr,
manager_->GetTaskCount()));
manager_->get_task_count()));
}
bar_->setVisible(true);
if (connected_task_) {
disconnect(connected_task_, &Task::ProgressChanged, this,
&MainStatusBar::SetProgressBarValue);
disconnect(connected_task_, &Task::progress_changed, this,
&MainStatusBar::set_progress_bar_value);
disconnect(connected_task_, &Task::destroyed, this,
&MainStatusBar::ConnectedTaskDeleted);
&MainStatusBar::connected_task_deleted);
}
connected_task_ = t;
connect(connected_task_, &Task::ProgressChanged, this,
&MainStatusBar::SetProgressBarValue);
connect(connected_task_, &Task::progress_changed, this,
&MainStatusBar::set_progress_bar_value);
connect(connected_task_, &Task::destroyed, this,
&MainStatusBar::ConnectedTaskDeleted);
&MainStatusBar::connected_task_deleted);
}
}
void MainStatusBar::SetProgressBarValue(double d)
void MainStatusBar::set_progress_bar_value(double d)
{
bar_->setValue(qRound(100.0 * d));
}
void MainStatusBar::ConnectedTaskDeleted()
void MainStatusBar::connected_task_deleted()
{
connected_task_ = nullptr;
}
@@ -112,7 +112,7 @@ void MainStatusBar::mouseDoubleClickEvent(QMouseEvent *e)
{
QStatusBar::mouseDoubleClickEvent(e);
emit DoubleClicked();
emit double_clicked();
}
}