oak-team/oak-editor
3
1
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

style: unify identifier naming per updated conventions

Browse Source 
Automated with clang-tidy readability-identifier-naming (config added to
.clang-tidy) plus scripted passes, per the updated rules now documented
in CONTRIBUTING.md:

- types (class/struct/enum/alias/template params): PascalCase
- functions, variables, members: snake_case (incl. rational -> Rational)
- private/protected members: trailing underscore; static member
  variables likewise (instance_, available_themes_)
- constants and enum values: snake_case (kLinear -> k_linear,
  F32P -> f32p); ALL_CAPS reserved for macros
- macros: OAK_ prefix (OLIVE_ADD_TEST/OLIVE_ASSERT/OLIVE_CONFIG ->
  OAK_ADD_TEST/OAK_ASSERT/OAK_CONFIG, GL_PREAMBLE -> OAK_GL_PREAMBLE,
  include guards -> OAK_*)
- file names: all lowercase (Current/Plugin/OliveHost/OliveClip/
  OlivePluginInstance -> current/plugin/olivehost/oliveclip/
  oliveplugininstance)
- getters share the member name sans underscore, setters set_foo()
- Qt and third-party (OpenFX) virtual overrides and framework callbacks
  keep their original names (exempt in .clang-tidy)

Manual follow-ups required where automation could not reach:
- string-based QMetaObject/SIGNAL/SLOT references updated to renamed
  methods (AddTask, CreatedFile, DeleteSpecificFile, moveSelectionUp, ...)
- macro bodies referencing renamed methods (OLIVE_CONFIG,
  NODE_DEFAULT_DESTRUCTOR, MANAGEDDISPLAYWIDGET_*)
- self-shadowing locals renamed where signals/methods became same-named
  (size_changed, worker_count, selected_items, import param, filters)
- third_party OFX member/namespace usages restored (OFX::Host::*,
  _created, _clipPrefsDirty, createInstance, clearPersistentMessage)
- STL protocol aliases restored (const_iterator) with .clang-tidy
  ignore rules; qHash overloads restored

Full build and test suite pass: ctest 4/4, ~1960 gtest cases green.
This commit is contained in:
Mike-Solar
2026-07-19 16:10:54 +08:00
parent cb1718a103
commit bb40b4923e
1014 changed files with 44257 additions and 44220 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/widget/viewer/viewerwindow.h
+8 -8
View File
@@ -19,8 +19,8 @@
***/
#ifndef VIEWERWINDOW_H
#define VIEWERWINDOW_H
#ifndef OAK_VIEWERWINDOW_H
#define OAK_VIEWERWINDOW_H
#include <QWidget>
@@ -41,17 +41,17 @@ public:
* Equivalent to calling SetResolution and SetPixelAspectRatio, just slightly faster since we
* only calculate the matrix once rather than twice.
*/
void SetVideoParams(const VideoParams &params);
void set_video_params(const VideoParams &params);
/**
* @brief Used to adjust resulting picture to be the right aspect ratio
*/
void SetResolution(int width, int height);
void set_resolution(int width, int height);
/**
* @brief Used to adjust resulting picture to be the right aspect ratio
*/
void SetPixelAspectRatio(const rational &pixel_aspect);
void set_pixel_aspect_ratio(const Rational &pixel_aspect);
protected:
virtual void keyPressEvent(QKeyEvent *e) override;
@@ -59,7 +59,7 @@ protected:
virtual void closeEvent(QCloseEvent *e) override;
private:
void UpdateMatrix();
void update_matrix();
int width_;
@@ -67,9 +67,9 @@ private:
ViewerDisplayWidget *display_widget_;
rational pixel_aspect_;
Rational pixel_aspect_;
};
}
#endif // VIEWERWINDOW_H
#endif // OAK_VIEWERWINDOW_H