style: unify identifier naming per updated conventions
Automated with clang-tidy readability-identifier-naming (config added to .clang-tidy) plus scripted passes, per the updated rules now documented in CONTRIBUTING.md: - types (class/struct/enum/alias/template params): PascalCase - functions, variables, members: snake_case (incl. rational -> Rational) - private/protected members: trailing underscore; static member variables likewise (instance_, available_themes_) - constants and enum values: snake_case (kLinear -> k_linear, F32P -> f32p); ALL_CAPS reserved for macros - macros: OAK_ prefix (OLIVE_ADD_TEST/OLIVE_ASSERT/OLIVE_CONFIG -> OAK_ADD_TEST/OAK_ASSERT/OAK_CONFIG, GL_PREAMBLE -> OAK_GL_PREAMBLE, include guards -> OAK_*) - file names: all lowercase (Current/Plugin/OliveHost/OliveClip/ OlivePluginInstance -> current/plugin/olivehost/oliveclip/ oliveplugininstance) - getters share the member name sans underscore, setters set_foo() - Qt and third-party (OpenFX) virtual overrides and framework callbacks keep their original names (exempt in .clang-tidy) Manual follow-ups required where automation could not reach: - string-based QMetaObject/SIGNAL/SLOT references updated to renamed methods (AddTask, CreatedFile, DeleteSpecificFile, moveSelectionUp, ...) - macro bodies referencing renamed methods (OLIVE_CONFIG, NODE_DEFAULT_DESTRUCTOR, MANAGEDDISPLAYWIDGET_*) - self-shadowing locals renamed where signals/methods became same-named (size_changed, worker_count, selected_items, import param, filters) - third_party OFX member/namespace usages restored (OFX::Host::*, _created, _clipPrefsDirty, createInstance, clearPersistentMessage) - STL protocol aliases restored (const_iterator) with .clang-tidy ignore rules; qHash overloads restored Full build and test suite pass: ctest 4/4, ~1960 gtest cases green.
This commit is contained in:
@@ -30,12 +30,12 @@ TimeTargetObject::TimeTargetObject()
|
||||
{
|
||||
}
|
||||
|
||||
ViewerOutput *TimeTargetObject::GetTimeTarget() const
|
||||
ViewerOutput *TimeTargetObject::get_time_target() const
|
||||
{
|
||||
return time_target_;
|
||||
}
|
||||
|
||||
void TimeTargetObject::SetTimeTarget(ViewerOutput *target)
|
||||
void TimeTargetObject::set_time_target(ViewerOutput *target)
|
||||
{
|
||||
if (time_target_) {
|
||||
TimeTargetDisconnectEvent(time_target_);
|
||||
@@ -49,31 +49,31 @@ void TimeTargetObject::SetTimeTarget(ViewerOutput *target)
|
||||
}
|
||||
}
|
||||
|
||||
void TimeTargetObject::SetPathIndex(int index)
|
||||
void TimeTargetObject::set_path_index(int index)
|
||||
{
|
||||
path_index_ = index;
|
||||
}
|
||||
|
||||
rational
|
||||
TimeTargetObject::GetAdjustedTime(Node *from, Node *to, const rational &r,
|
||||
Rational
|
||||
TimeTargetObject::get_adjusted_time(Node *from, Node *to, const Rational &r,
|
||||
Node::TransformTimeDirection dir) const
|
||||
{
|
||||
if (!from || !to) {
|
||||
return r;
|
||||
}
|
||||
|
||||
return GetAdjustedTime(from, to, TimeRange(r, r), dir).in();
|
||||
return get_adjusted_time(from, to, TimeRange(r, r), dir).in();
|
||||
}
|
||||
|
||||
TimeRange
|
||||
TimeTargetObject::GetAdjustedTime(Node *from, Node *to, const TimeRange &r,
|
||||
TimeTargetObject::get_adjusted_time(Node *from, Node *to, const TimeRange &r,
|
||||
Node::TransformTimeDirection dir) const
|
||||
{
|
||||
if (!from || !to) {
|
||||
return r;
|
||||
}
|
||||
|
||||
return from->TransformTimeTo(r, to, dir, path_index_);
|
||||
return from->transform_time_to(r, to, dir, path_index_);
|
||||
}
|
||||
|
||||
/*int TimeTargetObject::GetNumberOfPathAdjustments(Node* from, NodeParam::Type direction) const
|
||||
|
||||
@@ -19,8 +19,8 @@
|
||||
|
||||
***/
|
||||
|
||||
#ifndef TIMETARGETOBJECT_H
|
||||
#define TIMETARGETOBJECT_H
|
||||
#ifndef OAK_TIMETARGETOBJECT_H
|
||||
#define OAK_TIMETARGETOBJECT_H
|
||||
|
||||
#include "node/output/viewer/viewer.h"
|
||||
|
||||
@@ -31,14 +31,14 @@ class TimeTargetObject {
|
||||
public:
|
||||
TimeTargetObject();
|
||||
|
||||
ViewerOutput *GetTimeTarget() const;
|
||||
void SetTimeTarget(ViewerOutput *target);
|
||||
ViewerOutput *get_time_target() const;
|
||||
void set_time_target(ViewerOutput *target);
|
||||
|
||||
void SetPathIndex(int index);
|
||||
void set_path_index(int index);
|
||||
|
||||
rational GetAdjustedTime(Node *from, Node *to, const rational &r,
|
||||
Rational get_adjusted_time(Node *from, Node *to, const Rational &r,
|
||||
Node::TransformTimeDirection dir) const;
|
||||
TimeRange GetAdjustedTime(Node *from, Node *to, const TimeRange &r,
|
||||
TimeRange get_adjusted_time(Node *from, Node *to, const TimeRange &r,
|
||||
Node::TransformTimeDirection dir) const;
|
||||
|
||||
//int GetNumberOfPathAdjustments(Node* from, NodeParam::Type direction) const;
|
||||
@@ -62,4 +62,4 @@ private:
|
||||
|
||||
}
|
||||
|
||||
#endif // TIMETARGETOBJECT_H
|
||||
#endif // OAK_TIMETARGETOBJECT_H
|
||||
|
||||
Reference in New Issue
Block a user