style: unify identifier naming per updated conventions

Automated with clang-tidy readability-identifier-naming (config added to
.clang-tidy) plus scripted passes, per the updated rules now documented
in CONTRIBUTING.md:

- types (class/struct/enum/alias/template params): PascalCase
- functions, variables, members: snake_case (incl. rational -> Rational)
- private/protected members: trailing underscore; static member
  variables likewise (instance_, available_themes_)
- constants and enum values: snake_case (kLinear -> k_linear,
  F32P -> f32p); ALL_CAPS reserved for macros
- macros: OAK_ prefix (OLIVE_ADD_TEST/OLIVE_ASSERT/OLIVE_CONFIG ->
  OAK_ADD_TEST/OAK_ASSERT/OAK_CONFIG, GL_PREAMBLE -> OAK_GL_PREAMBLE,
  include guards -> OAK_*)
- file names: all lowercase (Current/Plugin/OliveHost/OliveClip/
  OlivePluginInstance -> current/plugin/olivehost/oliveclip/
  oliveplugininstance)
- getters share the member name sans underscore, setters set_foo()
- Qt and third-party (OpenFX) virtual overrides and framework callbacks
  keep their original names (exempt in .clang-tidy)

Manual follow-ups required where automation could not reach:
- string-based QMetaObject/SIGNAL/SLOT references updated to renamed
  methods (AddTask, CreatedFile, DeleteSpecificFile, moveSelectionUp, ...)
- macro bodies referencing renamed methods (OLIVE_CONFIG,
  NODE_DEFAULT_DESTRUCTOR, MANAGEDDISPLAYWIDGET_*)
- self-shadowing locals renamed where signals/methods became same-named
  (size_changed, worker_count, selected_items, import param, filters)
- third_party OFX member/namespace usages restored (OFX::Host::*,
  _created, _clipPrefsDirty, createInstance, clearPersistentMessage)
- STL protocol aliases restored (const_iterator) with .clang-tidy
  ignore rules; qHash overloads restored

Full build and test suite pass: ctest 4/4, ~1960 gtest cases green.
This commit is contained in:
2026-07-19 16:10:54 +08:00
parent cb1718a103
commit bb40b4923e
1014 changed files with 44257 additions and 44220 deletions
@@ -51,7 +51,7 @@ TrackView::TrackView(Qt::Alignment vertical_alignment, QWidget *parent)
layout->addStretch();
connect(verticalScrollBar(), &QScrollBar::rangeChanged, this,
&TrackView::ScrollbarRangeChanged);
&TrackView::scrollbar_range_changed);
last_scrollbar_max_ = verticalScrollBar()->maximum();
}
@@ -63,51 +63,51 @@ TrackView::TrackView(Qt::Alignment vertical_alignment, QWidget *parent)
layout->addStretch();
}
connect(splitter_, &TrackViewSplitter::TrackHeightChanged, this,
&TrackView::TrackHeightChanged);
connect(splitter_, &TrackViewSplitter::track_height_changed, this,
&TrackView::track_height_changed);
setHorizontalScrollBarPolicy(Qt::ScrollBarAlwaysOff);
setVerticalScrollBarPolicy(Qt::ScrollBarAlwaysOff);
}
void TrackView::ConnectTrackList(TrackList *list)
void TrackView::connect_track_list(TrackList *list)
{
if (list_ != nullptr) {
// Remove tracks
for (int i = 0; i < list_->GetTrackCount(); i++) {
splitter_->Remove(0);
for (int i = 0; i < list_->get_track_count(); i++) {
splitter_->remove(0);
}
disconnect(list_, &TrackList::TrackAdded, this,
&TrackView::InsertTrack);
disconnect(list_, &TrackList::TrackRemoved, this,
&TrackView::RemoveTrack);
disconnect(list_, &TrackList::track_added, this,
&TrackView::insert_track);
disconnect(list_, &TrackList::track_removed, this,
&TrackView::remove_track);
}
list_ = list;
if (list_ != nullptr) {
foreach (Track *track, list_->GetTracks()) {
InsertTrack(track);
foreach (Track *track, list_->get_tracks()) {
insert_track(track);
}
connect(list_, &TrackList::TrackAdded, this, &TrackView::InsertTrack);
connect(list_, &TrackList::TrackRemoved, this, &TrackView::RemoveTrack);
connect(list_, &TrackList::track_added, this, &TrackView::insert_track);
connect(list_, &TrackList::track_removed, this, &TrackView::remove_track);
}
}
void TrackView::DisconnectTrackList()
void TrackView::disconnect_track_list()
{
ConnectTrackList(nullptr);
connect_track_list(nullptr);
}
void TrackView::resizeEvent(QResizeEvent *e)
{
QScrollArea::resizeEvent(e);
splitter_->SetSpacerHeight(height() / 2);
splitter_->set_spacer_height(height() / 2);
}
void TrackView::ScrollbarRangeChanged(int, int max)
void TrackView::scrollbar_range_changed(int, int max)
{
if (max != last_scrollbar_max_) {
int ba_val = last_scrollbar_max_ - verticalScrollBar()->value();
@@ -120,24 +120,24 @@ void TrackView::ScrollbarRangeChanged(int, int max)
}
}
void TrackView::TrackHeightChanged(int index, int height)
void TrackView::track_height_changed(int index, int height)
{
list_->GetTrackAt(index)->SetTrackHeightInPixels(height);
list_->get_track_at(index)->set_track_height_in_pixels(height);
}
void TrackView::InsertTrack(Track *track)
void TrackView::insert_track(Track *track)
{
TrackViewItem *tvi = new TrackViewItem(track);
connect(tvi, &TrackViewItem::AboutToDeleteTrack, this,
&TrackView::AboutToDeleteTrack);
connect(tvi, &TrackViewItem::about_to_delete_track, this,
&TrackView::about_to_delete_track);
splitter_->Insert(track->Index(), track->GetTrackHeightInPixels(), tvi);
splitter_->insert(track->index(), track->get_track_height_in_pixels(), tvi);
}
void TrackView::RemoveTrack(Track *track)
void TrackView::remove_track(Track *track)
{
splitter_->Remove(track->Index());
splitter_->remove(track->index());
}
}