oak-team/oak-editor
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

style: unify identifier naming per updated conventions

Browse Source 
Automated with clang-tidy readability-identifier-naming (config added to
.clang-tidy) plus scripted passes, per the updated rules now documented
in CONTRIBUTING.md:

- types (class/struct/enum/alias/template params): PascalCase
- functions, variables, members: snake_case (incl. rational -> Rational)
- private/protected members: trailing underscore; static member
  variables likewise (instance_, available_themes_)
- constants and enum values: snake_case (kLinear -> k_linear,
  F32P -> f32p); ALL_CAPS reserved for macros
- macros: OAK_ prefix (OLIVE_ADD_TEST/OLIVE_ASSERT/OLIVE_CONFIG ->
  OAK_ADD_TEST/OAK_ASSERT/OAK_CONFIG, GL_PREAMBLE -> OAK_GL_PREAMBLE,
  include guards -> OAK_*)
- file names: all lowercase (Current/Plugin/OliveHost/OliveClip/
  OlivePluginInstance -> current/plugin/olivehost/oliveclip/
  oliveplugininstance)
- getters share the member name sans underscore, setters set_foo()
- Qt and third-party (OpenFX) virtual overrides and framework callbacks
  keep their original names (exempt in .clang-tidy)

Manual follow-ups required where automation could not reach:
- string-based QMetaObject/SIGNAL/SLOT references updated to renamed
  methods (AddTask, CreatedFile, DeleteSpecificFile, moveSelectionUp, ...)
- macro bodies referencing renamed methods (OLIVE_CONFIG,
  NODE_DEFAULT_DESTRUCTOR, MANAGEDDISPLAYWIDGET_*)
- self-shadowing locals renamed where signals/methods became same-named
  (size_changed, worker_count, selected_items, import param, filters)
- third_party OFX member/namespace usages restored (OFX::Host::*,
  _created, _clipPrefsDirty, createInstance, clearPersistentMessage)
- STL protocol aliases restored (const_iterator) with .clang-tidy
  ignore rules; qHash overloads restored

Full build and test suite pass: ctest 4/4, ~1960 gtest cases green.
This commit is contained in:
Mike-Solar
2026-07-19 16:10:54 +08:00
parent cb1718a103
commit bb40b4923e
1014 changed files with 44257 additions and 44220 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/widget/taskview/taskviewitem.cpp
+10 -10
View File
@@ -41,7 +41,7 @@ TaskViewItem::TaskViewItem(Task *task, QWidget *parent)
// Create header label
task_name_lbl_ = new QLabel(this);
task_name_lbl_->setText(task_->GetTitle());
task_name_lbl_->setText(task_->get_title());
layout->addWidget(task_name_lbl_);
// Create center layout (combines progress bar and a cancel button)
@@ -55,7 +55,7 @@ TaskViewItem::TaskViewItem(Task *task, QWidget *parent)
// Create cancel button
cancel_btn_ = new QPushButton(this);
cancel_btn_->setIcon(icon::Error);
cancel_btn_->setIcon(icon::error);
middle_layout->addWidget(cancel_btn_);
// Create stack with error label and elapsed/remaining time
@@ -75,24 +75,24 @@ TaskViewItem::TaskViewItem(Task *task, QWidget *parent)
status_stack_->setCurrentWidget(elapsed_timer_lbl_);
// Connect to the task
connect(task_, &Task::Started, elapsed_timer_lbl_,
qOverload<qint64>(&ElapsedCounterWidget::Start));
connect(task_, &Task::ProgressChanged, this, &TaskViewItem::UpdateProgress);
connect(task_, &Task::started, elapsed_timer_lbl_,
qOverload<qint64>(&ElapsedCounterWidget::start));
connect(task_, &Task::progress_changed, this, &TaskViewItem::update_progress);
connect(cancel_btn_, &QPushButton::clicked, this,
[this] { emit TaskCancelled(task_); });
[this] { emit task_cancelled(task_); });
}
void TaskViewItem::Failed()
void TaskViewItem::failed()
{
status_stack_->setCurrentWidget(task_error_lbl_);
task_error_lbl_->setStyleSheet("color: red");
task_error_lbl_->setText(tr("Error: %1").arg(task_->GetError()));
task_error_lbl_->setText(tr("Error: %1").arg(task_->get_error()));
}
void TaskViewItem::UpdateProgress(double d)
void TaskViewItem::update_progress(double d)
{
progress_bar_->setValue(qRound(100.0 * d));
elapsed_timer_lbl_->SetProgress(d);
elapsed_timer_lbl_->set_progress(d);
}
}