oak-team/oak-editor
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

style: unify identifier naming per updated conventions

Browse Source 
Automated with clang-tidy readability-identifier-naming (config added to
.clang-tidy) plus scripted passes, per the updated rules now documented
in CONTRIBUTING.md:

- types (class/struct/enum/alias/template params): PascalCase
- functions, variables, members: snake_case (incl. rational -> Rational)
- private/protected members: trailing underscore; static member
  variables likewise (instance_, available_themes_)
- constants and enum values: snake_case (kLinear -> k_linear,
  F32P -> f32p); ALL_CAPS reserved for macros
- macros: OAK_ prefix (OLIVE_ADD_TEST/OLIVE_ASSERT/OLIVE_CONFIG ->
  OAK_ADD_TEST/OAK_ASSERT/OAK_CONFIG, GL_PREAMBLE -> OAK_GL_PREAMBLE,
  include guards -> OAK_*)
- file names: all lowercase (Current/Plugin/OliveHost/OliveClip/
  OlivePluginInstance -> current/plugin/olivehost/oliveclip/
  oliveplugininstance)
- getters share the member name sans underscore, setters set_foo()
- Qt and third-party (OpenFX) virtual overrides and framework callbacks
  keep their original names (exempt in .clang-tidy)

Manual follow-ups required where automation could not reach:
- string-based QMetaObject/SIGNAL/SLOT references updated to renamed
  methods (AddTask, CreatedFile, DeleteSpecificFile, moveSelectionUp, ...)
- macro bodies referencing renamed methods (OLIVE_CONFIG,
  NODE_DEFAULT_DESTRUCTOR, MANAGEDDISPLAYWIDGET_*)
- self-shadowing locals renamed where signals/methods became same-named
  (size_changed, worker_count, selected_items, import param, filters)
- third_party OFX member/namespace usages restored (OFX::Host::*,
  _created, _clipPrefsDirty, createInstance, clearPersistentMessage)
- STL protocol aliases restored (const_iterator) with .clang-tidy
  ignore rules; qHash overloads restored

Full build and test suite pass: ctest 4/4, ~1960 gtest cases green.
This commit is contained in:
Mike-Solar
2026-07-19 16:10:54 +08:00
parent cb1718a103
commit bb40b4923e
1014 changed files with 44257 additions and 44220 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/widget/taskview/elapsedcounterwidget.cpp
+10 -10
View File
@@ -48,34 +48,34 @@ ElapsedCounterWidget::ElapsedCounterWidget(QWidget *parent)
elapsed_timer_.setInterval(500);
connect(&elapsed_timer_, &QTimer::timeout, this,
&ElapsedCounterWidget::UpdateTimers);
UpdateTimers();
&ElapsedCounterWidget::update_timers);
update_timers();
}
void ElapsedCounterWidget::SetProgress(double d)
void ElapsedCounterWidget::set_progress(double d)
{
last_progress_ = d;
UpdateTimers();
update_timers();
}
void ElapsedCounterWidget::Start()
void ElapsedCounterWidget::start()
{
Start(QDateTime::currentMSecsSinceEpoch());
start(QDateTime::currentMSecsSinceEpoch());
}
void ElapsedCounterWidget::Start(qint64 start_time)
void ElapsedCounterWidget::start(qint64 start_time)
{
start_time_ = start_time;
elapsed_timer_.start();
UpdateTimers();
update_timers();
}
void ElapsedCounterWidget::Stop()
void ElapsedCounterWidget::stop()
{
elapsed_timer_.stop();
}
void ElapsedCounterWidget::UpdateTimers()
void ElapsedCounterWidget::update_timers()
{
int64_t elapsed_ms, remaining_ms;