style: unify identifier naming per updated conventions
Automated with clang-tidy readability-identifier-naming (config added to .clang-tidy) plus scripted passes, per the updated rules now documented in CONTRIBUTING.md: - types (class/struct/enum/alias/template params): PascalCase - functions, variables, members: snake_case (incl. rational -> Rational) - private/protected members: trailing underscore; static member variables likewise (instance_, available_themes_) - constants and enum values: snake_case (kLinear -> k_linear, F32P -> f32p); ALL_CAPS reserved for macros - macros: OAK_ prefix (OLIVE_ADD_TEST/OLIVE_ASSERT/OLIVE_CONFIG -> OAK_ADD_TEST/OAK_ASSERT/OAK_CONFIG, GL_PREAMBLE -> OAK_GL_PREAMBLE, include guards -> OAK_*) - file names: all lowercase (Current/Plugin/OliveHost/OliveClip/ OlivePluginInstance -> current/plugin/olivehost/oliveclip/ oliveplugininstance) - getters share the member name sans underscore, setters set_foo() - Qt and third-party (OpenFX) virtual overrides and framework callbacks keep their original names (exempt in .clang-tidy) Manual follow-ups required where automation could not reach: - string-based QMetaObject/SIGNAL/SLOT references updated to renamed methods (AddTask, CreatedFile, DeleteSpecificFile, moveSelectionUp, ...) - macro bodies referencing renamed methods (OLIVE_CONFIG, NODE_DEFAULT_DESTRUCTOR, MANAGEDDISPLAYWIDGET_*) - self-shadowing locals renamed where signals/methods became same-named (size_changed, worker_count, selected_items, import param, filters) - third_party OFX member/namespace usages restored (OFX::Host::*, _created, _clipPrefsDirty, createInstance, clearPersistentMessage) - STL protocol aliases restored (const_iterator) with .clang-tidy ignore rules; qHash overloads restored Full build and test suite pass: ctest 4/4, ~1960 gtest cases green.
This commit is contained in:
@@ -19,8 +19,8 @@
|
||||
|
||||
***/
|
||||
|
||||
#ifndef CHANNELLAYOUTCOMBOBOX_H
|
||||
#define CHANNELLAYOUTCOMBOBOX_H
|
||||
#ifndef OAK_CHANNELLAYOUTCOMBOBOX_H
|
||||
#define OAK_CHANNELLAYOUTCOMBOBOX_H
|
||||
|
||||
#include <olive/core/core.h>
|
||||
#include <QComboBox>
|
||||
@@ -38,16 +38,16 @@ public:
|
||||
: QComboBox(parent)
|
||||
{
|
||||
foreach (const uint64_t &ch_layout,
|
||||
AudioParams::kSupportedChannelLayouts) {
|
||||
this->addItem(HumanStrings::ChannelLayoutToString(ch_layout),
|
||||
AudioParams::k_supported_channel_layouts) {
|
||||
this->addItem(HumanStrings::channel_layout_to_string(ch_layout),
|
||||
QVariant::fromValue(ch_layout));
|
||||
}
|
||||
}
|
||||
[[nodiscard]] uint64_t GetChannelLayout() const
|
||||
[[nodiscard]] uint64_t get_channel_layout() const
|
||||
{
|
||||
return this->currentData().toULongLong();
|
||||
}
|
||||
void SetChannelLayout(uint64_t ch)
|
||||
void set_channel_layout(uint64_t ch)
|
||||
{
|
||||
for (int i = 0; i < this->count(); i++) {
|
||||
if (this->itemData(i).toULongLong() == ch) {
|
||||
@@ -62,4 +62,4 @@ private:
|
||||
|
||||
}
|
||||
|
||||
#endif // CHANNELLAYOUTCOMBOBOX_H
|
||||
#endif // OAK_CHANNELLAYOUTCOMBOBOX_H
|
||||
|
||||
Reference in New Issue
Block a user